security/softether: use https site etc

[meta]

Summary

• add LICENSE_FILE
• use https site, upstream now provides https site
• remove MAKE_JOBS_UNSAFE as it actually builds
• do patch in post-patch, not post-extract
• do everything in do-install
• put DOS2UNIX_FILES, ONLY_FOR_ARCHSi in the right place

mat, if you have thoughts on Makefile issue on softether-devel port,
all issues are brought from softether port. Let's fix issues on softether
port. Then I copy softether to softether-devel and update softether-devel.

Bugzilla: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230047

[mat]

security/softether/Makefile

43

Why +=?

[meta]

remove unnecessary use of +=

[meta]

security/softether/Makefile

43

seems unnecessary, removed.

[meta]

similify DOS2UNIX_FILES

[meta]

bump PORTREVISION due to do-install target change

[meta]

Anything else? Will be maintainer timeout tomorrow.

[mat]

security/softether/Makefile

16–37

All this appears too early. See Chapter 15. Order of Variables in Port Makefiles.

[meta]

fix order of variables

[meta]

Anything else? Maintainer timeout now.

[mat]

security/softether/Makefile

56–58

This, and the next change are wrong, they replace make(1) comments with sh(1) comments, which should not be done.

[meta]

security/softether/Makefile

56–58

I cannot get you. You didn't say that in a review of -devel port I created before.
Can you show me how should Makefile be? Now I am the maintainer of this port. I accept your patches.

[meta]

pkg-message: use sysrc rather than editing rc.conf.

[meta]

remove unrelated file from diff