Page MenuHomeFreeBSD

*/*: Update MAINTAINER address of Kan Sasaki's ports
ClosedPublic

Authored by yasu on Sep 28 2021, 8:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 1:03 PM
Unknown Object (File)
Wed, Nov 6, 9:07 PM
Unknown Object (File)
Tue, Nov 5, 12:56 AM
Unknown Object (File)
Oct 27 2024, 2:20 AM
Unknown Object (File)
Oct 26 2024, 2:55 PM
Unknown Object (File)
Oct 8 2024, 10:23 AM
Unknown Object (File)
Sep 28 2024, 7:51 AM
Unknown Object (File)
Sep 21 2024, 12:04 AM
Subscribers

Details

Summary

PR: 258617 258618 258619 258620
Approved by: maintainer, meta (mentor), ygy (mentor)

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

yasu requested review of this revision.Sep 28 2021, 8:05 AM

Add 'Differential Revision:' to commig message.

Not bad but I would write commit message like this:

*/*: Update maintainer email

- devel/lua-stdlib-debug
- devel/lua-stdlib-normalize
- mail/smfsav
- mail/smfsav-devel

PR:
Submitted by:
Approved by:

Also, don't forget to include 'Submitted by:' line. It can be written in short by username like Submitted by: meta if the submitter is a FreeBSD developer.
If the submitter is maintainer, append '(maintainer)' on the line end.

This revision is now accepted and ready to land.Sep 28 2021, 8:31 AM
meta requested changes to this revision.Sep 28 2021, 8:31 AM
This revision now requires changes to proceed.Sep 28 2021, 8:31 AM

Update commit message as suggested by meta.

Almost fine but don't forget to add 'Submitted by:' line. Go ahead after adding the line.

This revision is now accepted and ready to land.Sep 28 2021, 9:52 AM
ygy requested changes to this revision.Sep 28 2021, 10:57 PM

As discussed, the "Submitted by" field is deprecated - please use author field.

We should also request the reporter to change their address in Bugzilla to this new address.

This revision now requires changes to proceed.Sep 28 2021, 10:57 PM

Set 'Author' of the commit to submitter of PR's.

This revision is now accepted and ready to land.Sep 29 2021, 5:44 AM

Changes are LGTM. However, I think push will be rejected author of the commit is different from committer.

This revision was automatically updated to reflect the committed changes.
In D32173#726853, @meta wrote:

I was suggested to use git push --push-option=confirm-author when I executed git push first.

Just FYI.

In D32173#726859, @yasu wrote:
In D32173#726853, @meta wrote:

I was suggested to use git push --push-option=confirm-author when I executed git push first.

Just FYI.

This is standard procedure. Sometimes committers could make mistakes in the author field, usually their personal mail or Charlie Root. The push option gives an opportunity to double-check before the commit is final.

Thank you both. I learned a new thing.