In D27505#615262, @hselasky wrote:

@melifaro : Did you have any more time to look at this? I guess we need to be backwards compatible and possible need to have a pool allocation for all interface names starting with "vlan" only? Other interface names are excluded from the unit management.

Whoops, remove another cast

Updated to reduce casting and use better variable types

Update from markj

update based on comment from brooks@

Hm, wanna see if it compiles using gcc-6 instead? mips32 SHOULD compile now, as long as you disable ZFS.

Hm, how's this work on mips32? Has anyone spun this up in qemu on malta+mips32?

Update with imp's comments

Fix!

whoops brb

hi! please lemme know what you think!

who has test hardware that can test this and report back?

I've fixed the warnings here - https://reviews.freebsd.org/D26839

1. Updating D26804: [gnuregex] Fix size demotion rounding errors that have crept up with later gcc #
2. Enter a brief description of the changes included in this update.
3. The first line is used as subject, next lines as comment.

• it fails on 32 bit compilations and we don't special case libnetmap to only compile on 64 bit platforms
• it fails on 64 bit platforms when compiling lib32, which blocks the amd64 buildworld
• since nr_options is a uint64_t and we're using it as a pointer type, we really should not be assuming pointer == sizeof(int type) like this

Do these routines need to be inlined? I can work on un-inlining them and submit a diff to fix things?

fwiw, I get a compiler error on gcc-6 on mips:

Yeah, if we ever support pushing a list of receive frames into the net80211 stack, complete with rx status in the mbuf tags, then I think we can do this in net80211 quite nicely. :-)

I'm not a huge fan of this cause honestly we should be doing the epoch enter/exit around a batch.

ignore the pmc related bits, it's not relevant for this fix

Lol, who did that? :-)