Page MenuHomeFreeBSD

net80211: update for (more) VHT160 support
ClosedPublic

Authored by bz on Oct 7 2020, 10:44 PM.

Details

Summary

Implement two macros IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_IS_160MHZ()
and its 80+80 counter part to check in vhtcaps for appropriate
levels of support and use the macros throughout the code.

Add vht160_chan_ranges/is_vht160_valid_freq and handle analogue
to vht80 in various parts of the code.

Add ieee80211_add_channel_cbw() which also takes the CBW flag
fields and make the former ieee80211_add_channel() a wrapper to it.
With the CBW flags we can add HT/VHT channels passing them to
getflags() for the 2/5ghz functions.

In ifconfig(8) add the regdomain_addchans() support for VHT160
and VHT80P80.

With this (+ regdoain.xml updates) VHT160 channels can be
configured, listed, and pass regdomain where appropriate.

Tested with:    iwlwifi
Sponsored by:   The FreeBSD Foundation
MFC after:      2 weeks
Reviewed by:    ...
Diff..:         ...

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bz requested review of this revision.Oct 7 2020, 10:44 PM
sys/compat/linuxkpi/common/include/linux/pci.h
32 ↗(On Diff #77997)

Ignore the pci.h additions here; arc diff --create --base=git:<branch> does not do what I thought it would. Sorry.

sys/net80211/ieee80211.c
1422 ↗(On Diff #77997)

Remove line before commit from this branch as well.

sys/net80211/ieee80211_regdomain.c
160 ↗(On Diff #77997)

I should commit these whitespace changes separately upfront as well.

sys/net80211/ieee80211_vht.c
202 ↗(On Diff #77997)

Remove extra debug line from this branch as well.

  • Remove debug printfs from here as well.
  • Remove the whitespace from regdomain.
  • Update comment about ieee80211_add_channel_cbw() now supporting HT40/VHT80/..

Anyone interested in reviewing this? I'd love to get it in no later than Monday.

This revision is now accepted and ready to land.Oct 16 2020, 6:48 PM
This revision was automatically updated to reflect the committed changes.