Page MenuHomeFreeBSD

[libcasper] Use null inline functions when casper is disabled
ClosedPublic

Authored by adrian on Oct 13 2020, 6:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 14, 5:57 PM
Unknown Object (File)
Sat, Oct 4, 7:34 AM
Unknown Object (File)
Wed, Oct 1, 4:19 AM
Unknown Object (File)
Sat, Sep 20, 4:37 AM
Unknown Object (File)
Sat, Sep 20, 1:48 AM
Unknown Object (File)
Sep 13 2025, 7:58 PM
Unknown Object (File)
Sep 12 2025, 11:00 PM
Unknown Object (File)
Sep 11 2025, 8:02 PM
Subscribers

Details

Summary
  • use null functions rather than defines to make sure the compiler doesn't complain about unused function arguments, which gcc-6 on mips32 indeed does!
Test Plan
  • compiled for freebsd wifi mips testing where i actively disable this stuff to save space

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Agree with the change, two small suggestions

lib/libcasper/services/cap_dns/cap_dns.h
47–48 ↗(On Diff #78177)

Maybe style disagrees but I'd probably just put these in the #else case below.

81 ↗(On Diff #78177)

maybe

static inline struct hostent *
cap_gethostbyname(cap_channel_t *chan __unused, const char *name)
This revision was not accepted when it landed; it landed in state Needs Review.Oct 13 2020, 10:50 PM
This revision was automatically updated to reflect the committed changes.