Page MenuHomeFreeBSD

[nvmecontrol] Fix type signedness warning-to-error on gcc-6.4
ClosedPublic

Authored by adrian on Oct 15 2020, 4:45 AM.
Tags
None
Referenced Files
F132440093: D26791.id79667.diff
Thu, Oct 16, 11:28 PM
Unknown Object (File)
Thu, Oct 16, 8:41 AM
Unknown Object (File)
Thu, Oct 16, 8:41 AM
Unknown Object (File)
Thu, Oct 16, 8:41 AM
Unknown Object (File)
Thu, Oct 16, 8:41 AM
Unknown Object (File)
Thu, Oct 16, 8:41 AM
Unknown Object (File)
Wed, Oct 15, 9:04 PM
Unknown Object (File)
Sun, Oct 12, 12:24 PM
Subscribers

Details

Summary

This fixes a type signedness comparison warning-to-error on
gcc-6.4. The ternary operation casts it right but the actual
assignment doesn't.

Test Plan
  • compiled on gcc-6.4 amd64

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sbin/nvmecontrol/firmware.c
180 ↗(On Diff #78247)

I think it would be better to have a new variable that's the right size rather than all the casts.

Updated to reduce casting and use better variable types

Whoops, remove another cast

adrian marked an inline comment as done.
This revision is now accepted and ready to land.Nov 16 2020, 4:42 AM