Page MenuHomeFreeBSD
Differential D26791

[nvmecontrol] Fix type signedness warning-to-error on gcc-6.4
ClosedPublic
Actions

Authored by adrian on Oct 15 2020, 4:45 AM.
Tags
None
Referenced Files
F132670928: D26791.diff
Sat, Oct 18, 10:32 PM
F132661003: D26791.id79667.diff
Sat, Oct 18, 8:35 PM
F132646944: D26791.id78247.diff
Sat, Oct 18, 5:44 PM
Unknown Object (File)
Thu, Oct 16, 11:28 PM
Unknown Object (File)
Thu, Oct 16, 8:41 AM
Unknown Object (File)
Thu, Oct 16, 8:41 AM
Unknown Object (File)
Thu, Oct 16, 8:41 AM
Unknown Object (File)
Thu, Oct 16, 8:41 AM
View All Files
Subscribers
dab
imp

Details

Reviewers
imp
Commits
rGf728bcf204ee: [nvmecontrol] Fix type signedness warning-to-error on gcc-6.4
rS367771: [nvmecontrol] Fix type signedness warning-to-error on gcc-6.4
Summary

This fixes a type signedness comparison warning-to-error on
gcc-6.4. The ternary operation casts it right but the actual
assignment doesn't.

Test Plan
  • compiled on gcc-6.4 amd64

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adrian created this revision.Oct 15 2020, 4:45 AM
Herald added subscribers: dab, imp. · View Herald TranscriptOct 15 2020, 4:45 AM
adrian requested review of this revision.Oct 15 2020, 4:45 AM
Harbormaster completed remote builds in B34178: Diff 78247.Oct 15 2020, 4:45 AM
imp added inline comments.Oct 15 2020, 9:55 AM
sbin/nvmecontrol/firmware.c
180 ↗(On Diff #78247)

I think it would be better to have a new variable that's the right size rather than all the casts.

adrian updated this revision to Diff 79517.Nov 13 2020, 6:56 PM

Updated to reduce casting and use better variable types

Harbormaster completed remote builds in B34784: Diff 79517.Nov 13 2020, 6:56 PM
adrian updated this revision to Diff 79518.Nov 13 2020, 6:59 PM

Whoops, remove another cast

Harbormaster completed remote builds in B34785: Diff 79518.Nov 13 2020, 6:59 PM
adrian added a reviewer: imp.Nov 16 2020, 2:44 AM
adrian marked an inline comment as done.
imp accepted this revision.Nov 16 2020, 4:42 AM
This revision is now accepted and ready to land.Nov 16 2020, 4:42 AM
Closed by commit rS367771: [nvmecontrol] Fix type signedness warning-to-error on gcc-6.4 (authored by adrian). · Explain WhyNov 17 2020, 5:13 PM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rS367771: [nvmecontrol] Fix type signedness warning-to-error on gcc-6.4.
rlibby added a commit: rGf728bcf204ee: [nvmecontrol] Fix type signedness warning-to-error on gcc-6.4.Dec 29 2020, 11:07 PM

Revision Contents
Changeset List

PathSize
head/
sbin/
nvmecontrol/
8 lines

Diff 79667

View Options

head/sbin/nvmecontrol/firmware.c

Loading...