Page MenuHomeFreeBSD
Differential D26846

[zfs] don't include a non-existent include directory
ClosedPublic
Actions

Authored by adrian on Oct 18 2020, 9:38 PM.
Tags
None
Referenced Files
F166369015: D26846.diff
Thu, Aug 13, 4:59 AM
Unknown Object (File)
Wed, Aug 12, 2:16 PM
Unknown Object (File)
Wed, Aug 12, 12:53 PM
Unknown Object (File)
Tue, Aug 11, 11:47 PM
Unknown Object (File)
Tue, Aug 11, 11:47 PM
Unknown Object (File)
Tue, Aug 11, 6:19 PM
Unknown Object (File)
Tue, Aug 11, 4:04 PM
Unknown Object (File)
Mon, Aug 10, 1:16 AM
View All Files
Subscribers
imp

Details

Reviewers
kevans
imp
Commits
rS366818: [zfs] Remove a non-existent directory in the build infra
Summary

This subdir doesn't exist and it's tripping up our gcc build.

Test Plan
  • build with gcc-6.4 and llvm11 for amd64

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adrian created this revision.Oct 18 2020, 9:38 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 18 2020, 9:38 PM
adrian requested review of this revision.Oct 18 2020, 9:38 PM
Harbormaster completed remote builds in B34247: Diff 78399.Oct 18 2020, 9:38 PM
adrian added reviewers: kevans, imp.Oct 18 2020, 9:39 PM
imp accepted this revision.Oct 18 2020, 9:42 PM

seems legit. There's no includes/spl and module/spl has no .h files in it

This revision is now accepted and ready to land.Oct 18 2020, 9:42 PM
kevans accepted this revision.Oct 18 2020, 9:59 PM

I've got an upstream PR for this to do the equivalent with the upstream makefile. mmacy has not answered my pending question there if that's used at all to provision our build bits, so I guess go for it.

Closed by commit rS366818: [zfs] Remove a non-existent directory in the build infra (authored by adrian). · Explain WhyOct 18 2020, 10:38 PM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rS366818: [zfs] Remove a non-existent directory in the build infra.

Revision Contents
Changeset List

PathSize
head/
sys/
conf/
1 line

Diff 78400

View Options

head/sys/conf/kmod.mk

Loading...