Page MenuHomeFreeBSD

fix compiler warnings-as-errors on gcc6 in rcorder/crunchgen
ClosedPublic

Authored by adrian on Sep 21 2020, 6:33 AM.

Details

Summary

/usr/home/adrian/work/freebsd/head-embedded/src/sbin/rcorder/rcorder.c: In function 'generate_graphviz_header':
/usr/home/adrian/work/freebsd/head-embedded/src/sbin/rcorder/rcorder.c:993:1: error: old-style function definition [-Werror=old-style-definition]
generate_graphviz_header()
^~~~~~~~~~~~~~~~~~~~~~~~

Test Plan

Compiled using gcc-mips 6.4.0.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ignore the pmc related bits, it's not relevant for this fix

Non pmc bits look good to go

usr.sbin/Makefile
189 ↗(On Diff #77279)

N

This revision is now accepted and ready to land.Sep 21 2020, 6:46 AM

pmc parts were changed in rS334749 when libpmc added a C++ file but this shouldn't be necessary

LGTM except the usr.sbin/Makefile change