Differential D26504

fix compiler warnings-as-errors on gcc6 in rcorder/crunchgen
ClosedPublic
Actions

Authored by adrian on Sep 21 2020, 6:33 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Oct 12, 4:49 PM

	Unknown Object (File)
	Sun, Oct 12, 4:49 PM

	Unknown Object (File)
	Sun, Oct 12, 4:49 PM

	Unknown Object (File)
	Sun, Oct 12, 8:38 AM

	Unknown Object (File)
	Sun, Oct 12, 5:16 AM

	Unknown Object (File)
	Tue, Sep 30, 12:54 AM

	Unknown Object (File)
	Sun, Sep 21, 1:31 PM

	Unknown Object (File)
	Fri, Sep 19, 12:45 PM

Subscribers

Details

Reviewers

imp
kevans
emaste

Commits

rS365957: [rcorder] [crunch] Fix C function declarations to include void

Summary

/usr/home/adrian/work/freebsd/head-embedded/src/sbin/rcorder/rcorder.c: In function 'generate_graphviz_header':
/usr/home/adrian/work/freebsd/head-embedded/src/sbin/rcorder/rcorder.c:993:1: error: old-style function definition [-Werror=old-style-definition]
generate_graphviz_header()
^~~~~~~~~~~~~~~~~~~~~~~~

Test Plan

Compiled using gcc-mips 6.4.0.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Sep 21 2020, 6:33 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 21 2020, 6:33 AM

adrian requested review of this revision.Sep 21 2020, 6:33 AM

Harbormaster completed remote builds in B33685: Diff 77279.Sep 21 2020, 6:33 AM

ignore the pmc related bits, it's not relevant for this fix

Non pmc bits look good to go

usr.sbin/Makefile
189 ↗	(On Diff #77279)	N

This revision is now accepted and ready to land.Sep 21 2020, 6:46 AM

kevans accepted this revision.Sep 21 2020, 1:07 PM

pmc parts were changed in rS334749 when libpmc added a C++ file but this shouldn't be necessary

LGTM except the usr.sbin/Makefile change

emaste accepted this revision.Sep 21 2020, 1:56 PM

Closed by commit rS365957: [rcorder] [crunch] Fix C function declarations to include void (authored by adrian). · Explain WhySep 21 2020, 6:00 PM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rS365957: [rcorder] [crunch] Fix C function declarations to include void.

Revision Contents
Changeset List

Path

Size

head/

sbin/

rcorder/

6 lines

usr.sbin/

crunch/

crunchgen/

crunched_main.c

2 lines

Diff 77311

head/sbin/rcorder/rcorder.c

Loading...

head/usr.sbin/crunch/crunchgen/crunched_main.c

Loading...