Page MenuHomeFreeBSD

[posixshm_test] Fix unused variable errors and unsigned check errors on gcc-6.4
Needs ReviewPublic

Authored by adrian on Oct 15 2020, 4:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 26 2023, 7:34 AM
Unknown Object (File)
Dec 23 2023, 2:30 AM
Unknown Object (File)
Dec 19 2023, 6:09 PM
Unknown Object (File)
Sep 11 2023, 7:06 PM
Unknown Object (File)
Jul 31 2023, 9:59 PM
Unknown Object (File)
Apr 26 2023, 3:59 AM
Unknown Object (File)
Apr 8 2023, 10:25 AM
Subscribers
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary
  • Quieten an unused variable error
  • comment out two assertions that are always true (because they're uint64_t's) ; gcc-6.4 errors out saying the condition is always true
Test Plan
  • compiled on gcc-6.4 amd64

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34180
Build 31333: arc lint + arc unit

Event Timeline

adrian retitled this revision from [posixshm_test] add missing void in function decl to [posixshm_test] Fix unused variable errors and unsigned check errors on gcc-6.4.Oct 15 2020, 4:52 AM
adrian edited the summary of this revision. (Show Details)
tests/sys/posixshm/posixshm_test.c
1008

stray lank line.

1060

just remove the variable. This is bogus.

1332

You should either remove it entirely or find why it was there in the first place. Looks bogus. Better to just kill it if it really is bogus than to enshrine this long thing. More likely, the range should be different.