Page MenuHomeFreeBSD

[iscsictl] Fix compiler issues on gcc-6.4
ClosedPublic

Authored by adrian on Nov 1 2020, 2:31 AM.
Tags
None
Referenced Files
F133091254: D27036.id79026.diff
Wed, Oct 22, 9:45 PM
F133053661: D27036.id79035.diff
Wed, Oct 22, 12:28 PM
F133053655: D27036.id.diff
Wed, Oct 22, 12:28 PM
F133053654: D27036.id79025.diff
Wed, Oct 22, 12:28 PM
Unknown Object (File)
Tue, Oct 21, 11:37 PM
Unknown Object (File)
Sun, Oct 12, 3:03 PM
Unknown Object (File)
Sat, Sep 27, 7:43 AM
Unknown Object (File)
Sep 15 2025, 10:03 AM
Subscribers

Details

Summary

This fixes two compiler warnings-that-are-errors:

  • don't compare a uint64_t to be >= 0; it will always be that
  • don't double-define yylex(); the definition for it is provided in a library header file.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adrian requested review of this revision.Nov 1 2020, 2:31 AM

hi! please lemme know what you think!

usr.bin/iscsictl/parse.y
362 ↗(On Diff #79025)

That doesn't look right at all now. What is it testing?

This revision is now accepted and ready to land.Nov 1 2020, 3:45 AM