[iscsictl] Fix compiler issues on gcc-6.4
ClosedPublic
Actions

Authored by adrian on Nov 1 2020, 2:31 AM.

Details

Reviewers

imp
trasz
rscheff

Commits

rS367248: [iscsictl] Fix compile issues that creep up with gcc-6.4

Summary

This fixes two compiler warnings-that-are-errors:

don't compare a uint64_t to be >= 0; it will always be that
don't double-define yylex(); the definition for it is provided in a library header file.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Nov 1 2020, 2:31 AM

Herald added a subscriber: imp. · View Herald TranscriptNov 1 2020, 2:31 AM

adrian requested review of this revision.Nov 1 2020, 2:31 AM

Harbormaster completed remote builds in B34540: Diff 79025.Nov 1 2020, 2:31 AM

hi! please lemme know what you think!

imp added inline comments.Nov 1 2020, 2:49 AM

usr.bin/iscsictl/parse.y
362 ↗	(On Diff #79025)	That doesn't look right at all now. What is it testing?

whoops brb

Fix!

Harbormaster completed remote builds in B34541: Diff 79026.Nov 1 2020, 3:45 AM

adrian marked an inline comment as done.Nov 1 2020, 3:45 AM

imp accepted this revision.Nov 1 2020, 3:45 AM

This revision is now accepted and ready to land.Nov 1 2020, 3:45 AM

Looks good;

Closed by commit rS367248: [iscsictl] Fix compile issues that creep up with gcc-6.4 (authored by adrian). · Explain WhyNov 1 2020, 3:57 PM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rS367248: [iscsictl] Fix compile issues that creep up with gcc-6.4.

Revision Contents
Changeset List

Path

Size

head/

usr.bin/

iscsictl/

parse.y

3 lines

Diff 79035

View Options

head/usr.bin/iscsictl/parse.y

[iscsictl] Fix compiler issues on gcc-6.4ClosedPublicActions