Page MenuHomeFreeBSD

[gnuregex] Fix size demotion rounding errors that have crept up with later gcc
ClosedPublic

Authored by adrian on Oct 15 2020, 8:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 13, 4:44 AM
Unknown Object (File)
Thu, May 7, 12:55 AM
Unknown Object (File)
Wed, May 6, 12:39 AM
Unknown Object (File)
Thu, Apr 30, 3:53 PM
Unknown Object (File)
Sun, Apr 26, 7:08 PM
Unknown Object (File)
Sun, Apr 26, 10:15 AM
Unknown Object (File)
Apr 18 2026, 1:33 AM
Unknown Object (File)
Apr 15 2026, 8:33 PM
Subscribers

Details

Summary

This fixes some fun type size truncation that shows up giving errors like
" changes value from '287948901175001088' to '0' "

.. which turns out is a known issue with later gcc's.

eg - https://lists.gnu.org/archive/html/bug-gnulib/2012-03/msg00154.html

It was fixed up upstream corelib/gnulib in commit hahs
252b52457da7887667c036d18cc5169777615bb0
(eg in https://github.com/coreutils/gnulib/commit/252b52457da7887667c036d18cc5169777615bb0)

Test Plan
  • compiled/run for gcc-6.4 on amd64

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  1. Updating D26804: [gnuregex] Fix size demotion rounding errors that have crept up with later gcc #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

whoops, didn't include the diff

This revision is now accepted and ready to land.Oct 15 2020, 8:14 PM