Page MenuHomeFreeBSD

[gnuregex] Fix size demotion rounding errors that have crept up with later gcc
ClosedPublic

Authored by adrian on Oct 15 2020, 8:00 PM.
Tags
None
Referenced Files
F83276212: D26804.diff
Wed, May 8, 8:00 AM
Unknown Object (File)
Thu, Apr 11, 6:58 PM
Unknown Object (File)
Thu, Apr 11, 6:58 PM
Unknown Object (File)
Thu, Apr 11, 6:58 PM
Unknown Object (File)
Jan 16 2024, 6:49 AM
Unknown Object (File)
Dec 29 2023, 11:58 PM
Unknown Object (File)
Dec 23 2023, 1:02 AM
Unknown Object (File)
Nov 14 2023, 11:54 PM
Subscribers

Details

Summary

This fixes some fun type size truncation that shows up giving errors like
" changes value from '287948901175001088' to '0' "

.. which turns out is a known issue with later gcc's.

eg - https://lists.gnu.org/archive/html/bug-gnulib/2012-03/msg00154.html

It was fixed up upstream corelib/gnulib in commit hahs
252b52457da7887667c036d18cc5169777615bb0
(eg in https://github.com/coreutils/gnulib/commit/252b52457da7887667c036d18cc5169777615bb0)

Test Plan
  • compiled/run for gcc-6.4 on amd64

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 34196
Build 31347: arc lint + arc unit

Event Timeline

  1. Updating D26804: [gnuregex] Fix size demotion rounding errors that have crept up with later gcc #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

whoops, didn't include the diff

This revision is now accepted and ready to land.Oct 15 2020, 8:14 PM