Page MenuHomeFreeBSD
Differential D26804

[gnuregex] Fix size demotion rounding errors that have crept up with later gcc
ClosedPublic
Actions

Authored by adrian on Oct 15 2020, 8:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 4, 12:35 AM
Unknown Object (File)
Mon, Dec 2, 12:12 AM
Unknown Object (File)
Sun, Dec 1, 3:28 AM
Unknown Object (File)
Mon, Nov 25, 7:12 PM
Unknown Object (File)
Mon, Nov 25, 6:27 AM
Unknown Object (File)
Sun, Nov 24, 1:34 PM
Unknown Object (File)
Sun, Nov 24, 10:03 AM
Unknown Object (File)
Nov 23 2024, 2:23 PM
View All Files
Subscribers
imp

Details

Reviewers
imp
Commits
rS366765: This fixes some fun type size truncation that shows up giving errors like
Summary

This fixes some fun type size truncation that shows up giving errors like
" changes value from '287948901175001088' to '0' "

.. which turns out is a known issue with later gcc's.

eg - https://lists.gnu.org/archive/html/bug-gnulib/2012-03/msg00154.html

It was fixed up upstream corelib/gnulib in commit hahs
252b52457da7887667c036d18cc5169777615bb0
(eg in https://github.com/coreutils/gnulib/commit/252b52457da7887667c036d18cc5169777615bb0)

Test Plan
  • compiled/run for gcc-6.4 on amd64

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adrian created this revision.Oct 15 2020, 8:00 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 15 2020, 8:00 PM
adrian requested review of this revision.Oct 15 2020, 8:00 PM
Harbormaster completed remote builds in B34196: Diff 78282.Oct 15 2020, 8:00 PM
adrian updated this revision to Diff 78284.Oct 15 2020, 8:06 PM
  1. Updating D26804: [gnuregex] Fix size demotion rounding errors that have crept up with later gcc #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.

whoops, didn't include the diff

Harbormaster completed remote builds in B34198: Diff 78284.Oct 15 2020, 8:06 PM
imp accepted this revision.Oct 15 2020, 8:14 PM

seems legit

This revision is now accepted and ready to land.Oct 15 2020, 8:14 PM
Closed by commit rS366765: This fixes some fun type size truncation that shows up giving errors like (authored by adrian). · Explain WhyOct 16 2020, 2:28 PM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rS366765: This fixes some fun type size truncation that shows up giving errors like.

Revision Contents
Changeset List

PathSize
head/
contrib/
libgnuregex/
31 lines

Diff 78316

View Options

head/contrib/libgnuregex/regcomp.c

Loading...