Page MenuHomeFreeBSD
Differential D27608

[contrib/bc] Only use fallthrough on GCC's that support it
Needs ReviewPublic
Actions

Authored by adrian on Dec 14 2020, 4:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 8:03 AM
Unknown Object (File)
Dec 19 2023, 5:38 PM
Unknown Object (File)
Apr 8 2023, 10:31 AM
Unknown Object (File)
Mar 22 2023, 7:49 AM
Unknown Object (File)
Dec 14 2022, 6:06 PM
Unknown Object (File)
Dec 9 2022, 9:21 PM
Subscribers
imp
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

attribute(fallthrough) only showed up in gcc-7. gcc-6 treats
it as an empty attribute and errors out.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 35398
Build 32315: arc lint + arc unit

Event Timeline

adrian created this revision.Dec 14 2020, 4:50 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 14 2020, 4:50 PM
adrian requested review of this revision.Dec 14 2020, 4:50 PM
Harbormaster completed remote builds in B35398: Diff 80693.Dec 14 2020, 4:51 PM
imp added a comment.Dec 14 2020, 7:24 PM

Can you get this accepted upstream?

adrian added a comment.Dec 14 2020, 8:09 PM
In D27608#616994, @imp wrote:

Can you get this accepted upstream?

I've poked gavin@ to see if he's the right upstream and whether this is his. :-P

Revision Contents
Changeset List

PathSize
contrib/
bc/
include/
2 lines

Diff 80693

View Options

contrib/bc/include/status.h

Loading...