Provide MS() and SM() macros for 80211.
ClosedPublic
Actions

Authored by bz on Sep 23 2020, 10:02 PM.

Details

Reviewers

adrian
gnn

Commits

rS366112: Provide MS() and SM() macros for 80211 and wireless drivers.

Summary

We have (two versions) of MS() and SM() macros which we use throughout
the wireless code. Change all but three places (ath_hal, rtwn, and rsu)
to the newly provided _IEEE80211_MASKSHIFT() and _IEEE80211_SHIFTMASK()
macros. Also change one internal case using both _S and _M instead of
just _S away from _M (leave others, such as rsu).

This has been done semi-mechanically. No functional changes intended.
TODO: improve line-wrapping after this change before commit, if the
new macro names are generally acceptable.

Requested by:	gnn (D26091)
Sponsored by:   Rubicon Communications, LLC (d/b/a "Netgate")

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33784
Build 31001: arc lint + arc unit

Event Timeline

bz created this revision.Sep 23 2020, 10:02 PM

Herald added a subscriber: melifaro. · View Herald TranscriptSep 23 2020, 10:02 PM

Harbormaster completed remote builds in B33784: Diff 77461.Sep 23 2020, 10:02 PM

bz requested review of this revision.Sep 23 2020, 10:02 PM

bz edited the summary of this revision. (Show Details)Sep 23 2020, 10:07 PM

bz set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptSep 23 2020, 10:07 PM

I am mostly interested if the names are okay. I did not want to use _IEEE80211_MS() as that might be confused with some time operation MS_TO_xxx. If the names are okay, I'll wrap the lines and upload a new version for actual review.

adrian accepted this revision.Sep 24 2020, 3:01 AM

This revision is now accepted and ready to land.Sep 24 2020, 3:01 AM

Arg. Sorry, used the wrong alias and pushed the change into head instead of here. Please do a post-commit review in head then.

This landed by accident in head as https://svnweb.freebsd.org/changeset/base/366112 (not sure why the review wasn't automatically closed either).

bz added a commit: rS366112: Provide MS() and SM() macros for 80211 and wireless drivers..Nov 1 2020, 11:44 AM