Page MenuHomeFreeBSD

[llvm] Use 32 bit atomic on freebsd mips
ClosedPublic

Authored by adrian on Oct 13 2020, 10:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 4, 4:18 PM
Unknown Object (File)
Tue, Sep 23, 9:05 AM
Unknown Object (File)
Sun, Sep 21, 10:22 AM
Unknown Object (File)
Fri, Sep 19, 11:53 PM
Unknown Object (File)
Sat, Sep 13, 2:49 AM
Unknown Object (File)
Aug 10 2025, 2:30 AM
Unknown Object (File)
Jul 31 2025, 4:06 PM
Unknown Object (File)
Jul 12 2025, 10:59 AM
Subscribers

Details

Summary

gcc for mips32 doesn't include libatomic and doesn't generate
atomic sequences; so this just fails to link.

Instead, just use 32 bit for mips32/mips64.

(I haven't found a nice way to detect 32 or 64 bit mips here
without other header pollution, but it should be fine for freebsd/mips.)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I think this is fine for now. Upstream will want to centralize the define somewhere in __config, but we can take that discussion there.

This revision is now accepted and ready to land.Oct 16 2020, 6:58 PM