Differential D59911

misc: Avoid use of Unicode closing single quote
ClosedPublic
Actions

Authored by des on Tue, Sep 22, 5:03 PM.

Tags

None

Referenced Files

	F175328505: D59911.diff
	Sat, Oct 10, 12:37 AM

	Unknown Object (File)
	Wed, Oct 7, 8:51 PM

	Unknown Object (File)
	Tue, Oct 6, 7:29 AM

	Unknown Object (File)
	Tue, Oct 6, 1:09 AM

	Unknown Object (File)
	Sat, Oct 3, 10:46 AM

	Unknown Object (File)
	Sat, Oct 3, 4:52 AM

	Unknown Object (File)
	Fri, Oct 2, 12:35 PM

	Unknown Object (File)
	Fri, Oct 2, 11:22 AM

View All 29 Files

Subscribers

View All 9 Subscribers

Details

Reviewers

andrew
gnn
obiwac
ziaee
olce

Group Reviewers

Klara
srcmgr
bhyve

Commits

rG7399be2030f5: misc: Avoid use of Unicode closing single quote

Summary

The Unicode closing single quotation mark is classified as a homoglyph
and can trip automated code quality checks in downstream CI pipelines or
cause code review UIs to refuse to display a file. If used as an
apostrophe, use the ASCII single quote instead. If used as a closing
single quote, replace with double quotes or no quotes at all.

Sponsored by: Klara, Inc.
Sponsored by: NetApp, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77192
Build 74075: arc lint + arc unit

Event Timeline

des created this revision.Tue, Sep 22, 5:03 PM

Herald added a reviewer: andrew. · View Herald TranscriptTue, Sep 22, 5:03 PM

Herald added a reviewer: gnn. · View Herald Transcript

Herald added a reviewer: bhyve. · View Herald Transcript

Herald added subscribers: ziaee, glebius, dab and 5 others. · View Herald Transcript

des requested review of this revision.Tue, Sep 22, 5:03 PM

Herald added a subscriber: dsl. · View Herald TranscriptTue, Sep 22, 5:03 PM

Harbormaster completed remote builds in B77192: Diff 187456.Tue, Sep 22, 5:03 PM

obiwac accepted this revision.Tue, Sep 22, 5:07 PM

This revision is now accepted and ready to land.Tue, Sep 22, 5:07 PM

Thank you!

olce accepted this revision as: olce.Wed, Sep 23, 10:37 AM

des closed this revision.Wed, Sep 23, 4:35 PM

des added a commit: rG7399be2030f5: misc: Avoid use of Unicode closing single quote.

Revision Contents
Changeset List

Path

Size

2 lines

sbin/

nvmecontrol/

4 lines

sys/

arm/

annapurna/

alpine/

alpine_pci_msix.c

2 lines

cddl/

dev/

dtrace/

x86/

2 lines

dev/

atkbdc/

2 lines

dpaa2/

2 lines

hid/

2 lines

oce/

4 lines

smartpqi/

smartpqi_init.c

2 lines

virtio/

mmio/

2 lines

net/

2 lines

14 lines

x86/

x86/

2 lines

6 lines

usr.sbin/

bhyve/

2 lines

moused/

moused/

2 lines

Diff 187456

UPDATING

Loading...

sbin/nvmecontrol/nvmecontrol.8

Loading...

sys/arm/annapurna/alpine/alpine_pci_msix.c

Loading...

sys/cddl/dev/dtrace/x86/dis_tables.c

Loading...

sys/dev/atkbdc/psm.c

Loading...

sys/dev/dpaa2/dpaa2_io.c

Loading...

sys/dev/hid/hidmap.c

Loading...

sys/dev/oce/oce_hw.h

Loading...

sys/dev/smartpqi/smartpqi_init.c

Loading...

sys/dev/virtio/mmio/virtio_mmio.c

Loading...

sys/net/sff8436.h

Loading...

sys/net/sff8472.h

Loading...

sys/x86/x86/identcpu.c

Loading...

sys/x86/x86/mp_x86.c

Loading...

usr.sbin/bhyve/bhyve.8

Loading...

usr.sbin/moused/moused/moused.conf.5

Loading...