Differential D48979

flash: add w25n (nand flash) support
ClosedPublic
Actions

Authored by adrian on Feb 13 2025, 12:44 AM.

Details

Reviewers

imp

Commits

rG89e3c2d27ab4: flash: add w25n (nand flash) support

Summary

This adds read only support for the W25N series of flash parts.

Specifically starting with the W25N01GV, a 128MiB SPI NAND flash.

This doesn't currently support writing or erasing, as this requires
a NAND flash layer that we don't currently have. There are also
plenty of other commands that aren't currently supported - notably
maintaining the on-chip flash translation layer, flash wear statistics,
etc.

But read support is fine enough for now; it at least allows for
reading the boot / config / calibration flash on my ASUS IPQ4018 based
router.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62410
Build 59294: arc lint + arc unit

Event Timeline

adrian created this revision.Feb 13 2025, 12:44 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 13 2025, 12:44 AM

adrian requested review of this revision.Feb 13 2025, 12:44 AM

Harbormaster completed remote builds in B62410: Diff 150937.Feb 13 2025, 12:44 AM

adrian added a reviewer: imp.Feb 13 2025, 12:44 AM

OK. This is fine.

But... the commands are likely part of a larger family of parts...

But this also looks pretty basic, so it's fine. There's no larger framework for NAND like we need to do this completely... but that's a huge lift and I don't want to hold this up.

I don't see anything here that's bad for 'basic' support that this targets.

This revision is now accepted and ready to land.Feb 14 2025, 11:49 PM

Closed by commit rG89e3c2d27ab4: flash: add w25n (nand flash) support (authored by adrian). · Explain WhyFeb 15 2025, 3:05 AM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG89e3c2d27ab4: flash: add w25n (nand flash) support.