Page MenuHomeFreeBSD
Differential D31131

libkern: import strnstr from libc
ClosedPublic
Actions

Authored by val_packett.cool on Jul 10 2021, 11:32 AM.
Tags
Referenced Files
Unknown Object (File)
Tue, Feb 17, 7:19 AM
Unknown Object (File)
Sun, Feb 8, 3:04 AM
Unknown Object (File)
Sat, Feb 7, 6:09 PM
Unknown Object (File)
Tue, Feb 3, 11:17 AM
Unknown Object (File)
Sat, Jan 31, 11:53 AM
Unknown Object (File)
Sat, Jan 31, 1:34 AM
Unknown Object (File)
Thu, Jan 29, 7:35 PM
Unknown Object (File)
Tue, Jan 27, 1:01 PM
View All Files
Subscribers
bz
imp
nc
Contributor Reviews (src)

Details

Reviewers
• hselasky
cem
bz
nc
Group Reviewers
Contributor Reviews (src)
Commits
rG74ff46ac1724: Add missing libkern/strnstr.c file
rG7accb4a33579: libkern: import strnstr from libc
rG4211457e40e0: Add missing libkern/strnstr.c file
rGf39d9c913185: libkern: import strnstr from libc
Summary

Required for drm-kmod (amdgpu).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

val_packett.cool created this revision.Jul 10 2021, 11:32 AM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptJul 10 2021, 11:32 AM
val_packett.cool requested review of this revision.Jul 10 2021, 11:32 AM
Harbormaster completed remote builds in B40429: Diff 92041.Jul 10 2021, 11:32 AM
val_packett.cool added reviewers: Contributor Reviews (src), linuxkpi.Jul 10 2021, 11:35 AM
val_packett.cool changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
val_packett.cool edited reviewers, added: • hselasky, cem; removed: linuxkpi.Jul 10 2021, 4:01 PM
val_packett.cool added a project: linuxkpi.
val_packett.cool added a subscriber: nc.
• hselasky accepted this revision.Jul 10 2021, 4:53 PM
This revision is now accepted and ready to land.Jul 10 2021, 4:53 PM
bz accepted this revision.Jul 10 2021, 4:55 PM
bz added a subscriber: bz.

I had to do this last year at some point for a local tree. Seems good.

sys/libkern/strnstr.c
36 ↗(On Diff #92041)

You might as well leave the __FBSDID("$FreeBSD$"); in the copy of the file.
Otherwise remove the extra line maybe as well?

nc accepted this revision.Jul 15 2021, 12:55 AM

Sorry for the delay. It looks good to me also.

Closed by commit rGf39d9c913185: libkern: import strnstr from libc (authored by val_packett.cool, committed by nc). · Explain WhyJul 15 2021, 12:56 AM
This revision was automatically updated to reflect the committed changes.
nc added a commit: rGf39d9c913185: libkern: import strnstr from libc.
nc added a commit: rG4211457e40e0: Add missing libkern/strnstr.c file.
nc added a commit: rG7accb4a33579: libkern: import strnstr from libc.Jul 18 2021, 1:09 AM
nc added a commit: rG74ff46ac1724: Add missing libkern/strnstr.c file.

Revision Contents
Changeset List

PathSize
sys/
conf/
1 line
sys/
1 line

Diff 92208

View Options

sys/conf/files

Loading...
View Options

sys/sys/libkern.h

Loading...