libkern: import strnstr from libc
ClosedPublic
Actions

Authored by val_packett.cool on Jul 10 2021, 11:32 AM.

Details

Reviewers

• hselasky
cem
bz
nc

Group Reviewers

Contributor Reviews (src)

Commits

rG74ff46ac1724: Add missing libkern/strnstr.c file
rG7accb4a33579: libkern: import strnstr from libc
rG4211457e40e0: Add missing libkern/strnstr.c file
rGf39d9c913185: libkern: import strnstr from libc

Summary

Required for drm-kmod (amdgpu).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

val_packett.cool created this revision.Jul 10 2021, 11:32 AM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptJul 10 2021, 11:32 AM

val_packett.cool requested review of this revision.Jul 10 2021, 11:32 AM

Harbormaster completed remote builds in B40429: Diff 92041.Jul 10 2021, 11:32 AM

val_packett.cool added reviewers: Contributor Reviews (src), linuxkpi.Jul 10 2021, 11:35 AM

val_packett.cool changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.

val_packett.cool edited reviewers, added: • hselasky, cem; removed: linuxkpi.Jul 10 2021, 4:01 PM

val_packett.cool added a project: linuxkpi.

val_packett.cool added a subscriber: nc.

• hselasky accepted this revision.Jul 10 2021, 4:53 PM

This revision is now accepted and ready to land.Jul 10 2021, 4:53 PM

I had to do this last year at some point for a local tree. Seems good.

sys/libkern/strnstr.c
36 ↗	(On Diff #92041)	You might as well leave the __FBSDID("$FreeBSD$"); in the copy of the file. Otherwise remove the extra line maybe as well?

Sorry for the delay. It looks good to me also.

Closed by commit rGf39d9c913185: libkern: import strnstr from libc (authored by val_packett.cool, committed by nc). · Explain WhyJul 15 2021, 12:56 AM

This revision was automatically updated to reflect the committed changes.

nc added a commit: rGf39d9c913185: libkern: import strnstr from libc.

nc added a commit: rG4211457e40e0: Add missing libkern/strnstr.c file.

nc added a commit: rG7accb4a33579: libkern: import strnstr from libc.Jul 18 2021, 1:09 AM

nc added a commit: rG74ff46ac1724: Add missing libkern/strnstr.c file.

Revision Contents
Changeset List

Path

Size

sys/

conf/

files

1 line

sys/

libkern.h

1 line

Diff 92208

View Options

sys/conf/files