LGTM

In D47472#1082752, @kevans wrote:

In D47472#1082711, @jkim wrote:

Although Hangul Jamo charaters occupy space, it seems many implementations use zero-width nowadays, including GNU libc.

https://sourceware.org/bugzilla/show_bug.cgi?id=19852
https://github.com/ridiculousfish/widecharwidth/issues/16

I agree that we should follow other implementations.

However, all fillers must occupy proper spaces, i.e., <HANGUL_CHOSEONG_FILLER> => 2, <HANGUL_JUNGSEONG_FILLER> => 0, and <HALFWIDTH_HANGUL_FILLER> => 1.

Ah, ok, thanks for confirming that- so if I just drop the ignorable check, the fillers return to their previous value with exception to <HANGUL_JUNGSEONG_FILLER> since it falls in the Hangul Kamo range that we're forcing to zero-width. That looks right based on what you've written, since omitted values default to 1.

Although Hangul Jamo charaters occupy space, it seems many implementations use zero-width nowadays, including GNU libc.

LGTM

LGTM

LGTM

FYI, the fix was incomplete. I fixed remaining ones in 7270b8992214.

LGTM

In D38835#884575, @ngie wrote:

I followed a different import process than what’s described in FreeBSD-UPGRADE because it was much simpler for me to use rsync -av —-delete to update the contents than multiple calls to find/tar/comm.

LGTM

In D36868#836880, @kib wrote:

Please, upload patches with context. git show -U 9999999 or git diff -U 999999999

In D36868#836858, @hselasky wrote:

I think you should use "1000000000ULL" to always get unsigned results, but I'm not an expert. Else code looks good.

LGTM