Approved By: allanjude
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jul 31 2019
Jul 18 2019
Jul 16 2019
Approved By: allanjude (mentor)
Jul 11 2019
Jul 1 2019
Jun 29 2019
Jun 28 2019
Jun 25 2019
This makes sense. It is not clear how many upstream projects will adopt this license, so this seem like the right first step.
Jun 20 2019
Jun 19 2019
Jun 14 2019
Jun 9 2019
I might reverse the order of these, since loading the module is the recommended action, and compiling it into your kernel is for people who want to do custom kernels.
Jun 7 2019
In D20477#443980, @cem wrote:So like, what's the motivation of this change? What are the goals? How was this design chosen? There's 6000 lines of diff present as a fait accompli without any kind of socialization on arch@ or anywhere else. Code is great, but the high level stuff is missing.
Comment density is "low" and copy-paste density is "high." Did you consider templating this, either with awk or C++?
"stats(3)" is a bit misleading; 3900 LoC are a new kernel file. What is the expected consumer? What is the general API surface? Where is the design doc?
Where is the stats(9) manual page? What do stats(3) consumers look like? Will there ever be any in tree? Can this live in ports?
Jun 6 2019
Jun 5 2019
Jun 4 2019
Jun 2 2019
Approved By: allanjude (mentor)
May 31 2019
May 29 2019
May 26 2019
@rgrimes If you want to commandeer this review and put an updated diff, that would be great.
May 23 2019
This is a nice cleanup, thank you.
May 21 2019
May 18 2019
May 16 2019
Apr 27 2019
Send it
Approved
Remove the duplicated event (Pedro Giffuni commit bit enhanced)
Apr 19 2019
Apr 10 2019
Apr 2 2019
Mar 28 2019
Mar 25 2019
The description does not seem to match what the code does now.
Mar 24 2019
Need to add opt_tmpfs.h to the tmpfs kernel module Makefile
Mar 23 2019
In D19686#421604, @delphij wrote:Why is the partition index changed from 1 to 2? (The change looks otherwise fine to me).
Mar 6 2019
Sorry to arrive so late to this review.
Mar 5 2019
Feb 25 2019
I'd also like to see someone else's opinion on making whitespace changes.
Feb 17 2019
Feb 16 2019
Seems like a good fix, and even an optimization.
Feb 13 2019
Focus on non-developers
Thanks for doing the cleanup and adding the ascii-art diagram, that is very helpful.
Feb 12 2019
Feb 7 2019
There should be a better way to get a list of the disks from the pool with the zpool command, but there currently isn't
Feb 1 2019
Thank you.
Jan 15 2019
Jan 13 2019
As a general comment, since IPFW can be loaded as a kernel module now, I'd make that the recommended configuration at the start of the file, and include the 'how to compile a kernel with ipfw in it' at the bottom of the chapter, so as not to send new users off into more complicated configurations for no reason.
Jan 12 2019
Jan 4 2019
Jan 2 2019
Thank you for working on this
Dec 24 2018
Dec 23 2018
Dec 19 2018
Dec 14 2018
Dec 11 2018
Should you remove netdate.c entirely? and remove the prototype from date/extern.h ?
Dec 10 2018
In D18494#394133, @avg wrote:Unfortunately, I disagree with this change. I think that it is backwards.
illumos has already translated their zfs.1m and zpool.1m to mdoc format, so I assume that that's the direction they are moving in.
I'd rather help them with that in this case as well.
IMO, that would be a better way to overcome the divergence.
Nov 20 2018
Confirmed that this fixes my mlx4en(4) not attaching