Page MenuHomeFreeBSD

Update message displaying during `zpool upgrade`
Needs ReviewPublic

Authored by allanjude on Mar 23 2019, 6:13 AM.

Details

Reviewers
trasz
bcr
Group Reviewers
ZFS
Summary

Many users are running the default command that installs the BIOS bootcode overtop of their EFI ESP partition and getting an unbootable system.

Diff Detail

Repository
rS FreeBSD src repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23260
Build 22297: arc lint + arc unit

Event Timeline

allanjude created this revision.Mar 23 2019, 6:13 AM

Why is the partition index changed from 1 to 2? (The change looks otherwise fine to me).

Why is the partition index changed from 1 to 2? (The change looks otherwise fine to me).

bsdinstall since April 2016 has created both an EFI and BIOS boot partition by default, so the freebsd-boot partition is index 2 on most people's machines.

bcr added a comment.Mar 24 2019, 7:16 AM

A few minor suggestions to be more precise.

cddl/contrib/opensolaris/cmd/zpool/zpool_main.c
5859

I'd use a colon at the end of the sentence.

5863

Same here for the EFI instructions.

5866

No sentence stop (or even an exclamation mark) here?

cddl/contrib/opensolaris/lib/libzfs/common/libzfs_pool.c
2886

I think you need to mention "gpart show" here, so that users know what you are referring to when talking about freebsd-boot (where is that output coming from).

bcr added a comment.Jun 25 2019, 7:33 PM

Any update on this one or are we waiting for upstream here?