Page MenuHomeFreeBSD

Remove the timed daemon.

Authored by gnn on Dec 10 2018, 11:56 PM.
Referenced Files
Unknown Object (File)
Sun, Nov 27, 12:21 AM
Unknown Object (File)
Sat, Nov 26, 8:56 PM



The timed daemon is outdated and should not be used, remove it from the tree.

Diff Detail

rS FreeBSD src repository - subversion
Lint Not Applicable
Tests Not Applicable

Event Timeline

Should you remove netdate.c entirely? and remove the prototype from date/extern.h ?

This change probably warrants an UPDATING entry and entries to obsolete files?

bz requested changes to this revision.EditedDec 11 2018, 9:05 PM

Check libexec/rc/rc.d/Makefile:.if ${MK_TIMED} != "no"
Check tools/build/mk/ ${MK_TIMED} == no
rm tools/build/options/WITHOUT_TIMED (and re-gen src.conf)

This revision now requires changes to proceed.Dec 11 2018, 9:05 PM

Address comments from bcr@ and bz@

sbruno added inline comments.
8506 ↗(On Diff #51997)

Should this be left in but without the MK_TIMED check? If we are nuking this feature, then the files should be deleted. Or am I wrong?

Address comments from sbruno. Leave the obsolete files but remove the MK_TIMED.

"Make it so" from manpages.

371 ↗(On Diff #51999)

seems to be a left over space here

Address leftover space.

bz requested changes to this revision.Dec 14 2018, 8:31 PM

I think you are still not removing /etc/rc.d/timed using ObsoleteFiles and also libexec/rc/rc.d/timed (I assume is where it's coming from given the Makefile change) is still in SVN.

This revision now requires changes to proceed.Dec 14 2018, 8:31 PM

I suggest a grep -ir timed over the src tree (ignore the .svn directory) is a good way of seeing or finding more.

Also please re-gen src.conf(5)

Address recent comments by bz@, but not src.conf

bz requested changes to this revision.Dec 15 2018, 12:12 PM

Sorry, a tiny tinsy bit more.
43 ↗(On Diff #52046)

No, libexec/rc/rc.d/timed is a svn rm operation; that never existed in your filesystem. Seems you have done that so just remove the 2nd OLD_FILES line

8506 ↗(On Diff #51997)

I guess it should be moved from Optional to with the rc.d script

This revision now requires changes to proceed.Dec 15 2018, 12:12 PM

Address Obsolete vs. OptionalObsolete issues.

gnn marked 2 inline comments as done.Dec 15 2018, 8:13 PM

Address issues with the latest diff.

Ok, let's try this..

This revision is now accepted and ready to land.Dec 15 2018, 9:01 PM
This revision was automatically updated to reflect the committed changes.