Page MenuHomeFreeBSD

rc.d/motd: Update motd more robustly
ClosedPublic

Authored by cem on Jun 19 2019, 8:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 6, 3:42 AM
Unknown Object (File)
Wed, Sep 2, 6:29 PM
Unknown Object (File)
Tue, Sep 1, 12:38 AM
Unknown Object (File)
Mon, Aug 31, 2:58 PM
Unknown Object (File)
Mon, Aug 24, 11:55 AM
Unknown Object (File)
Fri, Aug 14, 9:30 PM
Unknown Object (File)
Thu, Aug 13, 8:55 PM
Unknown Object (File)
Thu, Aug 13, 12:16 PM
Subscribers

Details

Summary

Use appropriate fsyncs to persist the rewritten /etc/motd file, when a
rewrite is performed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jun 19 2019, 8:09 PM

As mjg@ points out, the mktemp file may be on a different filesystem than /etc
(e.g., tmpfs, but any other filesystem invalidates the initial fsync). Copy to
a temporary /etc file, sync that, then rename over /etc/motd.

This revision now requires review to proceed.Jun 19 2019, 8:21 PM
This revision is now accepted and ready to land.Jun 19 2019, 9:07 PM
This revision was automatically updated to reflect the committed changes.