Page MenuHomeFreeBSD

rc.d/motd: Update motd more robustly
ClosedPublic

Authored by cem on Jun 19 2019, 8:06 PM.
Tags
None
Referenced Files
F136951625: D20701.id58859.diff
Thu, Nov 20, 7:47 PM
F136949346: D20701.id58805.diff
Thu, Nov 20, 7:35 PM
F136949177: D20701.id58803.diff
Thu, Nov 20, 7:34 PM
F136949133: D20701.id.diff
Thu, Nov 20, 7:34 PM
F136947255: D20701.diff
Thu, Nov 20, 7:21 PM
F136841041: D20701.id58859.diff
Thu, Nov 20, 12:18 AM
Unknown Object (File)
Tue, Nov 18, 6:39 AM
Unknown Object (File)
Mon, Nov 17, 4:19 PM
Subscribers

Details

Summary

Use appropriate fsyncs to persist the rewritten /etc/motd file, when a
rewrite is performed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jun 19 2019, 8:09 PM

As mjg@ points out, the mktemp file may be on a different filesystem than /etc
(e.g., tmpfs, but any other filesystem invalidates the initial fsync). Copy to
a temporary /etc file, sync that, then rename over /etc/motd.

This revision now requires review to proceed.Jun 19 2019, 8:21 PM
This revision is now accepted and ready to land.Jun 19 2019, 9:07 PM
This revision was automatically updated to reflect the committed changes.