Page MenuHomeFreeBSD

rc.d/motd: Update motd more robustly
ClosedPublic

Authored by cem on Jun 19 2019, 8:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 30, 4:21 AM
Unknown Object (File)
Dec 23 2024, 2:47 PM
Unknown Object (File)
Dec 11 2024, 8:35 AM
Unknown Object (File)
Oct 16 2024, 11:42 AM
Unknown Object (File)
Oct 4 2024, 9:03 PM
Unknown Object (File)
Sep 20 2024, 12:57 AM
Unknown Object (File)
Sep 20 2024, 12:57 AM
Unknown Object (File)
Sep 20 2024, 12:56 AM
Subscribers

Details

Summary

Use appropriate fsyncs to persist the rewritten /etc/motd file, when a
rewrite is performed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jun 19 2019, 8:09 PM

As mjg@ points out, the mktemp file may be on a different filesystem than /etc
(e.g., tmpfs, but any other filesystem invalidates the initial fsync). Copy to
a temporary /etc file, sync that, then rename over /etc/motd.

This revision now requires review to proceed.Jun 19 2019, 8:21 PM
This revision is now accepted and ready to land.Jun 19 2019, 9:07 PM
This revision was automatically updated to reflect the committed changes.