Page MenuHomeFreeBSD

rc.d/motd: Update motd more robustly
ClosedPublic

Authored by cem on Jun 19 2019, 8:06 PM.
Tags
None
Referenced Files
F158235535: D20701.id.diff
Sat, May 30, 4:06 AM
Unknown Object (File)
Fri, May 29, 3:10 AM
Unknown Object (File)
Mon, May 25, 10:02 PM
Unknown Object (File)
Wed, May 20, 2:58 PM
Unknown Object (File)
Wed, May 20, 2:13 PM
Unknown Object (File)
Wed, May 20, 9:34 AM
Unknown Object (File)
Wed, May 20, 6:14 AM
Unknown Object (File)
Tue, May 19, 3:24 AM
Subscribers

Details

Summary

Use appropriate fsyncs to persist the rewritten /etc/motd file, when a
rewrite is performed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jun 19 2019, 8:09 PM

As mjg@ points out, the mktemp file may be on a different filesystem than /etc
(e.g., tmpfs, but any other filesystem invalidates the initial fsync). Copy to
a temporary /etc file, sync that, then rename over /etc/motd.

This revision now requires review to proceed.Jun 19 2019, 8:21 PM
This revision is now accepted and ready to land.Jun 19 2019, 9:07 PM
This revision was automatically updated to reflect the committed changes.