Page MenuHomeFreeBSD

rc.d/motd: Update motd more robustly
ClosedPublic

Authored by cem on Jun 19 2019, 8:06 PM.
Tags
None
Referenced Files
F132038954: D20701.id58803.diff
Mon, Oct 13, 3:59 AM
Unknown Object (File)
Wed, Sep 17, 7:45 AM
Unknown Object (File)
Aug 30 2025, 8:53 PM
Unknown Object (File)
Aug 22 2025, 6:31 PM
Unknown Object (File)
Aug 5 2025, 10:17 AM
Unknown Object (File)
Aug 2 2025, 7:34 PM
Unknown Object (File)
Jul 4 2025, 5:21 AM
Unknown Object (File)
Jun 26 2025, 2:50 PM
Subscribers

Details

Summary

Use appropriate fsyncs to persist the rewritten /etc/motd file, when a
rewrite is performed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jun 19 2019, 8:09 PM

As mjg@ points out, the mktemp file may be on a different filesystem than /etc
(e.g., tmpfs, but any other filesystem invalidates the initial fsync). Copy to
a temporary /etc file, sync that, then rename over /etc/motd.

This revision now requires review to proceed.Jun 19 2019, 8:21 PM
This revision is now accepted and ready to land.Jun 19 2019, 9:07 PM
This revision was automatically updated to reflect the committed changes.