Page MenuHomeFreeBSD
Differential D19797

Use default shell assignment rather more complicated if then construct.
ClosedPublic
Actions

Authored by imp on Apr 2 2019, 3:44 PM.
Tags
None
Referenced Files
F169566191: D19797.id55828.diff
Tue, Sep 1, 10:49 PM
F169546122: D19797.diff
Tue, Sep 1, 9:25 PM
F169543724: D19797.id55920.diff
Tue, Sep 1, 9:14 PM
F169430492: D19797.id55828.diff
Tue, Sep 1, 12:54 PM
F169374756: D19797.id.diff
Tue, Sep 1, 8:53 AM
F169300760: D19797.id55734.diff
Tue, Sep 1, 3:57 AM
Unknown Object (File)
Mon, Aug 31, 11:10 PM
Unknown Object (File)
Mon, Aug 31, 3:33 PM
View All Files
Subscribers
allanjude
emaste

Details

Reviewers
None
Commits
rS358661: MFC:
rS346018: Use default shell assignment rather more complicated if then

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp created this revision.Apr 2 2019, 3:44 PM
Harbormaster completed remote builds in B23471: Diff 55734.Apr 2 2019, 3:44 PM
emaste added a subscriber: emaste.Apr 2 2019, 3:47 PM
emaste added inline comments.
sys/conf/newvers.sh
49 ↗(On Diff #55734)

✓

108 ↗(On Diff #55734)

✓
but this line looks too long?

145 ↗(On Diff #55734)

eww

allanjude added a subscriber: allanjude.Apr 2 2019, 3:59 PM
allanjude added inline comments.
sys/conf/newvers.sh
145 ↗(On Diff #55734)

This is a pretty common shell construct, I think it is fine.

imp added inline comments.Apr 2 2019, 4:24 PM
sys/conf/newvers.sh
108 ↗(On Diff #55734)

Other lines are longer.

emaste added inline comments.Apr 2 2019, 4:45 PM
sys/conf/newvers.sh
108 ↗(On Diff #55734)

Still better to not introduce new >80 col lines though... there are three > 80 cols right now, all of which are awkward to wrap to 80.

145 ↗(On Diff #55734)

Agreed, it's fine, I just don't like it :)

imp updated this revision to Diff 55828.EditedApr 5 2019, 6:16 AM

Fix line length, per ed.

also move b= to place closer to where it's used.

Harbormaster completed remote builds in B23528: Diff 55828.Apr 5 2019, 6:16 AM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 7 2019, 6:40 PM
Closed by commit rS346018: Use default shell assignment rather more complicated if then (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rS358661: MFC:.Mar 5 2020, 6:19 AM

Revision Contents
Changeset List

PathSize
head/
sys/
conf/
20 lines

Diff 55920

View Options

head/sys/conf/newvers.sh

Loading...