Page MenuHomeFreeBSD

Use default shell assignment rather more complicated if then construct.
ClosedPublic

Authored by imp on Apr 2 2019, 3:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 14, 7:13 AM
Unknown Object (File)
Tue, Oct 14, 2:47 AM
Unknown Object (File)
Mon, Oct 13, 8:26 PM
Unknown Object (File)
Sat, Oct 11, 2:22 AM
Unknown Object (File)
Tue, Oct 7, 12:24 AM
Unknown Object (File)
Tue, Sep 30, 1:16 PM
Unknown Object (File)
Sep 15 2025, 1:50 AM
Unknown Object (File)
Sep 13 2025, 2:42 AM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste added inline comments.
sys/conf/newvers.sh
49 ↗(On Diff #55734)

108 ↗(On Diff #55734)


but this line looks too long?

145 ↗(On Diff #55734)

eww

allanjude added inline comments.
sys/conf/newvers.sh
145 ↗(On Diff #55734)

This is a pretty common shell construct, I think it is fine.

sys/conf/newvers.sh
108 ↗(On Diff #55734)

Other lines are longer.

sys/conf/newvers.sh
108 ↗(On Diff #55734)

Still better to not introduce new >80 col lines though... there are three > 80 cols right now, all of which are awkward to wrap to 80.

145 ↗(On Diff #55734)

Agreed, it's fine, I just don't like it :)

Fix line length, per ed.

also move b= to place closer to where it's used.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 7 2019, 6:40 PM
This revision was automatically updated to reflect the committed changes.