Differential D19797

Use default shell assignment rather more complicated if then construct.
ClosedPublic
Actions

Authored by imp on Apr 2 2019, 3:44 PM.

Details

Reviewers: None
Commits: rS358661: MFC:
rS346018: Use default shell assignment rather more complicated if then

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23528
Build 22532: arc lint + arc unit

Event Timeline

imp created this revision.Apr 2 2019, 3:44 PM

Harbormaster completed remote builds in B23471: Diff 55734.Apr 2 2019, 3:44 PM

emaste added a subscriber: emaste.Apr 2 2019, 3:47 PM

emaste added inline comments.

sys/conf/newvers.sh
49	✓
108–109	✓ but this line looks too long?
146	eww

allanjude added a subscriber: allanjude.Apr 2 2019, 3:59 PM

allanjude added inline comments.

sys/conf/newvers.sh
146	This is a pretty common shell construct, I think it is fine.

imp added inline comments.Apr 2 2019, 4:24 PM

sys/conf/newvers.sh
108–109	Other lines are longer.

emaste added inline comments.Apr 2 2019, 4:45 PM

sys/conf/newvers.sh
108–109	Still better to not introduce new >80 col lines though... there are three > 80 cols right now, all of which are awkward to wrap to 80.
146	Agreed, it's fine, I just don't like it :)

Fix line length, per ed.

also move b= to place closer to where it's used.

Harbormaster completed remote builds in B23528: Diff 55828.Apr 5 2019, 6:16 AM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 7 2019, 6:40 PM

Closed by commit rS346018: Use default shell assignment rather more complicated if then (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rS358661: MFC:.Mar 5 2020, 6:19 AM

Revision Contents
Changeset List

Path

Size

sys/

conf/

newvers.sh

20 lines

Diff 55828

View Options

Use default shell assignment rather more complicated if then construct.ClosedPublicActions