Page MenuHomeFreeBSD

add instructions for SMTP access setup
ClosedPublic

Authored by danger on Tue, Jan 1, 11:44 PM.

Details

Diff Detail

Repository
rD FreeBSD doc repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

danger created this revision.Tue, Jan 1, 11:44 PM
danger edited the summary of this revision. (Show Details)Tue, Jan 1, 11:49 PM

Noticed only one thing, otherwise it looks good to me.

article.xml
2330 ↗(On Diff #52470)

There's an errant double-space here.

Thank you for working on this

article.xml
2300 ↗(On Diff #52470)

Should explain more about the /mail principal, and how to set it

danger added inline comments.Wed, Jan 2, 8:26 AM
article.xml
2300 ↗(On Diff #52470)

From my understanding, it should be created automatically during the referenced process at xref=kerberos-ldap

rpokala added a subscriber: rpokala.Thu, Jan 3, 7:00 AM

FWIW, LGTM.

ygy edited reviewers, added: docs; removed: Doc Committers.Thu, Jan 3, 2:01 PM
ygy added a subscriber: ygy.
danger updated this revision to Diff 52585.Sat, Jan 5, 2:51 PM

resolved items pointed out in the reviews

danger updated this revision to Diff 52586.Sat, Jan 5, 2:55 PM

fix typo

danger added inline comments.Sat, Jan 5, 3:02 PM
article.xml
2277 ↗(On Diff #52586)

should there be the FreeBSD.org infrastructure?

bcr accepted this revision.Tue, Jan 8, 9:04 AM
bcr added a subscriber: bcr.

OK to be added to the committers guide. Thanks!

This revision is now accepted and ready to land.Tue, Jan 8, 9:04 AM
mat added a subscriber: mat.Tue, Jan 8, 11:23 AM
mat added inline comments.
article.xml
96–97 ↗(On Diff #52586)
<literal><systemitem class="fqdomainname">smtp.FreeBSD.org</systemitem>:587</literal>
2283–2284 ↗(On Diff #52586)
<literal><systemitem class="fqdomainname">smtp.FreeBSD.org</systemitem>:587</literal>
2292 ↗(On Diff #52586)
<literal>From:</literal>
2293 ↗(On Diff #52586)
<literal><replaceable>yourusername</replaceable>@FreeBSD.org</literal>
2299–2300 ↗(On Diff #52586)
<literal><replaceable>yourusername</replaceable>/mail</literal>
2305 ↗(On Diff #52586)
<literal>@FreeBSD.org</literal>
2317 ↗(On Diff #52586)
<literal><replaceable>yourusername</replaceable>@FreeBSD.org</literal>
2324–2325 ↗(On Diff #52586)
(<literal>Authenticated sender: <replaceable>username</replaceable></literal>)
bcr requested changes to this revision.Tue, Jan 8, 1:35 PM

@mat: Ah, those are good additions to have. I should have noticed. I'm un-approving... ;-)

This revision now requires changes to proceed.Tue, Jan 8, 1:35 PM

I added those <literal> tags, but am getting the following errors, any ideas?

doc/en_US.ISO8859-1/articles/committers-guide/article.xml:97: element literal: validity error : Element systemitem is not declared in literal list of possible children

class="fqdomainname">smtp.FreeBSD.org</systemitem>:587</literal>
danger updated this revision to Diff 52768.Fri, Jan 11, 2:36 PM
  • add the literal tags around the FQDNs
bcr accepted this revision.Fri, Jan 11, 8:10 PM

I think it fulfills the criteria for integration into the document. Approved!

This revision is now accepted and ready to land.Fri, Jan 11, 8:10 PM
This revision was automatically updated to reflect the committed changes.