LGTM, added some minor comments.

In D35215#798456, @emaste wrote:

Do you think it's worth #defining a LIBSYSDECODE_LINUXULATOR or such? I presume we'll add riscv and/or ppc at some point.

Do you think it's worth #defining a LIBSYSDECODE_LINUXULATOR or such? I presume we'll add riscv and/or ppc at some point.

fixed, thaks, also ifdef linux related code

Put linux code under ifdef

:-( this is unexpected, I don't recall clicking Continue.

This is a lot more complicated and code is probably to far down in kernel to do without layer violations/stupid. But having an automode that would check if someone was on a physical console(monitor/keyboard or serial) and if halt is run over ssh or similar(mosh) then reboot instead.

• Rephrase error message and formatting
• Removed blank line

Abandoning in favor of another way.

Ah, sorry, I forgot that OUT() is a macro that wraps return, so everything is fine.

SCHED_FIFO, SCHED_OTHER, SCHED_RR are indeed in sys/sched.h

Hang on, I think the change I requested may have been incorrect...

Urgh, I remembered just in time about sysutils/bhyve-firmware that will also need updated.

@des updated

• Rephrase error message and formatting

looks reasonable

In D35146#798323, @hselasky wrote:

Hans, can you further explain this "overcurrent not set"? I'm reading the USB 2.0 specifications here http://sdpha2.ucsd.edu/Lab_Equip_Manuals/usb_20.pdf on the last paragraph on page 339 with continuation on page 340.

Did you find an answer?

In D35146#798321, @hselasky wrote:

I wonder why there is an overcurrent event happening in the first place ....

In D35146#798320, @hselasky wrote:

I see.

Can you upload the patch with context:

diff -U 999999 sys/dev/usb/usb_hub.c.orig sys/dev/usb/usb_hub.c > usb.diff

--HPS

Changes:

• usb_pause_mtx() function is placed after UHF_PORT_POWER.
• diff enabled in more context output (diff -U 999999)