Page MenuHomeFreeBSD

Committer's Guide: refer to Phabricator wiki page
ClosedPublic

Authored by grahamperrin on May 16 2022, 5:56 PM.

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

grahamperrin created this revision.

LGTM (as I mentioned on the pull request), but I suggest adding docs as a group reviewer and mentioning a test plan. (Can be as simple as checking with igor and building. See https://docs.freebsd.org/en/books/fdp-primer/doc-build/.)

… checking with igor and building. See https://docs.freebsd.org/en/books/fdp-primer/doc-build/.)

Is that, Igor the person? (I don't recognise the name, although it's recognised by Phabricator.)

This revision is now accepted and ready to land.May 21 2022, 2:04 PM
In D35224#799567, @grahamperrin_gmail.com wrote:

… checking with igor and building. See https://docs.freebsd.org/en/books/fdp-primer/doc-build/.)

Is that, Igor the person? (I don't recognise the name, although it's recognised by Phabricator.)

No, the documentation linter installed as a docproj dependency.

[pauamma@gadfly] ~% pkg search igor
igor-1.595 FreeBSD Documentation Project sanity check script
...

[pauamma@gadfly] ~% pkg search docproj
docproj-4.1.1 Meta-port for the FreeBSD Documentation Project
...

In D35224#799716, @pauamma_gundo.com wrote:

No, the documentation linter installed as a docproj dependency.

Ah, thank you!

I made the mistake of seeking igor in https://docs.freebsd.org/en/books/fdp-primer/doc-build/ – not found.

Sought and found after switching from short (split) to long HTML https://docs.freebsd.org/en/books/fdp-primer/book/.

I do already have both packages, but the name igor was not memorable.