I perused the code a little more before committing. The whole vs range locking thing is making me increasingly worried. That said, I think the best course of action is to add validation to fifo_advlock that the args passed match up what's de facto passable by flock. Then it can call vop_stdadvlock.

• bcm2838_pci.c: fix one type.

My bad, I didn't test this on a 32 bit platform. I fixed some types to use the right type (pci_addr_t instead of bus_addr_t) and checked it builds on armv7 and aarch64.

• bcm2838_pci.c: fix some types for armv7.

Will use D25563.

Actually assert chunksize > MAXBPS;

Update the date in the man page.

Awesome thanks

It looks good to me. Don't forget to mention in the commit log that it updates also Unicode to Unicode 13

Alternative solution: D25563 .

__assert_unreachable in correct place

Use __assert_unreachable().
Shorten the code by two LOC.

Instead of clearing flags, which might not be possible in a higher securelevel, how about just using UF_OFFLINE instead of SF_IMMUTABLE? That's what some of the other test cases do. The test doesn't care what the flag actually is; it just needs to be something.

In D23356#565161, @rgrimes wrote:

Is it possible to do cgn without rfc1918? I think the changes should allow for that configuration.

Is it possible to do cgn without rfc1918? I think the changes should allow for that configuration.

In D25208#565139, @pi wrote:

Testbuilds are fine. fernape, are you going to commit this ?

In D25279#564872, @ml_vishwin.info wrote:

Restoring patch-gmodule_gmodule-dl.c has no effect; Cinnamon is still broken. I suspect some more files need restored.

Here, added the testing section.

I could understand what you are trying to do from the description, but then I completely confused by the patch. FreeBSD st_dev is mnt_stat.f_fsid, then linuxolator st_dev is lower 16bits of it. Now read the comment before vfs_getnewfsid().

In D24255#565138, @mjg wrote:

I agree with the patch. What line would like to see in "submitted by"?