Page MenuHomeFreeBSD

Use KERN_MAXPHYS.
ClosedPublic

Authored by delphij on Jul 4 2020, 7:49 PM.

Details

Summary

Suggested by: imp

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

delphij created this revision.
This revision is now accepted and ready to land.Jul 4 2020, 8:08 PM
cem added inline comments.
sbin/newfs_msdos/mkfs_msdos.c
842–845 ↗(On Diff #74083)

It seems like this API could just be size_t given the way it is used and defined.

Actually assert chunksize > MAXBPS;

Use int for intermediate chunksize as the sysctl is defined as
SYSCTL_INT.

This revision now requires review to proceed.Jul 4 2020, 9:24 PM
emaste added a subscriber: emaste.
emaste added inline comments.
sbin/newfs_msdos/mkfs_msdos.c
43 ↗(On Diff #74085)

all else being equal, put in alpha order?

This revision is now accepted and ready to land.Jul 5 2020, 12:03 AM
This revision was automatically updated to reflect the committed changes.