Page MenuHomeFreeBSD
Differential D25563

Use KERN_MAXPHYS.
ClosedPublic
Actions

Authored by delphij on Jul 4 2020, 7:49 PM.
Tags
None
Referenced Files
F134410829: D25563.diff
Sun, Nov 2, 1:50 AM
Unknown Object (File)
Fri, Oct 31, 4:14 AM
Unknown Object (File)
Tue, Oct 28, 3:23 PM
Unknown Object (File)
Fri, Oct 24, 3:23 AM
Unknown Object (File)
Tue, Oct 21, 12:34 AM
Unknown Object (File)
Thu, Oct 16, 4:45 PM
Unknown Object (File)
Thu, Oct 16, 4:44 PM
Unknown Object (File)
Thu, Oct 16, 4:44 PM
View All 88 Files
Subscribers
emaste

Details

Reviewers
cem
imp
emaste
Commits
rS362937: Use KERN_MAXPHYS.
Summary

Suggested by: imp

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32138
Build 29649: arc lint + arc unit

Event Timeline

delphij requested review of this revision.Jul 4 2020, 7:49 PM
delphij created this revision.
Harbormaster completed remote builds in B32136: Diff 74083.Jul 4 2020, 7:49 PM
delphij mentioned this in D25562: Use static_assert..Jul 4 2020, 7:50 PM
imp accepted this revision.Jul 4 2020, 8:08 PM

Awesome thanks

This revision is now accepted and ready to land.Jul 4 2020, 8:08 PM
cem accepted this revision.Jul 4 2020, 8:28 PM
cem added inline comments.
sbin/newfs_msdos/mkfs_msdos.c
842–845

It seems like this API could just be size_t given the way it is used and defined.

delphij updated this revision to Diff 74085.Jul 4 2020, 9:24 PM

Actually assert chunksize > MAXBPS;

Use int for intermediate chunksize as the sysctl is defined as
SYSCTL_INT.

This revision now requires review to proceed.Jul 4 2020, 9:24 PM
Harbormaster completed remote builds in B32138: Diff 74085.Jul 4 2020, 9:24 PM
emaste accepted this revision.Jul 5 2020, 12:03 AM
emaste added a subscriber: emaste.
emaste added inline comments.
sbin/newfs_msdos/mkfs_msdos.c
43

all else being equal, put in alpha order?

This revision is now accepted and ready to land.Jul 5 2020, 12:03 AM
Closed by commit rS362937: Use KERN_MAXPHYS. (authored by delphij). · Explain WhyJul 5 2020, 12:19 AM
This revision was automatically updated to reflect the committed changes.
delphij added a commit: rS362937: Use KERN_MAXPHYS..
arichardson mentioned this in rS364765: Fix makefs bootstrap on macOS after D25563.Aug 25 2020, 1:30 PM

Revision Contents
Changeset List

PathSize
sbin/
newfs_msdos/
65 lines

Diff 74085

View Options

sbin/newfs_msdos/mkfs_msdos.c

Loading...