net-mgmt/nsca-ng: Update to 1.6, now compiles on -12 and -13

[knan-rfo_modirum.com]

Summary

nsca-ng development has moved to github. Refresh to version 1.6 from there.

[fernape]

Thanks for the patch.
You might be interested in using ports-mgmt/portlint and ports-mgmt/poudriere. These tools catch most if not all of the common pitfalls we face when updating ports.
You can have more information here:
https://www.freebsd.org/doc/en/books/porters-handbook/book.html#testing-poudriere
https://www.freebsd.org/doc/en/books/porters-handbook/book.html#porting-portlint

net-mgmt/nsca-ng/Makefile

2 ↗

(On Diff #72923)

The review patch doesn't apply cleanly for Makefile. The version in the repository already contains this line for example.

6 ↗

(On Diff #72923)

Delete since we are bumping PORTVERSION

8 ↗

(On Diff #72923)

Move up right after PORTVERSION

12 ↗

(On Diff #72923)

This should be after USES=
Also GH_PROJECT can be deleted since it defaults to PORTNAME

[knan-rfo_modirum.com]

Addressed review comments, now passes portlint, already passed poudriere testport.

[knan-rfo_modirum.com]

Thanks for the review. Updated patch addresses these nits.

[fernape]

net-mgmt/nsca-ng/Makefile

44 ↗

(On Diff #72977)

WARN: Makefile: [43]: IGNORE messages should begin with a lowercase letter and end without a period.

[knan-rfo_modirum.com]

Pre-existing warning before this patch, so a bit out of scope I feel. But I can of course fix it.

[knan-rfo_modirum.com]

Fix remaining pre-existing portlint nits.

[fernape]

Thanks for that!

Builds OK for {11.3,12.1}{amd64,i386} and 13-current

LGTM

[pi]

Testbuilds are fine. fernape, are you going to commit this ?

[fernape]

In D25208#565139, @pi wrote:

Testbuilds are fine. fernape, are you going to commit this ?

Sure thing. Thanks for reviewing this.