Page MenuHomeFreeBSD

vt(4): CONS_HISTORY/CONS_CLRHIST should operate on issuing terminal
ClosedPublic

Authored by jah on Jul 4 2020, 10:22 PM.

Details

Summary

Currently the CONS_HISTORY and CONS_CLRHIST ioctls modify the state of the
active terminal instead of the terminal against which the ioctl was issued.
Because of the way vidcontrol(1) works, these are the same in most cases.
But a poorly-timed window switch can make them differ. This is reproducible
by issuing e.g. 'vidcontrol -s 2 && vidcontrol -C' to switch from vty 1 to
vty 2; teken will reset the cursor position on vty 1 but vt(4) will clear
the history buffer of vty 2, producing an interesting state of affairs.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jah created this revision.Jul 4 2020, 10:22 PM
jah requested review of this revision.Jul 4 2020, 10:22 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sun, Aug 2, 8:18 PM
This revision was automatically updated to reflect the committed changes.