Page MenuHomeFreeBSD
Differential D25503

Update tools/tools/locale
ClosedPublic
Actions

Authored by hrs on Jun 29 2020, 5:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 6:30 AM
Unknown Object (File)
Sun, Apr 28, 3:47 PM
Unknown Object (File)
Sun, Apr 28, 3:47 PM
Unknown Object (File)
Sun, Apr 28, 3:47 PM
Unknown Object (File)
Sun, Apr 28, 3:36 AM
Unknown Object (File)
Wed, Apr 24, 4:50 AM
Unknown Object (File)
Thu, Apr 18, 10:28 AM
Unknown Object (File)
Mar 17 2024, 9:21 PM
View All 31 Files
Subscribers
imp
lwhsu

Details

Reviewers
bapt
yuripv
Commits
rS364245: - Update to Unicode CLDR v35 (Unicode 12.0).
Summary

Update tools/tools/locale to add make targets to automatically generate locale source files. With this patch, just typing "make obj && make" should build them.

Fix issues in ja_JP ctypedef and range specification support in utf8-rollup.pl.

Details are as follows:

Makefile:

  • Support .OBJDIR.
  • Support pararell build.
  • Add a check of the installed tools.
  • Update to use CLDR v35.

tools/cldr2def.pl:

  • Use eucJP for ja_JP ctypedef because eucJP is not compatible with UTF-8.

tools/convert_map.pl:

  • Add a verbose error message.

tools/utf8-rollup.pl:

  • Normalize entries to use Unicode, not UTF-8.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

hrs created this revision.Jun 29 2020, 5:37 AM
Herald added a subscriber: imp. · View Herald TranscriptJun 29 2020, 5:37 AM
hrs requested review of this revision.Jun 29 2020, 5:37 AM
Harbormaster completed remote builds in B32032: Diff 73860.Jun 29 2020, 5:37 AM
hrs edited the summary of this revision. (Show Details)Jun 29 2020, 5:38 AM
lwhsu added a subscriber: lwhsu.Jun 29 2020, 2:13 PM
bapt accepted this revision.Jul 4 2020, 7:57 PM

It looks good to me. Don't forget to mention in the commit log that it updates also Unicode to Unicode 13

This revision is now accepted and ready to land.Jul 4 2020, 7:57 PM
Closed by commit rS364245: - Update to Unicode CLDR v35 (Unicode 12.0). (authored by hrs). · Explain WhyAug 31 2020, 10:57 PM
This revision was automatically updated to reflect the committed changes.
hrs added a commit: rS364245: - Update to Unicode CLDR v35 (Unicode 12.0)..
yuripv added a comment.Dec 12 2020, 11:30 PM

As I was going through MFCing locale changes, I noticed one little (BIG) problem with this review/commit -- it forgot to actually install the updated sources to share/ subdirectories, so we currently ship what was previous version in share/.

I'll take care of this in upcoming changes, no action required.

tools/tools/locale/patch/patch-UnicodeData.txt
1 ↗(On Diff #73860)

Was this submitted upstream as it's pretty hard to maintain such patches?

Revision Contents
Changeset List

PathSize
head/
tools/
tools/
locale/
185 lines
80 lines
etc/
final-maps/
554 lines
patch/
29 lines
tools/
5 lines
5 lines
38 lines
31 lines

Diff 76445

View Options

head/tools/tools/locale/Makefile

Loading...
View Options

head/tools/tools/locale/README

Loading...
View Options

head/tools/tools/locale/etc/final-maps/map.UTF-8

Loading...
View Options

head/tools/tools/locale/patch/patch-UnicodeData.txt

Loading...
View Options

head/tools/tools/locale/tools/cldr2def.pl

Loading...
View Options

head/tools/tools/locale/tools/convert_map.pl

Loading...
View Options

head/tools/tools/locale/tools/finalize

Loading...
View Options

head/tools/tools/locale/tools/utf8-rollup.pl

Loading...