Page MenuHomeFreeBSD

Update tools/tools/locale
ClosedPublic

Authored by hrs on Jun 29 2020, 5:37 AM.

Details

Summary

Update tools/tools/locale to add make targets to automatically generate locale source files. With this patch, just typing "make obj && make" should build them.

Fix issues in ja_JP ctypedef and range specification support in utf8-rollup.pl.

Details are as follows:

Makefile:

  • Support .OBJDIR.
  • Support pararell build.
  • Add a check of the installed tools.
  • Update to use CLDR v35.

tools/cldr2def.pl:

  • Use eucJP for ja_JP ctypedef because eucJP is not compatible with UTF-8.

tools/convert_map.pl:

  • Add a verbose error message.

tools/utf8-rollup.pl:

  • Normalize entries to use Unicode, not UTF-8.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

hrs requested review of this revision.Jun 29 2020, 5:37 AM

It looks good to me. Don't forget to mention in the commit log that it updates also Unicode to Unicode 13

This revision is now accepted and ready to land.Jul 4 2020, 7:57 PM
This revision was automatically updated to reflect the committed changes.

As I was going through MFCing locale changes, I noticed one little (BIG) problem with this review/commit -- it forgot to actually install the updated sources to share/ subdirectories, so we currently ship what was previous version in share/.

I'll take care of this in upcoming changes, no action required.

tools/tools/locale/patch/patch-UnicodeData.txt
1 ↗(On Diff #73860)

Was this submitted upstream as it's pretty hard to maintain such patches?