Page MenuHomeFreeBSD
Differential D23110

Introduce CTLFLAG_NEEDGIANT
AbandonedPublic
Actions

Authored by kaktus on Jan 9 2020, 7:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 9:16 PM
Unknown Object (File)
Mon, Apr 14, 11:28 AM
Unknown Object (File)
Sat, Apr 12, 2:36 PM
Unknown Object (File)
Fri, Mar 28, 6:53 PM
Unknown Object (File)
Mar 21 2025, 12:00 PM
Unknown Object (File)
Mar 20 2025, 1:51 AM
Unknown Object (File)
Mar 18 2025, 1:27 PM
Unknown Object (File)
Mar 12 2025, 9:00 AM
View All Files
Subscribers
ae
andrew
asiciliano
asomers
bcr
bcran
bjk
View All 18 Subscribers

Details

Reviewers
kib
mjg
imp
gnn
jmg
slm
shurd
manu
cy
Group Reviewers
transport
bhyve
x11
iflib
manpages
Summary

Introduce the CTLFLAG_NEEDGIANT flag (modelled after D_NEEDGIANT) that can be used to name and shame sysctls still requiring Giant ;-)

Set CTLFLAG_NEEDGIANT to all SYSCTL_(ADD_)PROCs not marked as MPSAFE.

Mark all SYSCTL_(ADD_)NODEs using custom handler and not already marked as MPSAFE as CTLFLAG_NEEDGIANT.

Mark all various handcrafted SYSCTL_(ADD_)OID etc invocation I've seen in the code.

Add a static_assert to check for one of the now required flags.

Full diff with -U999999 available at https://people.freebsd.org/~kaktus/sysctl.patch because it's getting close to 18MB.

TODO:
Check kmods in ports?

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kaktus created this revision.Jan 9 2020, 7:03 PM
Herald added a reviewer: gnn. · View Herald TranscriptJan 9 2020, 7:03 PM
Herald added a reviewer: jmg. · View Herald Transcript
Herald added a reviewer: cem. · View Herald Transcript
Herald added a reviewer: transport. · View Herald Transcript
Herald added a reviewer: bhyve. · View Herald Transcript
Herald added subscribers: donner, bcran, bz and 8 others. · View Herald Transcript
imp added a comment.Jan 9 2020, 7:09 PM

I like it. The only thing that could be better in CTASSERT that exactly one of MPSAFE or NEEDGIANT is set.

emaste added a subscriber: emaste.Jan 9 2020, 7:17 PM
mjg added a comment.EditedJan 9 2020, 7:31 PM

I disagree with this approach.

Instead I suggest the following:
0. on registration add a warning that given sysctl is not marked as mpsafe [optional]

  1. keep converting existing sysctls and adding the CTLFLAG_MPSAFE flag. worst case giant can be pushed into specific handlers
  2. once it seems everything is converted require the flag to be set for sysctl to be registered, special handling for giant is removed from sysctl itself
  3. phase out the flag some time later. coccinelle can easily do it.
imp added a comment.Jan 9 2020, 8:05 PM

The advantage of this approach is that it lets us know what has been audited at compile time...

mjg added a comment.Jan 9 2020, 8:25 PM

I don't see any benefit. "general" kernel does not use giant and everything there is almost guaranteed to be trivially annotated as _MPSAFE (just someone has to inspect all cases). the only fishy stuff may be in syscons or some drivers. If in doubt, giant handling can be pushed into these handlers. Basically almost everything inspected is instantly resolvable one way or the other.

cem added a comment.EditedJan 9 2020, 8:51 PM

Setting aside the issue of whether having a flag is a good idea, I'm not sure this is the right name. Really what we're trying to indicate after we get rid of Giant is whether these sysctls are reentrant or not (and need external mutual exclusion)... right? Maybe something like NEEDMUTEX rather than Giant in particular? /bikeshed

(As always, I might be totally mistaken. Let me know if I’m wrong and hopefully I learn something.)

mjg added a comment.Jan 9 2020, 9:21 PM

Scenario where a sysctl ends up being called from another sysctl like this sounds like a programming error.

cem added a comment.Jan 9 2020, 9:31 PM
In D23110#506565, @mjg wrote:

Scenario where a sysctl ends up being called from another sysctl like this sounds like a programming error.

Reentrant was the wrong word. Threadsafe? Concurrent? Something like that.

kaktus updated this revision to Diff 66577.Jan 9 2020, 9:39 PM

Fix few typos and be more consistent on style(9).

kaktus added a comment.Jan 9 2020, 9:46 PM

I'm not going to die for a name, but! we still have D_NEEDGIANT and the name still describe what is being done in this case.

Also, based on my (and probably not only mine) experience, if there is no whining there is little incentive to work on boring fixes and this is what most of the work here will be.

mjg added a comment.Jan 9 2020, 10:33 PM
In D23110#506566, @cem wrote:
In D23110#506565, @mjg wrote:

Scenario where a sysctl ends up being called from another sysctl like this sounds like a programming error.

Reentrant was the wrong word. Threadsafe? Concurrent? Something like that.

mpsafe sysctls already have to provide their own locking in this regard. the only guarantee provided by the sysctl mechanism is that the handler will not get unloaded while executed

mjg added a comment.Jan 9 2020, 10:34 PM
In D23110#506569, @kaktus wrote:

Also, based on my (and probably not only mine) experience, if there is no whining there is little incentive to work on boring fixes and this is what most of the work here will be.

Every single case to be inspected by hand immediately gets CTLFLAG_MPSAFE. Either it did not need giant to begin with or (in the worst case) you can put giant locking into the handler. As such, the proposed flag does not add any value. It's just extra level of churn before the entire ordeal is removed.

imp added a comment.Jan 9 2020, 11:00 PM
In D23110#506563, @cem wrote:

Setting aside the issue of whether having a flag is a good idea, I'm not sure this is the right name. Really what we're trying to indicate after we get rid of Giant is whether these sysctls are reentrant or not (and need external mutual exclusion)... right? Maybe something like NEEDMUTEX rather than Giant in particular? /bikeshed

(As always, I might be totally mistaken. Let me know if I’m wrong and hopefully I learn something.)

Yea, but the NEEDGIANT name means a grep

In D23110#506589, @mjg wrote:
In D23110#506569, @kaktus wrote:

Also, based on my (and probably not only mine) experience, if there is no whining there is little incentive to work on boring fixes and this is what most of the work here will be.

Every single case to be inspected by hand immediately gets CTLFLAG_MPSAFE. Either it did not need giant to begin with or (in the worst case) you can put giant locking into the handler. As such, the proposed flag does not add any value. It's just extra level of churn before the entire ordeal is removed.

Except that assumes one person is doing the auditing. There will be several and the tag let's them all run asynchronously as well as the fix. Churn in the modern SCM doesn't matter. We have high rates of normal change, much of it changing things that have been changed since the last branch. Churn mattered on CVS, but doesn't, really, if done right.

mjg added a comment.Jan 9 2020, 11:06 PM
In D23110#506612, @imp wrote:
In D23110#506589, @mjg wrote:

Every single case to be inspected by hand immediately gets CTLFLAG_MPSAFE. Either it did not need giant to begin with or (in the worst case) you can put giant locking into the handler. As such, the proposed flag does not add any value. It's just extra level of churn before the entire ordeal is removed.

Except that assumes one person is doing the auditing. There will be several and the tag let's them all run asynchronously as well as the fix. Churn in the modern SCM doesn't matter. We have high rates of normal change, much of it changing things that have been changed since the last branch. Churn mattered on CVS, but doesn't, really, if done right.

With the patch as proposed here people would have to look for CTLFLAG_NEEDGIANT sysctls. With stock kernel people have to look for sysctls *without* the CTLFLAG_MPSAFE flag. Both cases have the same coopoeration issues, just the method of figuring out whether given handler needs to be worked on is different.

kib added a comment.Jan 10 2020, 9:23 AM
In D23110#506613, @mjg wrote:
In D23110#506612, @imp wrote:
In D23110#506589, @mjg wrote:

Every single case to be inspected by hand immediately gets CTLFLAG_MPSAFE. Either it did not need giant to begin with or (in the worst case) you can put giant locking into the handler. As such, the proposed flag does not add any value. It's just extra level of churn before the entire ordeal is removed.

Except that assumes one person is doing the auditing. There will be several and the tag let's them all run asynchronously as well as the fix. Churn in the modern SCM doesn't matter. We have high rates of normal change, much of it changing things that have been changed since the last branch. Churn mattered on CVS, but doesn't, really, if done right.

With the patch as proposed here people would have to look for CTLFLAG_NEEDGIANT sysctls.

RIght. Another fruit of this work would be audit of all places which have this flag set, and handling of trivial cases where the flag can be removed.

So the result should be an material and easy to asses estimation of the efforts to clean sysctls from Giant.

With stock kernel people have to look for sysctls *without* the CTLFLAG_MPSAFE flag. Both cases have the same coopoeration issues, just the method of figuring out whether given handler needs to be worked on is different.

No, grepping for absence in multi-line vague text is not a solution. More, there is a lot of things to grep, e.g. dynamic sysctl oids allocation and so on. Also, I object against fixing cases of NEEDGIANT by pushing Giant into the handler, there is no point doing this. Handlers must be fixed to not require Giant, in the course of mpsafe work.

I do want sysctls be on par with cdevsw in this regard, where it is absolutely obvious when needs Giant and what does not.

But again, the main benefit of tht work would be the audit, and I was both surprised and pleased when I saw that kaktus started it.

sys/x86/x86/cpu_machdep.c
745

This probably can get rid of NEEDGIANT.

792

This probably can get rid of NEEDGIANT.

sys/x86/x86/intr_machdep.c
754

This probably can get rid of NEEDGIANT.

sys/x86/x86/tsc.c
755

This NEEDGIANT looks spurious, it can be removed in the next step.

[I stopped auditing additions of NEEDGIANT but almost every appearance looks spurious]

kaktus added a comment.Jan 10 2020, 10:36 AM

Yes, many of the sysctls can be trivially be made / already are but aren't marked as MPSAFE but this was mostly sed + vim macros + a bit of manual fixes to add the flag where MPSAFE isn't set (yet).
The question is: should fixing this be done in this (already huge) diff or as a separate work later.

kib added a comment.Jan 10 2020, 1:08 PM
In D23110#506677, @kaktus wrote:

Yes, many of the sysctls can be trivially be made / already are but aren't marked as MPSAFE but this was mostly sed + vim macros + a bit of manual fixes to add the flag where MPSAFE isn't set (yet).
The question is: should fixing this be done in this (already huge) diff or as a separate work later.

Of course adding MPSAFE (or removing NEEDGIANT) should be done in the next patch. I listed some of them only to demonstrate how your work to add NEEDGIANT causes easy and straightforward fixes.

asiciliano added a subscriber: asiciliano.Jan 10 2020, 7:18 PM

A question because I should update my tools.
If a node has not the CLT_MFSAFE flags then it has to have the CTL_NEEDGIANT, is it right?
(So I should add a new "flag column" to deskutils/sysctlview and handle/show the new flag with "nsysctl -aNG" sysutils/nsysctl)

Thank you in advance

mjg added a comment.EditedJan 12 2020, 5:36 AM
In D23110#506672, @kib wrote:
In D23110#506613, @mjg wrote:
In D23110#506612, @imp wrote:
In D23110#506589, @mjg wrote:

Every single case to be inspected by hand immediately gets CTLFLAG_MPSAFE. Either it did not need giant to begin with or (in the worst case) you can put giant locking into the handler. As such, the proposed flag does not add any value. It's just extra level of churn before the entire ordeal is removed.

Except that assumes one person is doing the auditing. There will be several and the tag let's them all run asynchronously as well as the fix. Churn in the modern SCM doesn't matter. We have high rates of normal change, much of it changing things that have been changed since the last branch. Churn mattered on CVS, but doesn't, really, if done right.

With the patch as proposed here people would have to look for CTLFLAG_NEEDGIANT sysctls.

RIght. Another fruit of this work would be audit of all places which have this flag set, and handling of trivial cases where the flag can be removed.

So the result should be an material and easy to asses estimation of the efforts to clean sysctls from Giant.

But there is no need to patch the kernel to get that information. See below.

With stock kernel people have to look for sysctls *without* the CTLFLAG_MPSAFE flag. Both cases have the same coopoeration issues, just the method of figuring out whether given handler needs to be worked on is different.

No, grepping for absence in multi-line vague text is not a solution. More, there is a lot of things to grep, e.g. dynamic sysctl oids allocation and so on.

I don't know what kind of script kaktus used to generate his patch, I hacked up the following:

find . -name '*.[ch]' | xargs -P1 awk '/SYSCTL_PROC/ { ins = 1; } /SYSCTL_ADD_PROC/ { ins = 1; } ins { line = line $0; } /;/ && ins { ins = 0; print FILENAME " " line; line = "" }' | grep -v MPSAFE

Prints stuff like this:

./fs/nfsclient/nfs_clnfsiod.c SYSCTL_PROC(_vfs_nfs, OID_AUTO, iodmin, CTLTYPE_UINT | CTLFLAG_RW, 0, sizeof (nfs_iodmin), sysctl_iodmin, "IU", "Min number of nfsiod kthreads to keep as spares");
./fs/nfsclient/nfs_clnfsiod.c SYSCTL_PROC(_vfs_nfs, OID_AUTO, iodmax, CTLTYPE_UINT | CTLFLAG_RW, 0, sizeof (ncl_iodmax), sysctl_iodmax, "IU", "Max number of nfsiod kthreads");
./fs/nfsserver/nfs_nfsdport.c SYSCTL_PROC(_vfs_nfsd, OID_AUTO, dsdirsize, CTLTYPE_UINT | CTLFLAG_RW, 0, sizeof(nfsrv_dsdirsize), sysctl_dsdirsize, "IU", "Number of dsN subdirs on the DS servers");

It probably misses entries but should catch everything seen in this patch and more. Everyone interested in removing some of this stuff can just run it.

Once nothing in the tree is found like this one can add a CTASSERT the flag is set and a runtime check to panic during registration of sysctls which don't have it.

Also interested people can run dtrace to see what is taking giant at runtime on their boxes:

dtrace -n 'fbt::sysctl_root_handler_locked:entry /(args[0]->oid_kind & 0x00040000) == 0/ { @[stringof(args[0]->oid_name), args[0]->oid_descr[0] != 0 ? stringof(args[0]->oid_descr) : "NULL", sym((uintptr_t)args[0]->oid_handler)] = count(); }' -o out
sysctl -a > /dev/null

I cleaned up some immediate offenders.

Also, I object against fixing cases of NEEDGIANT by pushing Giant into the handler, there is no point doing this. Handlers must be fixed to not require Giant, in the course of mpsafe work.

I don't suggest just plopping Giant in the handler. Rather vast majority of cases will straight up just need the annotation added. I expect few problematic cases where Giant is actually used and I don't think they should be holding off removal of giant support from sysctl itself.

I do want sysctls be on par with cdevsw in this regard, where it is absolutely obvious when needs Giant and what does not.

But it is clear (but the condition is inverted). Instead of grepping for a flag one has to grep for lack of the flag, which as noted above is not a problem.

But again, the main benefit of tht work would be the audit, and I was both surprised and pleased when I saw that kaktus started it.

kaktus added a comment.Jan 12 2020, 5:32 PM
In D23110#506834, @alfix86_gmail.com wrote:

A question because I should update my tools.
If a node has not the CLT_MFSAFE flags then it has to have the CTL_NEEDGIANT, is it right?

Exactly.

kaktus updated this revision to Diff 66654.Jan 12 2020, 5:42 PM
kaktus edited the summary of this revision. (Show Details)

Mark all SYSCTL_NODEs using custom handler and not already marked as MPSAFE as CTLFLAG_NEEDGIANT.
Mark all SYSCTL_NODEs with NULL handler as MPSAFE.

Sync with HEAD.

jhb added a subscriber: jhb.Jan 14 2020, 8:08 PM

@mjg You are completely missing the point I think. grep -r CTLFLAG_NEEDGIANT is much easier for many folks to run (and remember, and derive off the top of their head) than the script you came up with. FWIW, I would like to use a similar approach with bus_setup_intr() to tag the ones that still need giant explicitly to make them easier to find. It is true that when finishing marking syscalls, I did not add a Giant flag but just converted them all over, but that was a much smaller set of things to examine. I'd much rather us at this point move to a model where we tag things as needing Giant rather than not needing Giant.

donner added a comment.Jan 14 2020, 9:26 PM

Sorry, I'm lost. What is the purpose of this flag?

If it has a real value for the code path (define a specific functionaliy, which is not already present), I'm fine (modulo naming discussions).

If it is only annotating something for a group of deverlopers, I'd suggest an inline comment in all the files.
If the group of interested developers is not significant, I'd suggest a separate todo-file somewhere in the development area containing all the syscalls in question.

mjg added a comment.EditedJan 14 2020, 9:34 PM
In D23110#508042, @jhb wrote:

@mjg You are completely missing the point I think. grep -r CTLFLAG_NEEDGIANT is much easier for many folks to run (and remember, and derive off the top of their head) than the script you came up with.

I'm pretty sure I'm not missing the point. Giant-locked handlers are still in the tree mostly because there was no to push to take care of them. Given someone's idea to remove Giant before 13.0 ships now there is a push to do it. The very same people who would have to be told to grep for CTLFLAG_NEEDGIANT can be told to run the one-liner I provided above. I really don't see how this is supposed to be more problematic. Presumably there would be an e-mail urging people to clear this up, then they can easily reference it if needed. Or if they use the one-liner they will probably easily find it later in their shell history.

In reality I suspect a small group of people will take care of majority of all handlers, 3-4 people will fix some instances on their own volition and the rest will have to be chased down to either remove an obscure driver or ungiantify it (along with a diff which pushes giant into the handler).

FWIW, I would like to use a similar approach with bus_setup_intr() to tag the ones that still need giant explicitly to make them easier to find.

I have no opinion about that code.

For sysctls, vast majority of handlers is already MPSAFE but not yet annotated as such and this is why I think the new flag does not add anything.

kaktus added a comment.Jan 15 2020, 11:09 AM
In D23110#508108, @lutz_donnerhacke.de wrote:

If it is only annotating something for a group of deverlopers, I'd suggest an inline comment in all the files.

It's hard to assert on a comment line.

kaktus updated this revision to Diff 66776.Jan 15 2020, 11:16 AM
kaktus edited the summary of this revision. (Show Details)
kaktus added a reviewer: x11.

Mark everything that was left since the last revision.

Add a static_assert to enforce one of the now required flags.

This diff was generated with -U20 as the full one is close to 37MB now, available at https://people.freebsd.org/~kaktus/sysctl.patch

Herald added a reviewer: slm. · View Herald TranscriptJan 15 2020, 11:16 AM
Herald added a reviewer: shurd. · View Herald Transcript
Herald added a reviewer: shurd. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added a reviewer: cy. · View Herald Transcript
Herald added a reviewer: iflib. · View Herald Transcript
Herald added a subscriber: farrokhi. · View Herald Transcript
kib added inline comments.Jan 15 2020, 12:40 PM
sys/sys/sysctl.h
272

Might be, use xor instead of or ?

360

Why string oids need Giant ?

763

Same q for opaque.

kaktus added a comment.Jan 15 2020, 1:03 PM

Because the write path in sysctl_handle_string() and sysctl_handle_opaque() isn't locked yet?

kib added a comment.Jan 15 2020, 5:23 PM
In D23110#508324, @kaktus wrote:

Because the write path in sysctl_handle_string() and sysctl_handle_opaque() isn't locked yet?

Are you sure that it makes any sense/difference ? Note that sysctl_new_in() is just copyin, so kernel fetches something user-controllable directly into the location.

Anyway, if you consider it is useful to add a locking there, do it in this patch, please.

kaktus updated this revision to Diff 66831.Jan 16 2020, 2:01 PM
kaktus edited the summary of this revision. (Show Details)

Regen.

Create macro to add MPSAFE flag for SYSCTL_NODEs that are not marked as NEEDGIANT instead of correcting every single entry.

Add locking to sysctl_handle_string() to handle writeable strings. Micro optimise and handle sysctl not marked as writeable as read-only regardless of not being set as CONST_STRING.

All writeable SYSCTL_STRINGs should be migrated to SYSCTL_PROCs and handle locking for their own instead of relying on default handler to protect the write path - to be done in other patches together with marking a lot of sysctls as MPSAFE already.

Mark SYSCTL_OPAQUE as MPSAFE.

Add a man page entry for sysctl(9).

Use xor in the static_assert.

kaktus added a reviewer: manpages.Jan 16 2020, 2:02 PM
kaktus updated this revision to Diff 66837.Jan 16 2020, 2:18 PM

Don't mark sysctl's that are already MPSAFE as NEEDGIANT.

bcr accepted this revision as: manpages.Jan 16 2020, 2:45 PM
bcr added a subscriber: bcr.

OK for the man page change.

kaktus updated this revision to Diff 66846.Jan 16 2020, 5:08 PM

Mark few more nodes.

kaktus updated this revision to Diff 66847.Jan 16 2020, 5:10 PM

Oops! Include proper diff.

asiciliano added a comment.Jan 16 2020, 10:08 PM

D23110#506589, @mjg wrote:
Also interested people can run dtrace to see what is taking giant at runtime on their boxes:

dtrace -n 'fbt::sysctl_root_handler_locked:entry /(args[0]->oid_kind & 0x00040000) == 0/ { @[stringof(args[0]->oid_name), args[0]->oid_descr[0] != 0 ? stringof(args[0]->oid_descr) : "NULL", sym((uintptr_t)args[0]->oid_handler)] = count(); }' -o out

sysctl -a > /dev/null

just a tip, easier and more precise because "sysctl -a" gets the "next leaf" while "nsysctl -aI" gets the "next leaf or next internal node":

nsysctl -aNGI | /usr/bin/grep -v MPSAFE
bjk added a subscriber: bjk.Jan 17 2020, 2:53 AM
bjk added inline comments.
share/man/man9/sysctl.9
887 ↗(On Diff #66847)

We should be more clear about whether this is a statement about the (unpreferred nature of the) internal implementation, or a requirement on callers that are querying this node.

kaktus added inline comments.Jan 17 2020, 10:14 AM
share/man/man9/sysctl.9
887 ↗(On Diff #66847)

How about

handler is not MP safe and locks Giant internally.

?

kib added a comment.Jan 17 2020, 1:15 PM

I want this to be split into three patches:

  1. sysctl infra: CTLFLAG_NEEDGIANT, related code, locking for strings, and empty definition of SYSCTL_ENFORCE_FLAGS()
  2. addition of NEEDGIANT for everything that should be marked as such
  3. proper definition of SYSCTL_ENFORCE_FLAGS

We can commit 1 shortly. Part 2 can be committed by pieces, e.g. after review of maintainers of touched subsystem if you feel the need of the review. Then finally we will turn the switch by 3, some time later.

sys/sys/sysctl.h
321

This MAYBE thing breaks the whole purpose of the work. You should end up with all nodes eother marked NEEDGIANT or MPSAFE, explicitly.

imp added inline comments.Jan 17 2020, 4:45 PM
sys/sys/sysctl.h
321

Agreed. At the end of this, things must either be marked NEEDGIANT or MPSAFE so the NEEDGIANT things can be fixed. maybe is hard to grep for :(

cem removed a reviewer: cem.Jan 17 2020, 4:58 PM
Herald added a reviewer: cem. · View Herald TranscriptJan 17 2020, 4:58 PM
cem removed a reviewer: cem.Jan 17 2020, 4:59 PM
kaktus added a comment.Jan 17 2020, 5:02 PM

OK, I'll cut it into smaller batches.

sys/sys/sysctl.h
321

Ack.
I wasn't happy about that either but for a moment it looked like a better alternative to changing 700 more files.

kaktus abandoned this revision.Feb 16 2020, 5:18 PM

This work has been split for several smaller batches: D23378, D23625 D23626 D23627 D23628 D23629 D23630 D23631 D23632 D23633 D23634 D23635 D23636 D23637 D23638 D23639 D23640, D23678 and D23718

Herald added a subscriber: melifaro. · View Herald TranscriptFeb 16 2020, 5:18 PM

Large Diff

This large diff affects 721 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
6 lines
12 lines
7 lines
6 lines
linux32/
2 lines
vmm/
amd/
23 lines
3 lines
3 lines
intel/
3 lines
7 lines
io/
3 lines
3 lines
3 lines
3 lines
10 lines
3 lines
arm/
allwinner/
2 lines
2 lines
3 lines
2 lines
4 lines
3 lines
altera/
socfpga/
15 lines
arm/
6 lines
6 lines
4 lines
3 lines
17 lines
broadcom/
bcm2835/
5 lines
20 lines
57 lines
5 lines
13 lines
50 lines
10 lines
30 lines
freescale/
imx/
23 lines
3 lines
mv/
10 lines
6 lines
nvidia/
tegra124/
3 lines
8 lines
ti/
am335x/
25 lines
5 lines
4 lines
cpsw/
40 lines
23 lines
26 lines
twl/
5 lines
5 lines
xilinx/
26 lines
3 lines
arm64/
arm64/
6 lines
8 lines
rockchip/
8 lines
cam/
ata/
20 lines
6 lines
3 lines
30 lines
ctl/
12 lines
4 lines
4 lines
2 lines
6 lines
nvme/
11 lines
scsi/
3 lines
8 lines
27 lines
4 lines
6 lines
5 lines
cddl/
compat/
opensolaris/
kern/
12 lines
contrib/
opensolaris/
uts/
common/
dtrace/
3 lines
fs/
zfs/
3 lines
3 lines
3 lines
3 lines
3 lines
3 lines
3 lines
3 lines
6 lines
3 lines
3 lines
dev/
dtrace/
6 lines
3 lines
profile/
3 lines
compat/
ia32/
3 lines
linux/
3 lines
linuxkpi/
common/
src/
6 lines
ndis/
3 lines
x86bios/
2 lines
contrib/
ipfilter/
netinet/
154 lines
rdma/
krping/
3 lines
crypto/
ccp/
3 lines
ddb/
11 lines
3 lines
18 lines
3 lines
dev/
aac/
3 lines
aacraid/
3 lines
acpi_support/
7 lines
4 lines
5 lines
6 lines
11 lines
8 lines
4 lines
4 lines
8 lines
11 lines
acpica/
42 lines
6 lines
14 lines
36 lines
4 lines
4 lines
3 lines
79 lines
6 lines
30 lines
adb/
5 lines
5 lines
ae/
6 lines
age/
14 lines
ahci/
3 lines
aic7xxx/
34 lines
alc/
28 lines
ale/
29 lines
altera/
atse/
6 lines
jtag_uart/
3 lines
amd_ecc_inject/
18 lines
amdtemp/
20 lines
amr/
3 lines
an/
14 lines
asmc/
47 lines
ata/
3 lines
ath/
11 lines
ath_rate/
sample/
12 lines
137 lines
atkbdc/
304 lines
bce/
111 lines
bfe/
5 lines
bge/
36 lines
bhnd/
cores/
pmu/
15 lines
bktr/
3 lines
bnxt/
141 lines
bwn/
2 lines
bxe/
37 lines
cadence/
5 lines
cardbus/
3 lines
coretemp/
3 lines
cxgb/
3 lines
53 lines
cxgbe/
crypto/
5 lines
cxgbei/
5 lines
3 lines
iw_cxgbe/
3 lines
428 lines
113 lines
dcons/
3 lines
drm2/
3 lines
8 lines
e1000/
86 lines
efidev/
3 lines
ena/
28 lines
et/
21 lines
etherswitch/
mtkswitch/
3 lines
rtl8366/
3 lines
evdev/
8 lines
extres/
clk/
32 lines
regulator/
11 lines
fb/
3 lines
fdc/
3 lines
fdt/
3 lines
firewire/
3 lines
4 lines
4 lines
4 lines
4 lines
fxp/
21 lines
gpio/
5 lines
hifn/
4 lines
hptmv/
6 lines
hwpmc/
8 lines
hyperv/
netvsc/
12 lines
if_ndis/
3 lines
iicbus/
13 lines
10 lines
33 lines
27 lines
7 lines
6 lines
13 lines
ioat/
21 lines
3 lines
ipmi/
2 lines
ipw/
6 lines
isci/
30 lines
iscsi/
3 lines
3 lines
iscsi_initiator/
40 lines
10 lines
iser/
3 lines
isl/
34 lines
isp/
8 lines
iwi/
11 lines
ixgbe/
54 lines
79 lines
12 lines
ixl/
40 lines
2 lines
189 lines
8 lines
jme/
39 lines
kbd/
3 lines
liquidio/
91 lines
malo/
2 lines
2 lines
mfi/
3 lines
mge/
12 lines
mlx4/
mlx4_core/
3 lines
mlx4_en/
23 lines
mlx5/
mlx5_core/
9 lines
mlx5_en/
18 lines
3 lines
23 lines
5 lines
mlx5_ib/
12 lines
mmc/
3 lines
3 lines
mpr/
11 lines
mps/
23 lines
mpt/
18 lines
mrsas/
5 lines
msk/
24 lines
mwl/
8 lines
2 lines
mxge/
140 lines
neta/
22 lines
netmap/
3 lines
nfe/
17 lines
nge/
23 lines
ntb/
if_ntb/
3 lines
3 lines
ntb_hw/
223 lines
4 lines
test/
3 lines
nvd/
3 lines
nvme/
39 lines
oce/
81 lines
ocs_fc/
67 lines
ofw/
3 lines
otus/
3 lines
ow/
11 lines
7 lines
pccard/
3 lines
pccbb/
3 lines
3 lines
pci/
3 lines
puc/
3 lines
qlnx/
qlnxe/
40 lines
qlnxr/
3 lines
qlxgb/
9 lines
qlxgbe/
80 lines
9 lines
qlxge/
18 lines
9 lines
random/
16 lines
2 lines
16 lines
5 lines
re/
8 lines
rndtest/
2 lines
safe/
8 lines
sdhci/
3 lines
sfxge/
24 lines
34 lines
35 lines
15 lines
29 lines
sk/
9 lines
sound/
3 lines
midi/
6 lines
3 lines
pci/
5 lines
16 lines
19 lines
hda/
5 lines
10 lines
3 lines
12 lines
pcm/
7 lines
35 lines
9 lines
12 lines
6 lines
6 lines
38 lines
50 lines
usb/
21 lines
ste/
15 lines
stge/
10 lines
syscons/
7 lines
tsec/
23 lines
twa/
5 lines
twe/
3 lines
tws/
6 lines
uart/
3 lines
ubsec/
2 lines
usb/
controller/
2 lines
3 lines
3 lines
3 lines
3 lines
3 lines
2 lines
3 lines
3 lines
2 lines
3 lines
gadget/
3 lines
4 lines
3 lines
3 lines
input/
9 lines
3 lines
3 lines
3 lines
10 lines
2 lines
3 lines
misc/
3 lines
3 lines
net/
3 lines
3 lines
3 lines
3 lines
3 lines
3 lines
3 lines
3 lines
3 lines
2 lines
3 lines
3 lines
3 lines
3 lines
3 lines
3 lines
15 lines
11 lines
serial/
3 lines
3 lines
3 lines
3 lines
16 lines
3 lines
3 lines
3 lines
3 lines
3 lines
3 lines
3 lines
3 lines
3 lines
3 lines
storage/
2 lines
3 lines
3 lines
3 lines
template/
2 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
66 lines
3 lines
3 lines
3 lines
17 lines
3 lines
video/
3 lines
wlan/
3 lines
3 lines
3 lines
8 lines
7 lines
3 lines
13 lines
3 lines
vge/
15 lines
virtio/
block/
5 lines
network/
9 lines
vmware/
pvscsi/
2 lines
vmxnet3/
26 lines
vr/
5 lines
vt/
3 lines
vte/
25 lines
watchdog/
3 lines
wbwd/
14 lines
wi/
4 lines
xen/
balloon/
4 lines
blkfront/
8 lines
netback/
26 lines
xenstore/
3 lines
fs/
autofs/
3 lines
cd9660/
3 lines
devfs/
3 lines
ext2fs/
3 lines
3 lines
fuse/
6 lines
msdosfs/
3 lines
nfs/
3 lines
nfsclient/
10 lines
nfsserver/
5 lines
3 lines
pseudofs/
2 lines
2 lines
smbfs/
3 lines
tmpfs/
3 lines
gdb/
3 lines
2 lines
geom/
cache/
14 lines
concat/
2 lines
eli/
3 lines
gate/
2 lines
3 lines
12 lines
30 lines
journal/
18 lines
label/
5 lines
3 lines
linux_lvm/
2 lines
mirror/
2 lines
mountver/
5 lines
multipath/
3 lines
nop/
3 lines
part/
2 lines
3 lines
3 lines
3 lines
raid/
10 lines
3 lines
raid3/
6 lines
shsec/
3 lines
stripe/
8 lines
uzip/
3 lines
vinum/
2 lines
virstor/
3 lines
zero/
8 lines
gnu/
gcov/
14 lines
i386/
i386/
12 lines
42 lines
6 lines
6 lines
5 lines
6 lines
kern/
2 lines
6 lines
3 lines
2 lines
13 lines
19 lines
10 lines
6 lines
10 lines
6 lines
12 lines
6 lines
3 lines
29 lines
6 lines
6 lines
5 lines
25 lines
85 lines
6 lines
3 lines
3 lines
29 lines
3 lines
7 lines
3 lines
15 lines
2 lines
6 lines
13 lines
12 lines
9 lines
3 lines
10 lines
35 lines
2 lines
10 lines
6 lines
9 lines
6 lines
36 lines
8 lines
6 lines
40 lines
27 lines
3 lines
4 lines
3 lines
3 lines
24 lines
3 lines
5 lines
8 lines
26 lines
2 lines
3 lines
10 lines
14 lines
2 lines
6 lines
11 lines
21 lines
2 lines
5 lines
libkern/
21 lines
mips/
atheros/
ar531x/
5 lines
3 lines
cavium/
octe/
19 lines
3 lines
usb/
3 lines
ingenic/
3 lines
mips/
6 lines
3 lines
3 lines
nlm/
6 lines
dev/
net/
5 lines
3 lines
net/
3 lines
3 lines
2 lines
3 lines
6 lines
6 lines
9 lines
6 lines
9 lines
2 lines
2 lines
2 lines
2 lines
10 lines
3 lines
6 lines
11 lines
36 lines
6 lines
2 lines
6 lines
8 lines
6 lines
3 lines
net80211/
6 lines
5 lines
46 lines
21 lines
30 lines
17 lines
6 lines
7 lines
netgraph/
bluetooth/
common/
51 lines
socket/
20 lines
5 lines
5 lines
5 lines
5 lines
5 lines
9 lines
2 lines
3 lines
3 lines
7 lines
netinet/
5 lines
cc/
10 lines
13 lines
21 lines
21 lines
17 lines
5 lines
15 lines
7 lines
8 lines
2 lines
35 lines
42 lines
11 lines
9 lines
4 lines
14 lines
8 lines
5 lines
libalias/
3 lines
72 lines
netdump/
8 lines
5 lines
47 lines
6 lines
13 lines
35 lines
13 lines
12 lines
4 lines
3 lines
33 lines
6 lines
3 lines
tcp_stacks/
34 lines
10 lines
5 lines
52 lines
5 lines
54 lines
3 lines
10 lines
netinet6/
4 lines
3 lines
26 lines
3 lines
6 lines
7 lines
2 lines
7 lines
6 lines
netipsec/
6 lines
3 lines
3 lines
netpfil/
ipfw/
15 lines
41 lines
13 lines
37 lines
22 lines
11 lines
15 lines
12 lines
nat64/
3 lines
pf/
3 lines
3 lines
netsmb/
9 lines
nfs/
6 lines
nlm/
19 lines
ofed/
drivers/
infiniband/
ulp/
sdp/
6 lines
opencrypto/
3 lines
powerpc/
fpu/
3 lines
ofw/
3 lines
powermac/
5 lines
35 lines
5 lines
85 lines
25 lines
powernv/
13 lines
powerpc/
3 lines
3 lines
ps3/
7 lines
riscv/
riscv/
6 lines
4 lines
rpc/
rpcsec_gss/
6 lines
6 lines
security/
audit/
2 lines
mac/
2 lines
mac_biba/
3 lines
mac_bsdextended/
3 lines
mac_ifoff/
3 lines
mac_lomac/
3 lines
mac_mls/
3 lines
mac_ntpd/
3 lines
mac_partition/
3 lines
mac_portacl/
7 lines
mac_seeotheruids/
3 lines
mac_stub/
3 lines
mac_test/
6 lines
mac_veriexec/
8 lines
3 lines
sparc64/
pci/
3 lines
sparc64/
3 lines
3 lines
3 lines
sys/
6 lines
39 lines
tests/
epoch/
9 lines
framework/
9 lines
ufs/
ffs/
88 lines
14 lines
ufs/
3 lines
3 lines
vm/
3 lines
3 lines
3 lines
32 lines
23 lines
2 lines
2 lines
2 lines
18 lines
9 lines
x86/
bios/
31 lines
iommu/
3 lines
isa/
3 lines
x86/
5 lines
26 lines
6 lines
3 lines
5 lines
6 lines
3 lines
6 lines
xen/
xenbus/
65 lines

Diff 66776

View Options

sys/amd64/amd64/efirt_machdep.c

View Options

sys/amd64/amd64/machdep.c

View Options

sys/amd64/amd64/pmap.c

View Options

sys/amd64/amd64/prof_machdep.c

View Options

sys/amd64/linux32/linux32_sysvec.c

View Options

sys/amd64/vmm/amd/amdvi_hw.c

View Options

sys/amd64/vmm/amd/npt.c

View Options

sys/amd64/vmm/amd/svm.c

View Options

sys/amd64/vmm/intel/ept.c

View Options

sys/amd64/vmm/intel/vmx.c

View Options

sys/amd64/vmm/io/iommu.c

View Options

sys/amd64/vmm/io/ppt.c

View Options

sys/amd64/vmm/io/vrtc.c

View Options

sys/amd64/vmm/vmm.c

View Options

sys/amd64/vmm/vmm_dev.c

View Options

sys/amd64/vmm/x86.c

View Options

sys/arm/allwinner/aw_sid.c

View Options

sys/arm/allwinner/aw_thermal.c

View Options

sys/arm/allwinner/aw_ts.c

View Options

sys/arm/allwinner/axp209.c

View Options

sys/arm/allwinner/axp81x.c

View Options

sys/arm/allwinner/if_emac.c

View Options

sys/arm/altera/socfpga/socfpga_rstmgr.c

View Options

sys/arm/arm/busdma_machdep-v4.c

View Options

sys/arm/arm/busdma_machdep-v6.c

View Options

sys/arm/arm/cpuinfo.c

View Options

sys/arm/arm/machdep_boot.c

View Options

sys/arm/arm/pmap-v6.c

View Options

sys/arm/broadcom/bcm2835/bcm2835_audio.c

View Options

sys/arm/broadcom/bcm2835/bcm2835_bsc.c

View Options

sys/arm/broadcom/bcm2835/bcm2835_cpufreq.c

View Options

sys/arm/broadcom/bcm2835/bcm2835_fbd.c

View Options

sys/arm/broadcom/bcm2835/bcm2835_gpio.c

View Options

sys/arm/broadcom/bcm2835/bcm2835_pwm.c

View Options

sys/arm/broadcom/bcm2835/bcm2835_rng.c

View Options

sys/arm/broadcom/bcm2835/bcm2835_spi.c

View Options

sys/arm/freescale/imx/imx6_anatop.c

View Options

sys/arm/freescale/imx/imx_machdep.c

View Options

sys/arm/mv/mv_thermal.c

View Options

sys/arm/mv/mv_ts.c

View Options

sys/arm/nvidia/tegra124/tegra124_coretemp.c

View Options

sys/arm/nvidia/tegra_soctherm.c

View Options

sys/arm/ti/am335x/am335x_ehrpwm.c

View Options

sys/arm/ti/am335x/am335x_lcd.c

View Options

sys/arm/ti/am335x/am335x_musb.c

View Options

sys/arm/ti/cpsw/if_cpsw.c

View Options

sys/arm/ti/ti_adc.c

View Options

sys/arm/ti/ti_pruss.c

View Options

sys/arm/ti/twl/twl_clks.c

View Options

sys/arm/ti/twl/twl_vreg.c

View Options

sys/arm/xilinx/zy7_devcfg.c

View Options

sys/arm/xilinx/zy7_slcr.c

View Options

sys/arm64/arm64/busdma_bounce.c

View Options

sys/arm64/arm64/pmap.c

View Options

sys/arm64/rockchip/rk_tsadc.c

View Options

sys/cam/ata/ata_da.c

View Options

sys/cam/ata/ata_pmp.c

View Options

sys/cam/cam_iosched.c

View Options

sys/cam/ctl/ctl.c

View Options

sys/cam/ctl/ctl_backend_block.c

View Options

sys/cam/ctl/ctl_frontend_cam_sim.c

View Options

sys/cam/ctl/ctl_frontend_iscsi.c

View Options

sys/cam/ctl/ctl_ha.c

View Options

sys/cam/nvme/nvme_da.c

View Options

sys/cam/scsi/scsi_all.c

View Options

sys/cam/scsi/scsi_cd.c

View Options

sys/cam/scsi/scsi_da.c

View Options

sys/cam/scsi/scsi_enc.c

View Options

sys/cam/scsi/scsi_sa.c

View Options

sys/cam/scsi/scsi_xpt.c

View Options

sys/cddl/compat/opensolaris/kern/opensolaris_kstat.c

View Options

sys/cddl/contrib/opensolaris/uts/common/dtrace/fasttrap.c

View Options

sys/cddl/contrib/opensolaris/uts/common/fs/zfs/ddt.c

View Options

sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_zfetch.c

View Options

sys/cddl/contrib/opensolaris/uts/common/fs/zfs/metaslab.c

View Options

sys/cddl/contrib/opensolaris/uts/common/fs/zfs/trim_map.c

View Options

sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c

View Options

sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev.c

View Options

sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_cache.c

View Options

sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_mirror.c

View Options

sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vfsops.c

View Options

sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zio.c

View Options

sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zvol.c

View Options

sys/cddl/dev/dtrace/dtrace_sysctl.c

View Options

sys/cddl/dev/dtrace/dtrace_test.c

View Options

sys/cddl/dev/profile/profile.c

View Options

sys/compat/ia32/ia32_sysvec.c

View Options

sys/compat/linux/linux_mib.c

View Options

sys/compat/linuxkpi/common/src/linux_compat.c

View Options

sys/compat/ndis/subr_ntoskrnl.c

View Options

sys/compat/x86bios/x86bios.c

View Options

sys/contrib/ipfilter/netinet/mlfk_ipl.c

View Options

sys/contrib/rdma/krping/krping_dev.c

View Options

sys/crypto/ccp/ccp_hardware.c

View Options

sys/ddb/db_capture.c

View Options

sys/ddb/db_main.c

View Options

sys/ddb/db_script.c

View Options

sys/ddb/db_textdump.c

View Options

sys/dev/aac/aac.c

View Options

sys/dev/aacraid/aacraid.c

View Options

sys/dev/acpi_support/acpi_asus.c

View Options

sys/dev/acpi_support/acpi_asus_wmi.c

View Options

sys/dev/acpi_support/acpi_fujitsu.c

View Options

sys/dev/acpi_support/acpi_hp.c

View Options

sys/dev/acpi_support/acpi_ibm.c

View Options

sys/dev/acpi_support/acpi_panasonic.c

View Options

sys/dev/acpi_support/acpi_rapidstart.c

View Options

sys/dev/acpi_support/acpi_sony.c

View Options

sys/dev/acpi_support/acpi_toshiba.c

View Options

sys/dev/acpi_support/atk0110.c

View Options

sys/dev/acpica/acpi.c

View Options

sys/dev/acpica/acpi_acad.c

View Options

sys/dev/acpica/acpi_battery.c

View Options

sys/dev/acpica/acpi_cpu.c

View Options

sys/dev/acpica/acpi_dock.c

View Options

sys/dev/acpica/acpi_ec.c

View Options

sys/dev/acpica/acpi_smbat.c

View Options

sys/dev/acpica/acpi_thermal.c

View Options

sys/dev/acpica/acpi_timer.c

View Options

sys/dev/acpica/acpi_video.c

View Options

sys/dev/adb/adb_kbd.c

View Options

sys/dev/adb/adb_mouse.c

View Options

sys/dev/ae/if_ae.c

View Options

sys/dev/age/if_age.c

View Options

sys/dev/ahci/ahci.c

View Options

sys/dev/aic7xxx/aic79xx_osm.c

View Options

sys/dev/alc/if_alc.c

View Options

sys/dev/ale/if_ale.c

View Options

sys/dev/altera/atse/if_atse.c

View Options

sys/dev/altera/jtag_uart/altera_jtag_uart_cons.c

View Options

sys/dev/amd_ecc_inject/ecc_inject.c

View Options

sys/dev/amdtemp/amdtemp.c

View Options

sys/dev/amr/amr.c

View Options

sys/dev/an/if_an.c

View Options

sys/dev/asmc/asmc.c

View Options

sys/dev/ata/ata-all.c

View Options

sys/dev/ath/ah_osdep.c

View Options

sys/dev/ath/ath_rate/sample/sample.c

View Options

sys/dev/ath/if_ath_sysctl.c

View Options

sys/dev/atkbdc/psm.c

View Options

sys/dev/bce/if_bce.c

View Options

sys/dev/bfe/if_bfe.c

View Options

sys/dev/bge/if_bge.c

View Options

sys/dev/bhnd/cores/pmu/bhnd_pmu.c

View Options

sys/dev/bktr/bktr_os.c

View Options

sys/dev/bnxt/bnxt_sysctl.c

View Options

sys/dev/bwn/if_bwn.c

View Options

sys/dev/bxe/bxe.c

View Options

sys/dev/cadence/if_cgem.c

View Options

sys/dev/cardbus/cardbus.c

View Options

sys/dev/coretemp/coretemp.c

View Options

sys/dev/cxgb/cxgb_main.c

View Options

sys/dev/cxgb/cxgb_sge.c

View Options

sys/dev/cxgbe/crypto/t4_crypto.c

View Options

sys/dev/cxgbe/cxgbei/cxgbei.c

View Options

sys/dev/cxgbe/cxgbei/icl_cxgbei.c

View Options

sys/dev/cxgbe/iw_cxgbe/cm.c

View Options

sys/dev/cxgbe/t4_main.c

View Options

sys/dev/cxgbe/t4_sge.c

View Options

sys/dev/dcons/dcons_os.c

View Options

sys/dev/drm2/drm_pci.c

View Options

sys/dev/drm2/drm_sysctl.c

View Options

sys/dev/e1000/if_em.c

View Options

sys/dev/efidev/efirt.c

View Options

sys/dev/ena/ena_sysctl.c

View Options

sys/dev/et/if_et.c

View Options

sys/dev/etherswitch/mtkswitch/mtkswitch.c

View Options

sys/dev/etherswitch/rtl8366/rtl8366rb.c

View Options

sys/dev/evdev/evdev.c

View Options

sys/dev/extres/clk/clk.c

View Options

sys/dev/extres/regulator/regulator.c

View Options

sys/dev/fb/vesa.c

View Options

sys/dev/fdc/fdc.c

View Options

sys/dev/fdt/fdt_common.c

View Options

sys/dev/firewire/firewire.c

View Options

sys/dev/firewire/fwmem.c

View Options

sys/dev/firewire/if_fwe.c

View Options

sys/dev/firewire/if_fwip.c

View Options

sys/dev/firewire/sbp.c

View Options

sys/dev/fxp/if_fxp.c

View Options

sys/dev/gpio/gpiobacklight.c

View Options

sys/dev/hifn/hifn7751.c

View Options

sys/dev/hptmv/hptproc.c

View Options

sys/dev/hwpmc/hwpmc_mod.c

View Options

sys/dev/hyperv/netvsc/if_hn.c

View Options

sys/dev/if_ndis/if_ndis_usb.c

View Options

sys/dev/iicbus/ad7417.c

View Options

sys/dev/iicbus/ad7418.c

View Options

sys/dev/iicbus/ads111x.c

View Options

sys/dev/iicbus/adt746x.c

View Options

sys/dev/iicbus/ds1631.c

View Options

sys/dev/iicbus/ds1775.c

View Options

sys/dev/iicbus/max6690.c

View Options

sys/dev/ioat/ioat.c

View Options

sys/dev/ioat/ioat_test.c

View Options

sys/dev/ipmi/ipmi.c

View Options

sys/dev/ipw/if_ipw.c

View Options

sys/dev/isci/isci_sysctl.c

View Options

sys/dev/iscsi/icl.c

View Options

sys/dev/iscsi/iscsi.c

View Options

sys/dev/iscsi_initiator/isc_sm.c

View Options

sys/dev/iscsi_initiator/iscsi.c

View Options

sys/dev/iser/icl_iser.c

View Options

sys/dev/isl/isl.c

View Options

sys/dev/isp/isp_freebsd.c

View Options

sys/dev/iwi/if_iwi.c

View Options

sys/dev/ixgbe/if_bypass.c

View Options

sys/dev/ixgbe/if_ix.c

View Options

sys/dev/ixgbe/if_ixv.c

View Options

sys/dev/ixl/if_iavf.c

View Options

sys/dev/ixl/if_ixl.c

View Options

sys/dev/ixl/ixl_pf_main.c

View Options

sys/dev/ixl/ixl_txrx.c

View Options

sys/dev/jme/if_jme.c

View Options

sys/dev/kbd/kbd.c

View Options

sys/dev/liquidio/lio_sysctl.c

View Options

sys/dev/malo/if_malo.c

View Options

sys/dev/malo/if_malo_pci.c

View Options

sys/dev/mfi/mfi.c

View Options

sys/dev/mge/if_mge.c

View Options

sys/dev/mlx4/mlx4_core/mlx4_main.c

View Options

sys/dev/mlx4/mlx4_en/mlx4_en_netdev.c

View Options

sys/dev/mlx5/mlx5_core/mlx5_main.c

View Options

sys/dev/mlx5/mlx5_en/mlx5_en_ethtool.c

View Options

sys/dev/mlx5/mlx5_en/mlx5_en_hw_tls.c

View Options

sys/dev/mlx5/mlx5_en/mlx5_en_main.c

View Options

sys/dev/mlx5/mlx5_en/mlx5_en_rl.c

View Options

sys/dev/mlx5/mlx5_ib/mlx5_ib_cong.c

View Options

sys/dev/mmc/mmc.c

View Options

sys/dev/mmc/mmcsd.c

View Options

sys/dev/mpr/mpr.c

View Options

sys/dev/mps/mps.c

View Options

sys/dev/mpt/mpt_raid.c

View Options

sys/dev/mrsas/mrsas.c

View Options

sys/dev/msk/if_msk.c

View Options

sys/dev/mwl/if_mwl.c

View Options

sys/dev/mwl/mwlhal.c

View Options

sys/dev/mxge/if_mxge.c

View Options

sys/dev/neta/if_mvneta.c

View Options

sys/dev/netmap/netmap.c

View Options

sys/dev/nfe/if_nfe.c

View Options

sys/dev/nge/if_nge.c

View Options

sys/dev/ntb/if_ntb/if_ntb.c

View Options

sys/dev/ntb/ntb.c

View Options

sys/dev/ntb/ntb_hw/ntb_hw_intel.c

View Options

sys/dev/ntb/ntb_transport.c

View Options

sys/dev/ntb/test/ntb_tool.c

View Options

sys/dev/nvd/nvd.c

View Options

sys/dev/nvme/nvme_sysctl.c

View Options

sys/dev/oce/oce_sysctl.c

View Options

sys/dev/ocs_fc/ocs_ioctl.c

View Options

sys/dev/ofw/ofw_fdt.c

View Options

sys/dev/otus/if_otus.c

View Options

sys/dev/ow/ow.c

View Options

sys/dev/ow/ow_temp.c

View Options

sys/dev/pccard/pccard.c

View Options

sys/dev/pccbb/pccbb.c

View Options

sys/dev/pccbb/pccbb_isa.c

View Options

sys/dev/pci/pci.c

View Options

sys/dev/puc/puc.c

View Options

sys/dev/qlnx/qlnxe/qlnx_os.c

View Options

sys/dev/qlnx/qlnxr/qlnxr_os.c

View Options

sys/dev/qlxgb/qla_os.c

View Options

sys/dev/qlxgbe/ql_hw.c

View Options

sys/dev/qlxgbe/ql_os.c

View Options

sys/dev/qlxge/qls_hw.c

View Options

sys/dev/qlxge/qls_os.c

View Options

sys/dev/random/fortuna.c

View Options

sys/dev/random/ivy.c

View Options

sys/dev/random/random_harvestq.c

View Options

sys/dev/random/random_infra.c

View Options

sys/dev/re/if_re.c

View Options

sys/dev/rndtest/rndtest.c

View Options

sys/dev/safe/safe.c

View Options

sys/dev/sdhci/sdhci.c

View Options

sys/dev/sfxge/sfxge.c

View Options

sys/dev/sfxge/sfxge_ev.c

View Options

sys/dev/sfxge/sfxge_port.c

View Options

sys/dev/sfxge/sfxge_rx.c

View Options

sys/dev/sfxge/sfxge_tx.c

View Options

sys/dev/sk/if_sk.c

View Options

sys/dev/sound/clone.c

View Options

sys/dev/sound/midi/midi.c

View Options

sys/dev/sound/midi/sequencer.c

View Options

sys/dev/sound/pci/atiixp.c

View Options

sys/dev/sound/pci/emu10kx.c

View Options

sys/dev/sound/pci/es137x.c

View Options

sys/dev/sound/pci/hda/hdaa.c

View Options

sys/dev/sound/pci/hda/hdac.c

View Options

sys/dev/sound/pci/maestro.c

View Options

sys/dev/sound/pci/via8233.c

View Options

sys/dev/sound/pcm/ac97.c

View Options

sys/dev/sound/pcm/channel.c

View Options

sys/dev/sound/pcm/feeder_eq.c

View Options

sys/dev/sound/pcm/feeder_rate.c

View Options

sys/dev/sound/pcm/mixer.c

View Options

sys/dev/sound/pcm/sndstat.c

View Options

sys/dev/sound/pcm/sound.c

View Options

sys/dev/sound/pcm/vchan.c

View Options

sys/dev/sound/usb/uaudio.c

View Options

sys/dev/ste/if_ste.c

View Options

sys/dev/stge/if_stge.c

View Options

sys/dev/syscons/syscons.c

View Options

sys/dev/tsec/if_tsec.c

View Options

sys/dev/twa/tw_osl_freebsd.c

View Options

sys/dev/twe/twe_freebsd.c

View Options

sys/dev/tws/tws.c

View Options

sys/dev/uart/uart_core.c

View Options

sys/dev/ubsec/ubsec.c

View Options

sys/dev/usb/controller/atmegadci.c

View Options

sys/dev/usb/controller/avr32dci.c

View Options

sys/dev/usb/controller/dwc_otg.c

View Options

sys/dev/usb/controller/ehci.c

View Options

sys/dev/usb/controller/musb_otg.c

View Options

sys/dev/usb/controller/ohci.c

View Options

sys/dev/usb/controller/saf1761_otg.c

View Options

sys/dev/usb/controller/uhci.c

View Options

sys/dev/usb/controller/usb_controller.c

View Options

sys/dev/usb/controller/uss820dci.c

View Options

sys/dev/usb/controller/xhci.c

View Options

sys/dev/usb/gadget/g_audio.c

View Options

sys/dev/usb/gadget/g_keyboard.c

View Options

sys/dev/usb/gadget/g_modem.c

View Options

sys/dev/usb/gadget/g_mouse.c

View Options

sys/dev/usb/input/atp.c

View Options

sys/dev/usb/input/uep.c

View Options

sys/dev/usb/input/uhid.c

View Options

sys/dev/usb/input/ukbd.c

View Options

sys/dev/usb/input/ums.c

View Options

sys/dev/usb/input/wmt.c

View Options

sys/dev/usb/input/wsp.c

View Options

sys/dev/usb/misc/udbp.c

View Options

sys/dev/usb/misc/ugold.c

View Options

sys/dev/usb/net/if_aue.c

View Options

sys/dev/usb/net/if_axe.c

View Options

sys/dev/usb/net/if_axge.c

View Options

sys/dev/usb/net/if_cdce.c

View Options

sys/dev/usb/net/if_cdceem.c

View Options

sys/dev/usb/net/if_cue.c

View Options

sys/dev/usb/net/if_ipheth.c

View Options

sys/dev/usb/net/if_kue.c

View Options

sys/dev/usb/net/if_mos.c

View Options

sys/dev/usb/net/if_muge.c

View Options

sys/dev/usb/net/if_rue.c

View Options

sys/dev/usb/net/if_smsc.c

View Options

sys/dev/usb/net/if_udav.c

View Options

sys/dev/usb/net/if_ure.c

View Options

sys/dev/usb/net/if_urndis.c

View Options

sys/dev/usb/net/if_usie.c

View Options

sys/dev/usb/net/uhso.c

View Options

sys/dev/usb/net/usb_ethernet.c

View Options

sys/dev/usb/serial/u3g.c

View Options

sys/dev/usb/serial/ubsa.c

View Options

sys/dev/usb/serial/ubser.c

View Options

sys/dev/usb/serial/uchcom.c

View Options

sys/dev/usb/serial/ufoma.c

View Options

sys/dev/usb/serial/uftdi.c

View Options

sys/dev/usb/serial/ulpt.c

View Options

sys/dev/usb/serial/umcs.c

View Options

sys/dev/usb/serial/umodem.c

View Options

sys/dev/usb/serial/umoscom.c

View Options

sys/dev/usb/serial/uplcom.c

View Options

sys/dev/usb/serial/usb_serial.c

View Options

sys/dev/usb/serial/uslcom.c

View Options

sys/dev/usb/serial/uvisor.c

View Options

sys/dev/usb/serial/uvscom.c

View Options

sys/dev/usb/storage/cfumass.c

View Options

sys/dev/usb/storage/umass.c

View Options

sys/dev/usb/storage/urio.c

View Options

sys/dev/usb/storage/ustorage_fs.c

View Options

sys/dev/usb/template/usb_template.c

View Options

sys/dev/usb/template/usb_template_audio.c

View Options

sys/dev/usb/template/usb_template_cdce.c

View Options

sys/dev/usb/template/usb_template_cdceem.c

View Options

sys/dev/usb/template/usb_template_kbd.c

View Options

sys/dev/usb/template/usb_template_midi.c

View Options

sys/dev/usb/template/usb_template_modem.c

View Options

sys/dev/usb/template/usb_template_mouse.c

View Options

sys/dev/usb/template/usb_template_msc.c

View Options

sys/dev/usb/template/usb_template_mtp.c

View Options

sys/dev/usb/template/usb_template_multi.c

View Options

sys/dev/usb/template/usb_template_phone.c

View Options

sys/dev/usb/template/usb_template_serialnet.c

View Options

sys/dev/usb/usb_debug.c

View Options

sys/dev/usb/usb_dev.c

View Options

sys/dev/usb/usb_generic.c

View Options

sys/dev/usb/usb_hub.c

View Options

sys/dev/usb/usb_hub_acpi.c

View Options

sys/dev/usb/usb_process.c

View Options

sys/dev/usb/video/udl.c

View Options

sys/dev/usb/wlan/if_rsu.c

View Options

sys/dev/usb/wlan/if_rum.c

View Options

sys/dev/usb/wlan/if_run.c

View Options

sys/dev/usb/wlan/if_uath.c

View Options

sys/dev/usb/wlan/if_upgt.c

View Options

sys/dev/usb/wlan/if_ural.c

View Options

sys/dev/usb/wlan/if_urtw.c

View Options

sys/dev/usb/wlan/if_zyd.c

View Options

sys/dev/vge/if_vge.c

View Options

sys/dev/virtio/block/virtio_blk.c

View Options

sys/dev/virtio/network/if_vtnet.c

View Options

sys/dev/vmware/pvscsi/pvscsi.c

View Options

sys/dev/vmware/vmxnet3/if_vmx.c

View Options

sys/dev/vr/if_vr.c

View Options

sys/dev/vt/vt_core.c

View Options

sys/dev/vte/if_vte.c

View Options

sys/dev/watchdog/watchdog.c

View Options

sys/dev/wbwd/wbwd.c

View Options

sys/dev/wi/if_wi.c

View Options

sys/dev/xen/balloon/balloon.c

View Options

sys/dev/xen/blkfront/blkfront.c

View Options

sys/dev/xen/netback/netback.c

View Options

sys/dev/xen/xenstore/xenstore.c

View Options

sys/fs/autofs/autofs.c

View Options

sys/fs/cd9660/cd9660_vnops.c

View Options

sys/fs/devfs/devfs_devs.c

View Options

sys/fs/ext2fs/ext2_alloc.c

View Options

sys/fs/ext2fs/ext2_lookup.c

View Options

sys/fs/fuse/fuse_main.c

View Options

sys/fs/msdosfs/msdosfs_vnops.c

View Options

sys/fs/nfs/nfs_commonport.c

View Options

sys/fs/nfsclient/nfs_clnfsiod.c

View Options

sys/fs/nfsserver/nfs_fha_new.c

View Options

sys/fs/nfsserver/nfs_nfsdport.c

View Options

sys/fs/pseudofs/pseudofs.c

View Options

sys/fs/pseudofs/pseudofs_vncache.c

View Options

sys/fs/smbfs/smbfs_vfsops.c

View Options

sys/fs/tmpfs/tmpfs_subr.c

View Options

sys/gdb/gdb_main.c

View Options

sys/gdb/netgdb.c

View Options

sys/geom/cache/g_cache.c

View Options

sys/geom/concat/g_concat.c

View Options

sys/geom/eli/g_eli.c

View Options

sys/geom/gate/g_gate.c

View Options

sys/geom/geom_dev.c

View Options

sys/geom/geom_disk.c

View Options

sys/geom/geom_kern.c

View Options

sys/geom/journal/g_journal.c

View Options

sys/geom/label/g_label.h

View Options

sys/geom/label/g_label.c

View Options

sys/geom/linux_lvm/g_linux_lvm.c

View Options

sys/geom/mirror/g_mirror.c

View Options

sys/geom/mountver/g_mountver.c

View Options

sys/geom/multipath/g_multipath.c

View Options

sys/geom/nop/g_nop.c

View Options

sys/geom/part/g_part.c

View Options

sys/geom/part/g_part_gpt.c

View Options

sys/geom/part/g_part_ldm.c

View Options

sys/geom/part/g_part_mbr.c

View Options

sys/geom/raid/g_raid.h

View Options

sys/geom/raid/g_raid.c

View Options

sys/geom/raid3/g_raid3.c

View Options

sys/geom/shsec/g_shsec.c

View Options

sys/geom/stripe/g_stripe.c

View Options

sys/geom/uzip/g_uzip.c

View Options

sys/geom/vinum/geom_vinum.c

View Options

sys/geom/virstor/g_virstor.c

View Options

sys/geom/zero/g_zero.c

View Options

sys/gnu/gcov/gcov_subr.c

View Options

sys/i386/i386/elan-mmcr.c

View Options

sys/i386/i386/longrun.c

View Options

sys/i386/i386/machdep.c

View Options

sys/i386/i386/mp_clock.c

View Options

sys/i386/i386/pmap_base.c

View Options

sys/i386/i386/prof_machdep.c

View Options

sys/kern/imgact_binmisc.c

View Options

sys/kern/imgact_elf.c

View Options

sys/kern/kern_acct.c

View Options

sys/kern/kern_clock.c

View Options

sys/kern/kern_cons.c

View Options

sys/kern/kern_cpu.c

View Options

sys/kern/kern_et.c

View Options

sys/kern/kern_fail.c

View Options

sys/kern/kern_ffclock.c

View Options

sys/kern/kern_fork.c

View Options

sys/kern/kern_intr.c

View Options

sys/kern/kern_jail.c

View Options

sys/kern/kern_kcov.c

View Options

sys/kern/kern_ktr.c

View Options

sys/kern/kern_ktrace.c

View Options

sys/kern/kern_linker.c

View Options

sys/kern/kern_malloc.c

View Options

sys/kern/kern_mbuf.c

View Options

sys/kern/kern_mib.c

View Options

sys/kern/kern_mutex.c

View Options

sys/kern/kern_ntptime.c

View Options

sys/kern/kern_pmc.c

View Options

sys/kern/kern_poll.c

View Options

sys/kern/kern_proc.c

View Options

sys/kern/kern_prot.c

View Options

sys/kern/kern_racct.c

View Options

sys/kern/kern_rctl.c

View Options

sys/kern/kern_rwlock.c

View Options

sys/kern/kern_sendfile.c

View Options

sys/kern/kern_shutdown.c

View Options

sys/kern/kern_sig.c

View Options

sys/kern/kern_switch.c

View Options

sys/kern/kern_sx.c

View Options

sys/kern/kern_sysctl.c

View Options

sys/kern/kern_tc.c

View Options

sys/kern/kern_thr.c

View Options

sys/kern/kern_umtx.c

View Options

sys/kern/posix4_mib.c

View Options

sys/kern/sched_4bsd.c

View Options

sys/kern/sched_ule.c

View Options

sys/kern/subr_bus.c

View Options

sys/kern/subr_devstat.c

View Options

sys/kern/subr_epoch.c

View Options

sys/kern/subr_kdb.c

View Options

sys/kern/subr_lock.c

View Options

sys/kern/subr_param.c

View Options

sys/kern/subr_prof.c

View Options

sys/kern/subr_rman.c

View Options

sys/kern/subr_rtc.c

View Options

sys/kern/subr_sleepqueue.c

View Options

sys/kern/subr_smp.c

View Options

sys/kern/subr_stats.c

View Options

sys/kern/subr_turnstile.c

View Options

sys/kern/subr_witness.c

View Options

sys/kern/sys_socket.c

View Options

sys/kern/uipc_accf.c

View Options

sys/kern/uipc_ktls.c

View Options

sys/kern/uipc_mbuf.c

View Options

sys/kern/uipc_mqueue.c

View Options

sys/kern/uipc_sockbuf.c

View Options

sys/kern/uipc_socket.c

View Options

sys/kern/uipc_usrreq.c

View Options

sys/kern/vfs_aio.c

View Options

sys/kern/vfs_cache.c

View Options

sys/libkern/iconv.c

View Options

sys/mips/atheros/ar531x/ar5315_machdep.c

View Options

sys/mips/atheros/if_arge.c

View Options

sys/mips/cavium/octe/mv88e61xxphy.c

View Options

sys/mips/cavium/octeon_machdep.c

View Options

sys/mips/cavium/usb/octusb.c

View Options

sys/mips/ingenic/jz4780_aic.c

View Options

sys/mips/mips/busdma_machdep.c

View Options

sys/mips/mips/pmap.c

View Options

sys/mips/mips/tick.c

View Options

sys/mips/nlm/cms.c

View Options

sys/mips/nlm/dev/net/xlpge.c

View Options

sys/mips/nlm/tick.c

View Options

sys/net/bpf_jitter.c

View Options

sys/net/debugnet.c

View Options

sys/net/ieee8023ad_lacp.c

View Options

sys/net/if_bridge.c

View Options

sys/net/if_enc.c

View Options

sys/net/if_epair.c

View Options

sys/net/if_ethersubr.c

View Options

sys/net/if_gif.c

View Options

sys/net/if_gre.c

View Options

sys/net/if_lagg.c

View Options

sys/net/if_me.c

View Options

sys/net/if_mib.c

View Options

sys/net/if_stf.c

View Options

sys/net/if_tuntap.c

View Options

sys/net/if_vxlan.c

View Options

sys/net/iflib.c

View Options

sys/net/netisr.c

View Options

sys/net/raw_cb.c

View Options

sys/net/route.c

View Options

sys/net/rss_config.c

View Options

sys/net/rtsock.c

View Options

sys/net/vnet.h

View Options

sys/net80211/ieee80211_alq.c

View Options

sys/net80211/ieee80211_amrr.c

View Options

sys/net80211/ieee80211_freebsd.c

View Options

sys/net80211/ieee80211_ht.c

View Options

sys/net80211/ieee80211_hwmp.c

View Options

sys/net80211/ieee80211_mesh.c

View Options

sys/net80211/ieee80211_rssadapt.c

View Options

sys/net80211/ieee80211_superg.c

View Options

sys/netgraph/bluetooth/common/ng_bluetooth.c

View Options

sys/netgraph/bluetooth/socket/ng_btsocket.c

View Options

sys/netgraph/bluetooth/socket/ng_btsocket_hci_raw.c

View Options

sys/netgraph/bluetooth/socket/ng_btsocket_l2cap.c

View Options

sys/netgraph/bluetooth/socket/ng_btsocket_l2cap_raw.c

View Options

sys/netgraph/bluetooth/socket/ng_btsocket_rfcomm.c

View Options

sys/netgraph/bluetooth/socket/ng_btsocket_sco.c

View Options

sys/netgraph/ng_base.c

View Options

sys/netgraph/ng_iface.c

View Options

sys/netgraph/ng_mppc.c

View Options

sys/netgraph/ng_pptpgre.c

View Options

sys/netgraph/ng_socket.c

View Options

sys/netinet/accf_http.c

View Options

sys/netinet/cc/cc.c

View Options

sys/netinet/cc/cc_cdg.c

View Options

sys/netinet/cc/cc_chd.c

View Options

sys/netinet/cc/cc_dctcp.c

View Options

sys/netinet/cc/cc_hd.c

View Options

sys/netinet/cc/cc_htcp.c

View Options

sys/netinet/cc/cc_newreno.c

View Options

sys/netinet/cc/cc_vegas.c

View Options

sys/netinet/if_ether.c

View Options

sys/netinet/in_mcast.c

View Options

sys/netinet/in_pcb.c

View Options

sys/netinet/in_proto.c

View Options

sys/netinet/ip_carp.c

View Options

sys/netinet/ip_divert.c

View Options

sys/netinet/ip_id.c

View Options

sys/netinet/ip_input.c

View Options

sys/netinet/ip_mroute.c

View Options

sys/netinet/ip_reass.c

View Options

sys/netinet/libalias/alias.c

View Options

sys/netinet/libalias/alias_sctp.c

View Options

sys/netinet/netdump/netdump_client.c

View Options

sys/netinet/raw_ip.c

View Options

sys/netinet/sctp_sysctl.c

View Options

sys/netinet/sctp_usrreq.c

View Options

sys/netinet/siftr.c

View Options

sys/netinet/tcp_fastopen.c

View Options

sys/netinet/tcp_hostcache.c

View Options

sys/netinet/tcp_hpts.c

View Options

sys/netinet/tcp_input.c

View Options

sys/netinet/tcp_log_buf.c

View Options

sys/netinet/tcp_ratelimit.c

View Options

sys/netinet/tcp_reass.c

View Options

sys/netinet/tcp_sack.c

View Options

sys/netinet/tcp_stacks/bbr.c

View Options

sys/netinet/tcp_stacks/rack.c

View Options

sys/netinet/tcp_stats.c

View Options

sys/netinet/tcp_subr.c

View Options

sys/netinet/tcp_syncache.c

View Options

sys/netinet/tcp_timer.c

View Options

sys/netinet/tcp_timewait.c

View Options

sys/netinet/udp_usrreq.c

View Options

sys/netinet6/frag6.c

View Options

sys/netinet6/in6_mcast.c

View Options

sys/netinet6/in6_proto.c

View Options

sys/netinet6/in6_src.c

View Options

sys/netinet6/ip6_input.c

View Options

sys/netinet6/ip6_mroute.c

View Options

sys/netinet6/mld6.c

View Options

sys/netinet6/sctp6_usrreq.c

View Options

sys/netinet6/udp6_usrreq.c

View Options

sys/netipsec/ipsec.c

View Options

sys/netipsec/key.c

View Options

sys/netipsec/keysock.c

View Options

sys/netpfil/ipfw/dn_aqm_codel.c

View Options

sys/netpfil/ipfw/dn_aqm_pie.c

View Options

sys/netpfil/ipfw/dn_sched_fq_codel.c

View Options

sys/netpfil/ipfw/dn_sched_fq_pie.c

View Options

sys/netpfil/ipfw/ip_dn_io.c

View Options

sys/netpfil/ipfw/ip_fw2.c

View Options

sys/netpfil/ipfw/ip_fw_dynamic.c

View Options

sys/netpfil/ipfw/ip_fw_pfil.c

View Options

sys/netpfil/ipfw/nat64/ip_fw_nat64.c

View Options

sys/netpfil/pf/if_pfsync.c

View Options

sys/netpfil/pf/pf.c

View Options

sys/netsmb/smb_conn.c

View Options

sys/nfs/nfs_fha.c

View Options

sys/nlm/nlm_prot_impl.c

View Options

sys/ofed/drivers/infiniband/ulp/sdp/sdp_main.c

View Options

sys/opencrypto/ktls_ocf.c

View Options

sys/powerpc/fpu/fpu_emu.c

View Options

sys/powerpc/ofw/ofw_syscons.c

View Options

sys/powerpc/powermac/atibl.c

View Options

sys/powerpc/powermac/fcu.c

View Options

sys/powerpc/powermac/nvbl.c

View Options

sys/powerpc/powermac/pmu.c

View Options

sys/powerpc/powermac/smu.c

View Options

sys/powerpc/powernv/opal_sensor.c

View Options

sys/powerpc/powerpc/busdma_machdep.c

View Options

sys/powerpc/powerpc/elf32_machdep.c

View Options

sys/powerpc/ps3/ps3disk.c

View Options

sys/riscv/riscv/busdma_bounce.c

View Options

sys/riscv/riscv/pmap.c

View Options

sys/rpc/rpcsec_gss/svc_rpcsec_gss.c

View Options

sys/security/audit/audit.c

View Options

sys/security/mac/mac_framework.c

View Options

sys/security/mac_biba/mac_biba.c

View Options

sys/security/mac_bsdextended/mac_bsdextended.c

View Options

sys/security/mac_ifoff/mac_ifoff.c

View Options

sys/security/mac_lomac/mac_lomac.c

View Options

sys/security/mac_mls/mac_mls.c

View Options

sys/security/mac_ntpd/mac_ntpd.c

View Options

sys/security/mac_partition/mac_partition.c

View Options

sys/security/mac_portacl/mac_portacl.c

View Options

sys/security/mac_seeotheruids/mac_seeotheruids.c

View Options

sys/security/mac_stub/mac_stub.c

View Options

sys/security/mac_test/mac_test.c

View Options

sys/security/mac_veriexec/mac_veriexec.c

View Options

sys/security/mac_veriexec/veriexec_fingerprint.c

View Options

sys/sparc64/pci/psycho.c

View Options

sys/sparc64/sparc64/identcpu.c

View Options

sys/sparc64/sparc64/pmap.c

View Options

sys/sparc64/sparc64/tick.c

View Options

sys/sys/jail.h

View Options

sys/sys/sysctl.h

Show All 24 Lines
* *
* $FreeBSD$ * $FreeBSD$
*/ */
#include <sys/cdefs.h> #include <sys/cdefs.h>
__FBSDID("$FreeBSD$"); __FBSDID("$FreeBSD$");
#include <sys/param.h> #include <sys/param.h>
#ifndef WITHOUT_CAPSICUM
#include <sys/capsicum.h>
#endif
#include <sys/queue.h> #include <sys/queue.h>
#include <sys/errno.h> #include <sys/errno.h>
#include <sys/stat.h> #include <sys/stat.h>
#include <sys/ioctl.h> #include <sys/ioctl.h>
#include <sys/disk.h> #include <sys/disk.h>
#include <assert.h> #include <assert.h>
#include <err.h> #include <err.h>
#include <fcntl.h> #include <fcntl.h>
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
#include <pthread.h> #include <pthread.h>
#include <pthread_np.h> #include <pthread_np.h>
#include <signal.h> #include <signal.h>
#include <sysexits.h>
#include <unistd.h> #include <unistd.h>
#include <machine/atomic.h> #include <machine/atomic.h>
#include "bhyverun.h" #include "bhyverun.h"
#include "mevent.h" #include "mevent.h"
#include "block_if.h" #include "block_if.h"
▲ Show 20 Lines • Show All 339 Lines • ▼ Show 20 Linesblockif_open(const char *optstr, const char *ident)
char name[MAXPATHLEN]; char name[MAXPATHLEN];
char *nopt, *xopts, *cp; char *nopt, *xopts, *cp;
struct blockif_ctxt *bc; struct blockif_ctxt *bc;
struct stat sbuf; struct stat sbuf;
struct diocgattr_arg arg; struct diocgattr_arg arg;
off_t size, psectsz, psectoff; off_t size, psectsz, psectoff;
int extra, fd, i, sectsz; int extra, fd, i, sectsz;
int nocache, sync, ro, candelete, geom, ssopt, pssopt; int nocache, sync, ro, candelete, geom, ssopt, pssopt;
#ifndef WITHOUT_CAPSICUM
cap_rights_t rights;
u_long cmds[] = {DIOCGFLUSH, DIOCGDELETE};
#endif
pthread_once(&blockif_once, blockif_init); pthread_once(&blockif_once, blockif_init);
fd = -1; fd = -1;
ssopt = 0; ssopt = 0;
nocache = 0; nocache = 0;
sync = 0; sync = 0;
ro = 0; ro = 0;
▲ Show 20 Lines • Show All 41 Lines • ▼ Show 20 Lines if (fd < 0) {
goto err; goto err;
} }
if (fstat(fd, &sbuf) < 0) { if (fstat(fd, &sbuf) < 0) {
warn("Could not stat backing file %s", nopt); warn("Could not stat backing file %s", nopt);
goto err; goto err;
} }
#ifndef WITHOUT_CAPSICUM
grehanUnsubmitted
Not Done
Inline Actions

fsync needs to be added here, or an ahci-hd file-backed disk image will fail on FreeBSD guest shutdown with

(ada0:ahcich0:0:0:0): FLUSHCACHE48. ACB: ea 00 00 00 00 40 00 00 00 00 00 00
(ada0:ahcich0:0:0:0): CAM status: ATA Status Error
(ada0:ahcich0:0:0:0): ATA status: 41 (DRDY ERR), error: 04 (ABRT )
(ada0:ahcich0:0:0:0): RES: 41 04 00 00 00 40 00 00 00 00 00
(ada0:ahcich0:0:0:0): Retrying command
(ada0:ahcich0:0:0:0): FLUSHCACHE48. ACB: ea 00 00 00 00 40 00 00 00 00 00 00
(ada0:ahcich0:0:0:0): CAM status: ATA Status Error
(ada0:ahcich0:0:0:0): ATA status: 41 (DRDY ERR), error: 04 (ABRT )
(ada0:ahcich0:0:0:0): RES: 41 04 00 00 00 40 00 00 00 00 00
(ada0:ahcich0:0:0:0): Error 5, Retries exhausted
(ada0:ahcich0:0:0:0): Synchronize cache failed

#ifndef WITHOUT_CAPSICUM

  • cap_rights_init(&rights, CAP_IOCTL, CAP_READ, CAP_SEEK, CAP_WRITE);
  • if (ro)

+ cap_rights_init(&rights, CAP_IOCTL, CAP_READ, CAP_SEEK, CAP_WRITE,
+ CAP_FSYNC);
+ if (ro) {

		cap_rights_clear(&rights, CAP_WRITE);

+ cap_rights_clear(&rights, CAP_FSYNC);
+ }

grehan: fsync needs to be added here, or an ahci-hd file-backed disk image will fail on FreeBSD guest…
cap_rights_init(&rights, CAP_IOCTL, CAP_READ, CAP_SEEK, CAP_WRITE);
if (ro)
cap_rights_clear(&rights, CAP_WRITE);
oshogboUnsubmitted
Not Done
Inline Actions

I'm not sure if here the reverse logic would be more secure.

oshogbo: I'm not sure if here the reverse logic would be more secure.
emasteUnsubmitted
Not Done
Inline Actions

That is:

cap_rights_init(&rights, CAP_IOCTL, CAP_READ, CAP_SEEK);
if (!ro)
        cap_rights_set(&rights, CAP_FSYNC, CAP_WRITE);

I agree that looks preferable.

emaste: That is: ``` cap_rights_init(&rights, CAP_IOCTL, CAP_READ, CAP_SEEK); if (!ro)…
if (cap_rights_limit(fd, &rights) == -1 && errno != ENOSYS)
errx(EX_OSERR, "Unable to apply rights for sandbox");
#endif
/* /*
* Deal with raw devices * Deal with raw devices
*/ */
size = sbuf.st_size; size = sbuf.st_size;
sectsz = DEV_BSIZE; sectsz = DEV_BSIZE;
psectsz = psectoff = 0; psectsz = psectoff = 0;
candelete = geom = 0; candelete = geom = 0;
if (S_ISCHR(sbuf.st_mode)) { if (S_ISCHR(sbuf.st_mode)) {
Show All 9 Lines if (S_ISCHR(sbuf.st_mode)) {
strlcpy(arg.name, "GEOM::candelete", sizeof(arg.name)); strlcpy(arg.name, "GEOM::candelete", sizeof(arg.name));
arg.len = sizeof(arg.value.i); arg.len = sizeof(arg.value.i);
if (ioctl(fd, DIOCGATTR, &arg) == 0) if (ioctl(fd, DIOCGATTR, &arg) == 0)
candelete = arg.value.i; candelete = arg.value.i;
if (ioctl(fd, DIOCGPROVIDERNAME, name) == 0) if (ioctl(fd, DIOCGPROVIDERNAME, name) == 0)
geom = 1; geom = 1;
} else } else
psectsz = sbuf.st_blksize; psectsz = sbuf.st_blksize;
#ifndef WITHOUT_CAPSICUM
if (cap_ioctls_limit(fd, cmds, nitems(cmds)) == -1 && errno != ENOSYS)
errx(EX_OSERR, "Unable to apply rights for sandbox");
#endif
if (ssopt != 0) { if (ssopt != 0) {
if (!powerof2(ssopt) || !powerof2(pssopt) || ssopt < 512 || if (!powerof2(ssopt) || !powerof2(pssopt) || ssopt < 512 ||
ssopt > pssopt) { ssopt > pssopt) {
fprintf(stderr, "Invalid sector size %d/%d\n", fprintf(stderr, "Invalid sector size %d/%d\n",
ssopt, pssopt); ssopt, pssopt);
goto err; goto err;
} }
▲ Show 20 Lines • Show All 329 Lines • Show Last 20 Lines
View Options

sys/tests/epoch/epoch_test.c

View Options

sys/tests/framework/kern_testfrwk.c

View Options

sys/ufs/ffs/ffs_alloc.c

View Options

sys/ufs/ffs/ffs_softdep.c

View Options

sys/ufs/ufs/ufs_dirhash.c

View Options

sys/ufs/ufs/ufs_vnops.c

View Options

sys/vm/memguard.c

View Options

sys/vm/redzone.c

View Options

sys/vm/swap_pager.c

View Options

sys/vm/uma_core.c

View Options

sys/vm/vm_meter.c

View Options

sys/vm/vm_object.c

View Options

sys/vm/vm_page.c

View Options

sys/vm/vm_pageout.c

View Options

sys/vm/vm_phys.c

View Options

sys/vm/vm_reserv.c

View Options

sys/x86/bios/vpd.c

View Options

sys/x86/iommu/intel_utils.c

View Options

sys/x86/isa/clock.c

View Options

sys/x86/x86/busdma_bounce.c

View Options

sys/x86/x86/cpu_machdep.c

Show All 24 Lines
* *
* $FreeBSD$ * $FreeBSD$
*/ */
#include <sys/cdefs.h> #include <sys/cdefs.h>
__FBSDID("$FreeBSD$"); __FBSDID("$FreeBSD$");
#include <sys/param.h> #include <sys/param.h>
#ifndef WITHOUT_CAPSICUM
#include <sys/capsicum.h>
#endif
#include <sys/queue.h> #include <sys/queue.h>
#include <sys/errno.h> #include <sys/errno.h>
#include <sys/stat.h> #include <sys/stat.h>
#include <sys/ioctl.h> #include <sys/ioctl.h>
#include <sys/disk.h> #include <sys/disk.h>
#include <assert.h> #include <assert.h>
#include <err.h> #include <err.h>
#include <fcntl.h> #include <fcntl.h>
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
#include <pthread.h> #include <pthread.h>
#include <pthread_np.h> #include <pthread_np.h>
#include <signal.h> #include <signal.h>
#include <sysexits.h>
#include <unistd.h> #include <unistd.h>
#include <machine/atomic.h> #include <machine/atomic.h>
#include "bhyverun.h" #include "bhyverun.h"
#include "mevent.h" #include "mevent.h"
#include "block_if.h" #include "block_if.h"
▲ Show 20 Lines • Show All 339 Lines • ▼ Show 20 Linesblockif_open(const char *optstr, const char *ident)
char name[MAXPATHLEN]; char name[MAXPATHLEN];
char *nopt, *xopts, *cp; char *nopt, *xopts, *cp;
struct blockif_ctxt *bc; struct blockif_ctxt *bc;
struct stat sbuf; struct stat sbuf;
struct diocgattr_arg arg; struct diocgattr_arg arg;
off_t size, psectsz, psectoff; off_t size, psectsz, psectoff;
int extra, fd, i, sectsz; int extra, fd, i, sectsz;
int nocache, sync, ro, candelete, geom, ssopt, pssopt; int nocache, sync, ro, candelete, geom, ssopt, pssopt;
#ifndef WITHOUT_CAPSICUM
cap_rights_t rights;
u_long cmds[] = {DIOCGFLUSH, DIOCGDELETE};
#endif
pthread_once(&blockif_once, blockif_init); pthread_once(&blockif_once, blockif_init);
fd = -1; fd = -1;
ssopt = 0; ssopt = 0;
nocache = 0; nocache = 0;
sync = 0; sync = 0;
ro = 0; ro = 0;
▲ Show 20 Lines • Show All 41 Lines • ▼ Show 20 Lines if (fd < 0) {
goto err; goto err;
} }
if (fstat(fd, &sbuf) < 0) { if (fstat(fd, &sbuf) < 0) {
warn("Could not stat backing file %s", nopt); warn("Could not stat backing file %s", nopt);
goto err; goto err;
} }
#ifndef WITHOUT_CAPSICUM
grehanUnsubmitted
Not Done
Inline Actions

fsync needs to be added here, or an ahci-hd file-backed disk image will fail on FreeBSD guest shutdown with

(ada0:ahcich0:0:0:0): FLUSHCACHE48. ACB: ea 00 00 00 00 40 00 00 00 00 00 00
(ada0:ahcich0:0:0:0): CAM status: ATA Status Error
(ada0:ahcich0:0:0:0): ATA status: 41 (DRDY ERR), error: 04 (ABRT )
(ada0:ahcich0:0:0:0): RES: 41 04 00 00 00 40 00 00 00 00 00
(ada0:ahcich0:0:0:0): Retrying command
(ada0:ahcich0:0:0:0): FLUSHCACHE48. ACB: ea 00 00 00 00 40 00 00 00 00 00 00
(ada0:ahcich0:0:0:0): CAM status: ATA Status Error
(ada0:ahcich0:0:0:0): ATA status: 41 (DRDY ERR), error: 04 (ABRT )
(ada0:ahcich0:0:0:0): RES: 41 04 00 00 00 40 00 00 00 00 00
(ada0:ahcich0:0:0:0): Error 5, Retries exhausted
(ada0:ahcich0:0:0:0): Synchronize cache failed

#ifndef WITHOUT_CAPSICUM

  • cap_rights_init(&rights, CAP_IOCTL, CAP_READ, CAP_SEEK, CAP_WRITE);
  • if (ro)

+ cap_rights_init(&rights, CAP_IOCTL, CAP_READ, CAP_SEEK, CAP_WRITE,
+ CAP_FSYNC);
+ if (ro) {

		cap_rights_clear(&rights, CAP_WRITE);

+ cap_rights_clear(&rights, CAP_FSYNC);
+ }

grehan: fsync needs to be added here, or an ahci-hd file-backed disk image will fail on FreeBSD guest…
cap_rights_init(&rights, CAP_IOCTL, CAP_READ, CAP_SEEK, CAP_WRITE);
if (ro)
cap_rights_clear(&rights, CAP_WRITE);
oshogboUnsubmitted
Not Done
Inline Actions

I'm not sure if here the reverse logic would be more secure.

oshogbo: I'm not sure if here the reverse logic would be more secure.
emasteUnsubmitted
Not Done
Inline Actions

That is:

cap_rights_init(&rights, CAP_IOCTL, CAP_READ, CAP_SEEK);
if (!ro)
        cap_rights_set(&rights, CAP_FSYNC, CAP_WRITE);

I agree that looks preferable.

emaste: That is: ``` cap_rights_init(&rights, CAP_IOCTL, CAP_READ, CAP_SEEK); if (!ro)…
if (cap_rights_limit(fd, &rights) == -1 && errno != ENOSYS)
errx(EX_OSERR, "Unable to apply rights for sandbox");
#endif
/* /*
* Deal with raw devices * Deal with raw devices
*/ */
size = sbuf.st_size; size = sbuf.st_size;
sectsz = DEV_BSIZE; sectsz = DEV_BSIZE;
psectsz = psectoff = 0; psectsz = psectoff = 0;
candelete = geom = 0; candelete = geom = 0;
if (S_ISCHR(sbuf.st_mode)) { if (S_ISCHR(sbuf.st_mode)) {
Show All 9 Lines if (S_ISCHR(sbuf.st_mode)) {
strlcpy(arg.name, "GEOM::candelete", sizeof(arg.name)); strlcpy(arg.name, "GEOM::candelete", sizeof(arg.name));
arg.len = sizeof(arg.value.i); arg.len = sizeof(arg.value.i);
if (ioctl(fd, DIOCGATTR, &arg) == 0) if (ioctl(fd, DIOCGATTR, &arg) == 0)
candelete = arg.value.i; candelete = arg.value.i;
if (ioctl(fd, DIOCGPROVIDERNAME, name) == 0) if (ioctl(fd, DIOCGPROVIDERNAME, name) == 0)
geom = 1; geom = 1;
} else } else
psectsz = sbuf.st_blksize; psectsz = sbuf.st_blksize;
#ifndef WITHOUT_CAPSICUM
if (cap_ioctls_limit(fd, cmds, nitems(cmds)) == -1 && errno != ENOSYS)
errx(EX_OSERR, "Unable to apply rights for sandbox");
#endif
if (ssopt != 0) { if (ssopt != 0) {
if (!powerof2(ssopt) || !powerof2(pssopt) || ssopt < 512 || if (!powerof2(ssopt) || !powerof2(pssopt) || ssopt < 512 ||
ssopt > pssopt) { ssopt > pssopt) {
fprintf(stderr, "Invalid sector size %d/%d\n", fprintf(stderr, "Invalid sector size %d/%d\n",
ssopt, pssopt); ssopt, pssopt);
goto err; goto err;
} }
▲ Show 20 Lines • Show All 329 Lines • Show Last 20 Lines
View Options

sys/x86/x86/intr_machdep.c

Show All 24 Lines
* *
* $FreeBSD$ * $FreeBSD$
*/ */
#include <sys/cdefs.h> #include <sys/cdefs.h>
__FBSDID("$FreeBSD$"); __FBSDID("$FreeBSD$");
#include <sys/param.h> #include <sys/param.h>
#ifndef WITHOUT_CAPSICUM
#include <sys/capsicum.h>
#endif
#include <sys/queue.h> #include <sys/queue.h>
#include <sys/errno.h> #include <sys/errno.h>
#include <sys/stat.h> #include <sys/stat.h>
#include <sys/ioctl.h> #include <sys/ioctl.h>
#include <sys/disk.h> #include <sys/disk.h>
#include <assert.h> #include <assert.h>
#include <err.h> #include <err.h>
#include <fcntl.h> #include <fcntl.h>
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
#include <pthread.h> #include <pthread.h>
#include <pthread_np.h> #include <pthread_np.h>
#include <signal.h> #include <signal.h>
#include <sysexits.h>
#include <unistd.h> #include <unistd.h>
#include <machine/atomic.h> #include <machine/atomic.h>
#include "bhyverun.h" #include "bhyverun.h"
#include "mevent.h" #include "mevent.h"
#include "block_if.h" #include "block_if.h"
▲ Show 20 Lines • Show All 339 Lines • ▼ Show 20 Linesblockif_open(const char *optstr, const char *ident)
char name[MAXPATHLEN]; char name[MAXPATHLEN];
char *nopt, *xopts, *cp; char *nopt, *xopts, *cp;
struct blockif_ctxt *bc; struct blockif_ctxt *bc;
struct stat sbuf; struct stat sbuf;
struct diocgattr_arg arg; struct diocgattr_arg arg;
off_t size, psectsz, psectoff; off_t size, psectsz, psectoff;
int extra, fd, i, sectsz; int extra, fd, i, sectsz;
int nocache, sync, ro, candelete, geom, ssopt, pssopt; int nocache, sync, ro, candelete, geom, ssopt, pssopt;
#ifndef WITHOUT_CAPSICUM
cap_rights_t rights;
u_long cmds[] = {DIOCGFLUSH, DIOCGDELETE};
#endif
pthread_once(&blockif_once, blockif_init); pthread_once(&blockif_once, blockif_init);
fd = -1; fd = -1;
ssopt = 0; ssopt = 0;
nocache = 0; nocache = 0;
sync = 0; sync = 0;
ro = 0; ro = 0;
▲ Show 20 Lines • Show All 41 Lines • ▼ Show 20 Lines if (fd < 0) {
goto err; goto err;
} }
if (fstat(fd, &sbuf) < 0) { if (fstat(fd, &sbuf) < 0) {
warn("Could not stat backing file %s", nopt); warn("Could not stat backing file %s", nopt);
goto err; goto err;
} }
#ifndef WITHOUT_CAPSICUM
grehanUnsubmitted
Not Done
Inline Actions

fsync needs to be added here, or an ahci-hd file-backed disk image will fail on FreeBSD guest shutdown with

(ada0:ahcich0:0:0:0): FLUSHCACHE48. ACB: ea 00 00 00 00 40 00 00 00 00 00 00
(ada0:ahcich0:0:0:0): CAM status: ATA Status Error
(ada0:ahcich0:0:0:0): ATA status: 41 (DRDY ERR), error: 04 (ABRT )
(ada0:ahcich0:0:0:0): RES: 41 04 00 00 00 40 00 00 00 00 00
(ada0:ahcich0:0:0:0): Retrying command
(ada0:ahcich0:0:0:0): FLUSHCACHE48. ACB: ea 00 00 00 00 40 00 00 00 00 00 00
(ada0:ahcich0:0:0:0): CAM status: ATA Status Error
(ada0:ahcich0:0:0:0): ATA status: 41 (DRDY ERR), error: 04 (ABRT )
(ada0:ahcich0:0:0:0): RES: 41 04 00 00 00 40 00 00 00 00 00
(ada0:ahcich0:0:0:0): Error 5, Retries exhausted
(ada0:ahcich0:0:0:0): Synchronize cache failed

#ifndef WITHOUT_CAPSICUM

  • cap_rights_init(&rights, CAP_IOCTL, CAP_READ, CAP_SEEK, CAP_WRITE);
  • if (ro)

+ cap_rights_init(&rights, CAP_IOCTL, CAP_READ, CAP_SEEK, CAP_WRITE,
+ CAP_FSYNC);
+ if (ro) {

		cap_rights_clear(&rights, CAP_WRITE);

+ cap_rights_clear(&rights, CAP_FSYNC);
+ }

grehan: fsync needs to be added here, or an ahci-hd file-backed disk image will fail on FreeBSD guest…
cap_rights_init(&rights, CAP_IOCTL, CAP_READ, CAP_SEEK, CAP_WRITE);
if (ro)
cap_rights_clear(&rights, CAP_WRITE);
oshogboUnsubmitted
Not Done
Inline Actions

I'm not sure if here the reverse logic would be more secure.

oshogbo: I'm not sure if here the reverse logic would be more secure.
emasteUnsubmitted
Not Done
Inline Actions

That is:

cap_rights_init(&rights, CAP_IOCTL, CAP_READ, CAP_SEEK);
if (!ro)
        cap_rights_set(&rights, CAP_FSYNC, CAP_WRITE);

I agree that looks preferable.

emaste: That is: ``` cap_rights_init(&rights, CAP_IOCTL, CAP_READ, CAP_SEEK); if (!ro)…
if (cap_rights_limit(fd, &rights) == -1 && errno != ENOSYS)
errx(EX_OSERR, "Unable to apply rights for sandbox");
#endif
/* /*
* Deal with raw devices * Deal with raw devices
*/ */
size = sbuf.st_size; size = sbuf.st_size;
sectsz = DEV_BSIZE; sectsz = DEV_BSIZE;
psectsz = psectoff = 0; psectsz = psectoff = 0;
candelete = geom = 0; candelete = geom = 0;
if (S_ISCHR(sbuf.st_mode)) { if (S_ISCHR(sbuf.st_mode)) {
Show All 9 Lines if (S_ISCHR(sbuf.st_mode)) {
strlcpy(arg.name, "GEOM::candelete", sizeof(arg.name)); strlcpy(arg.name, "GEOM::candelete", sizeof(arg.name));
arg.len = sizeof(arg.value.i); arg.len = sizeof(arg.value.i);
if (ioctl(fd, DIOCGATTR, &arg) == 0) if (ioctl(fd, DIOCGATTR, &arg) == 0)
candelete = arg.value.i; candelete = arg.value.i;
if (ioctl(fd, DIOCGPROVIDERNAME, name) == 0) if (ioctl(fd, DIOCGPROVIDERNAME, name) == 0)
geom = 1; geom = 1;
} else } else
psectsz = sbuf.st_blksize; psectsz = sbuf.st_blksize;
#ifndef WITHOUT_CAPSICUM
if (cap_ioctls_limit(fd, cmds, nitems(cmds)) == -1 && errno != ENOSYS)
errx(EX_OSERR, "Unable to apply rights for sandbox");
#endif
if (ssopt != 0) { if (ssopt != 0) {
if (!powerof2(ssopt) || !powerof2(pssopt) || ssopt < 512 || if (!powerof2(ssopt) || !powerof2(pssopt) || ssopt < 512 ||
ssopt > pssopt) { ssopt > pssopt) {
fprintf(stderr, "Invalid sector size %d/%d\n", fprintf(stderr, "Invalid sector size %d/%d\n",
ssopt, pssopt); ssopt, pssopt);
goto err; goto err;
} }
▲ Show 20 Lines • Show All 329 Lines • Show Last 20 Lines
View Options

sys/x86/x86/local_apic.c

View Options

sys/x86/x86/mca.c

View Options

sys/x86/x86/mp_watchdog.c

View Options

sys/x86/x86/mp_x86.c

View Options

sys/x86/x86/tsc.c

Show All 24 Lines
* *
* $FreeBSD$ * $FreeBSD$
*/ */
#include <sys/cdefs.h> #include <sys/cdefs.h>
__FBSDID("$FreeBSD$"); __FBSDID("$FreeBSD$");
#include <sys/param.h> #include <sys/param.h>
#ifndef WITHOUT_CAPSICUM
#include <sys/capsicum.h>
#endif
#include <sys/queue.h> #include <sys/queue.h>
#include <sys/errno.h> #include <sys/errno.h>
#include <sys/stat.h> #include <sys/stat.h>
#include <sys/ioctl.h> #include <sys/ioctl.h>
#include <sys/disk.h> #include <sys/disk.h>
#include <assert.h> #include <assert.h>
#include <err.h> #include <err.h>
#include <fcntl.h> #include <fcntl.h>
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
#include <pthread.h> #include <pthread.h>
#include <pthread_np.h> #include <pthread_np.h>
#include <signal.h> #include <signal.h>
#include <sysexits.h>
#include <unistd.h> #include <unistd.h>
#include <machine/atomic.h> #include <machine/atomic.h>
#include "bhyverun.h" #include "bhyverun.h"
#include "mevent.h" #include "mevent.h"
#include "block_if.h" #include "block_if.h"
▲ Show 20 Lines • Show All 339 Lines • ▼ Show 20 Linesblockif_open(const char *optstr, const char *ident)
char name[MAXPATHLEN]; char name[MAXPATHLEN];
char *nopt, *xopts, *cp; char *nopt, *xopts, *cp;
struct blockif_ctxt *bc; struct blockif_ctxt *bc;
struct stat sbuf; struct stat sbuf;
struct diocgattr_arg arg; struct diocgattr_arg arg;
off_t size, psectsz, psectoff; off_t size, psectsz, psectoff;
int extra, fd, i, sectsz; int extra, fd, i, sectsz;
int nocache, sync, ro, candelete, geom, ssopt, pssopt; int nocache, sync, ro, candelete, geom, ssopt, pssopt;
#ifndef WITHOUT_CAPSICUM
cap_rights_t rights;
u_long cmds[] = {DIOCGFLUSH, DIOCGDELETE};
#endif
pthread_once(&blockif_once, blockif_init); pthread_once(&blockif_once, blockif_init);
fd = -1; fd = -1;
ssopt = 0; ssopt = 0;
nocache = 0; nocache = 0;
sync = 0; sync = 0;
ro = 0; ro = 0;
▲ Show 20 Lines • Show All 41 Lines • ▼ Show 20 Lines if (fd < 0) {
goto err; goto err;
} }
if (fstat(fd, &sbuf) < 0) { if (fstat(fd, &sbuf) < 0) {
warn("Could not stat backing file %s", nopt); warn("Could not stat backing file %s", nopt);
goto err; goto err;
} }
#ifndef WITHOUT_CAPSICUM
grehanUnsubmitted
Not Done
Inline Actions

fsync needs to be added here, or an ahci-hd file-backed disk image will fail on FreeBSD guest shutdown with

(ada0:ahcich0:0:0:0): FLUSHCACHE48. ACB: ea 00 00 00 00 40 00 00 00 00 00 00
(ada0:ahcich0:0:0:0): CAM status: ATA Status Error
(ada0:ahcich0:0:0:0): ATA status: 41 (DRDY ERR), error: 04 (ABRT )
(ada0:ahcich0:0:0:0): RES: 41 04 00 00 00 40 00 00 00 00 00
(ada0:ahcich0:0:0:0): Retrying command
(ada0:ahcich0:0:0:0): FLUSHCACHE48. ACB: ea 00 00 00 00 40 00 00 00 00 00 00
(ada0:ahcich0:0:0:0): CAM status: ATA Status Error
(ada0:ahcich0:0:0:0): ATA status: 41 (DRDY ERR), error: 04 (ABRT )
(ada0:ahcich0:0:0:0): RES: 41 04 00 00 00 40 00 00 00 00 00
(ada0:ahcich0:0:0:0): Error 5, Retries exhausted
(ada0:ahcich0:0:0:0): Synchronize cache failed

#ifndef WITHOUT_CAPSICUM

  • cap_rights_init(&rights, CAP_IOCTL, CAP_READ, CAP_SEEK, CAP_WRITE);
  • if (ro)

+ cap_rights_init(&rights, CAP_IOCTL, CAP_READ, CAP_SEEK, CAP_WRITE,
+ CAP_FSYNC);
+ if (ro) {

		cap_rights_clear(&rights, CAP_WRITE);

+ cap_rights_clear(&rights, CAP_FSYNC);
+ }

grehan: fsync needs to be added here, or an ahci-hd file-backed disk image will fail on FreeBSD guest…
cap_rights_init(&rights, CAP_IOCTL, CAP_READ, CAP_SEEK, CAP_WRITE);
if (ro)
cap_rights_clear(&rights, CAP_WRITE);
oshogboUnsubmitted
Not Done
Inline Actions

I'm not sure if here the reverse logic would be more secure.

oshogbo: I'm not sure if here the reverse logic would be more secure.
emasteUnsubmitted
Not Done
Inline Actions

That is:

cap_rights_init(&rights, CAP_IOCTL, CAP_READ, CAP_SEEK);
if (!ro)
        cap_rights_set(&rights, CAP_FSYNC, CAP_WRITE);

I agree that looks preferable.

emaste: That is: ``` cap_rights_init(&rights, CAP_IOCTL, CAP_READ, CAP_SEEK); if (!ro)…
if (cap_rights_limit(fd, &rights) == -1 && errno != ENOSYS)
errx(EX_OSERR, "Unable to apply rights for sandbox");
#endif
/* /*
* Deal with raw devices * Deal with raw devices
*/ */
size = sbuf.st_size; size = sbuf.st_size;
sectsz = DEV_BSIZE; sectsz = DEV_BSIZE;
psectsz = psectoff = 0; psectsz = psectoff = 0;
candelete = geom = 0; candelete = geom = 0;
if (S_ISCHR(sbuf.st_mode)) { if (S_ISCHR(sbuf.st_mode)) {
Show All 9 Lines if (S_ISCHR(sbuf.st_mode)) {
strlcpy(arg.name, "GEOM::candelete", sizeof(arg.name)); strlcpy(arg.name, "GEOM::candelete", sizeof(arg.name));
arg.len = sizeof(arg.value.i); arg.len = sizeof(arg.value.i);
if (ioctl(fd, DIOCGATTR, &arg) == 0) if (ioctl(fd, DIOCGATTR, &arg) == 0)
candelete = arg.value.i; candelete = arg.value.i;
if (ioctl(fd, DIOCGPROVIDERNAME, name) == 0) if (ioctl(fd, DIOCGPROVIDERNAME, name) == 0)
geom = 1; geom = 1;
} else } else
psectsz = sbuf.st_blksize; psectsz = sbuf.st_blksize;
#ifndef WITHOUT_CAPSICUM
if (cap_ioctls_limit(fd, cmds, nitems(cmds)) == -1 && errno != ENOSYS)
errx(EX_OSERR, "Unable to apply rights for sandbox");
#endif
if (ssopt != 0) { if (ssopt != 0) {
if (!powerof2(ssopt) || !powerof2(pssopt) || ssopt < 512 || if (!powerof2(ssopt) || !powerof2(pssopt) || ssopt < 512 ||
ssopt > pssopt) { ssopt > pssopt) {
fprintf(stderr, "Invalid sector size %d/%d\n", fprintf(stderr, "Invalid sector size %d/%d\n",
ssopt, pssopt); ssopt, pssopt);
goto err; goto err;
} }
▲ Show 20 Lines • Show All 329 Lines • Show Last 20 Lines
View Options

sys/xen/xenbus/xenbusb.c