Differential D23636

Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N)
ClosedPublic
Actions

Authored by kaktus on Feb 11 2020, 9:13 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, May 7, 6:21 AM

	Unknown Object (File)
	Thu, Apr 30, 7:46 AM

	Unknown Object (File)
	Wed, Apr 29, 1:41 PM

	Unknown Object (File)
	Wed, Apr 29, 1:31 PM

	Unknown Object (File)
	Mon, Apr 27, 8:36 PM

	Unknown Object (File)
	Tue, Apr 21, 3:59 AM

	Unknown Object (File)
	Apr 13 2026, 5:47 PM

	Unknown Object (File)
	Apr 9 2026, 8:31 PM

Subscribers

Details

Reviewers

kib
nwhitehorn

Commits

rS358280: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (11 of many)

Summary

r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that are still not MPSAFE (or already are but aren’t properly marked). Use it in preparation for a general review of all nodes.
This is non-functional change that adds annotations to SYSCTL_NODE and SYSCTL_PROC nodes using one of the soon-to-be-required flags.

You’re asked for a review based on src/MAINTAINERS entry.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kaktus created this revision.Feb 11 2020, 9:13 PM

kaktus added inline comments.Feb 16 2020, 11:34 AM

sys/dev/ofw/ofw_fdt.c
127 ↗	(On Diff #68148)	MPSAFE

This sysctl is MPSAFE.

kaktus mentioned this in D23110: Introduce CTLFLAG_NEEDGIANT.Feb 16 2020, 5:18 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 24 2020, 10:41 AM

Closed by commit rS358280: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (11 of many) (authored by kaktus). · Explain Why

This revision was automatically updated to reflect the committed changes.

kaktus added a commit: rS358280: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (11 of many).

Herald added a subscriber: imp. · View Herald TranscriptFeb 24 2020, 10:41 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

ofw/

4 lines

Diff 68742

head/sys/dev/ofw/ofw_fdt.c

Loading...