Page MenuHomeFreeBSD

Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N)
ClosedPublic

Authored by kaktus on Tue, Feb 11, 9:16 PM.

Details

Summary

r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that are still not MPSAFE (or already are but aren’t properly marked). Use it in preparation for a general review of all nodes.
This is non-functional change that adds annotations to SYSCTL_NODE and SYSCTL_PROC nodes using one of the soon-to-be-required flags.

You’re asked for a review based on src/MAINTAINERS entry.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kaktus created this revision.Tue, Feb 11, 9:16 PM
trasz added a comment.Wed, Feb 12, 8:18 AM

Thanks! Why are some of the those nodes marked as NEEDGIANT though?

Because they weren't marked as MPSAFE before :-) but after checking I think we can assume they are MPSAFE.

kaktus updated this revision to Diff 68252.Thu, Feb 13, 4:47 PM

These nodes are MPSAFE.

kib accepted this revision.Thu, Feb 13, 5:00 PM

Fine with me. I suggest to wait a day or two for trasz (I assume you grouped changes to his code in this review).

This revision is now accepted and ready to land.Thu, Feb 13, 5:00 PM
trasz accepted this revision.Thu, Feb 13, 10:05 PM

Looks fine now, thanks :-)