Page MenuHomeFreeBSD
Differential D23640

Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N)
ClosedPublic
Actions

Authored by kaktus on Feb 11 2020, 9:16 PM.
Tags
None
Referenced Files
F154402139: D23640.id68252.diff
Tue, Apr 28, 8:57 AM
Unknown Object (File)
Mon, Apr 27, 8:57 AM
Unknown Object (File)
Sun, Apr 26, 7:43 PM
Unknown Object (File)
Sun, Apr 26, 5:04 AM
Unknown Object (File)
Sat, Apr 25, 7:24 AM
Unknown Object (File)
Mon, Apr 20, 2:42 PM
Unknown Object (File)
Mon, Apr 20, 7:34 AM
Unknown Object (File)
Mon, Apr 6, 8:24 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
trasz
Commits
rS357971: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (1 of many)
Summary

r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that are still not MPSAFE (or already are but aren’t properly marked). Use it in preparation for a general review of all nodes.
This is non-functional change that adds annotations to SYSCTL_NODE and SYSCTL_PROC nodes using one of the soon-to-be-required flags.

You’re asked for a review based on src/MAINTAINERS entry.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kaktus created this revision.Feb 11 2020, 9:16 PM
trasz added a comment.Feb 12 2020, 8:18 AM

Thanks! Why are some of the those nodes marked as NEEDGIANT though?

kaktus added a comment.Feb 13 2020, 4:46 PM

Because they weren't marked as MPSAFE before :-) but after checking I think we can assume they are MPSAFE.

kaktus updated this revision to Diff 68252.Feb 13 2020, 4:47 PM

These nodes are MPSAFE.

kib accepted this revision.Feb 13 2020, 5:00 PM

Fine with me. I suggest to wait a day or two for trasz (I assume you grouped changes to his code in this review).

This revision is now accepted and ready to land.Feb 13 2020, 5:00 PM
trasz accepted this revision.Feb 13 2020, 10:05 PM

Looks fine now, thanks :-)

Closed by commit rS357971: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (1 of many) (authored by kaktus). · Explain WhyFeb 15 2020, 6:48 PM
This revision was automatically updated to reflect the committed changes.
kaktus added a commit: rS357971: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (1 of many).
Herald added a subscriber: imp. · View Herald TranscriptFeb 15 2020, 6:48 PM
kaktus mentioned this in D23718: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).Feb 16 2020, 4:41 PM
kaktus mentioned this in D23110: Introduce CTLFLAG_NEEDGIANT.Feb 16 2020, 5:18 PM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
iscsi/
3 lines
3 lines
fs/
autofs/
3 lines
kern/
15 lines

Diff 68362

View Options

head/sys/dev/iscsi/icl.c

Loading...
View Options

head/sys/dev/iscsi/iscsi.c

Loading...
View Options

head/sys/fs/autofs/autofs.c

Loading...
View Options

head/sys/kern/kern_rctl.c

Loading...