Differential D23640

Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N)
ClosedPublic
Actions

Authored by kaktus on Feb 11 2020, 9:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Mar 1, 4:24 PM

	Unknown Object (File)
	Sat, Feb 22, 12:16 AM

	Unknown Object (File)
	Fri, Feb 21, 10:08 AM

	Unknown Object (File)
	Tue, Feb 11, 9:29 PM

	Unknown Object (File)
	Jan 25 2025, 7:45 PM

	Unknown Object (File)
	Jan 24 2025, 5:24 PM

	Unknown Object (File)
	Jan 18 2025, 10:21 PM

	Unknown Object (File)
	Jan 18 2025, 5:41 PM

Subscribers

Details

Reviewers

kib
trasz

Commits

rS357971: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (1 of many)

Summary

r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that are still not MPSAFE (or already are but aren’t properly marked). Use it in preparation for a general review of all nodes.
This is non-functional change that adds annotations to SYSCTL_NODE and SYSCTL_PROC nodes using one of the soon-to-be-required flags.

You’re asked for a review based on src/MAINTAINERS entry.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kaktus created this revision.Feb 11 2020, 9:16 PM

Thanks! Why are some of the those nodes marked as NEEDGIANT though?

Because they weren't marked as MPSAFE before :-) but after checking I think we can assume they are MPSAFE.

These nodes are MPSAFE.

Fine with me. I suggest to wait a day or two for trasz (I assume you grouped changes to his code in this review).

This revision is now accepted and ready to land.Feb 13 2020, 5:00 PM

Looks fine now, thanks :-)

Closed by commit rS357971: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (1 of many) (authored by kaktus). · Explain WhyFeb 15 2020, 6:48 PM

This revision was automatically updated to reflect the committed changes.

kaktus added a commit: rS357971: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (1 of many).

Herald added a subscriber: imp. · View Herald TranscriptFeb 15 2020, 6:48 PM

kaktus mentioned this in D23718: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N).Feb 16 2020, 4:41 PM

kaktus mentioned this in D23110: Introduce CTLFLAG_NEEDGIANT.Feb 16 2020, 5:18 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

iscsi/

3 lines

3 lines

fs/

autofs/

3 lines

kern/

15 lines

Diff 68362

head/sys/dev/iscsi/icl.c

Loading...

head/sys/dev/iscsi/iscsi.c

Loading...

head/sys/fs/autofs/autofs.c

Loading...

head/sys/kern/kern_rctl.c

Loading...