Page MenuHomeFreeBSD

Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N)
ClosedPublic

Authored by kaktus on Feb 11 2020, 9:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 21 2024, 10:50 AM
Unknown Object (File)
Jan 14 2024, 10:59 PM
Unknown Object (File)
Jan 14 2024, 5:36 AM
Unknown Object (File)
Jan 14 2024, 12:14 AM
Unknown Object (File)
Jan 10 2024, 1:50 AM
Unknown Object (File)
Dec 15 2023, 9:14 AM
Unknown Object (File)
Nov 23 2023, 6:17 AM
Unknown Object (File)
Nov 23 2023, 6:16 AM
Subscribers

Details

Summary

r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that are still not MPSAFE (or already are but aren’t properly marked). Use it in preparation for a general review of all nodes.
This is non-functional change that adds annotations to SYSCTL_NODE and SYSCTL_PROC nodes using one of the soon-to-be-required flags.

You’re asked for a review based on src/MAINTAINERS entry.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Thanks! Why are some of the those nodes marked as NEEDGIANT though?

Because they weren't marked as MPSAFE before :-) but after checking I think we can assume they are MPSAFE.

Fine with me. I suggest to wait a day or two for trasz (I assume you grouped changes to his code in this review).

This revision is now accepted and ready to land.Feb 13 2020, 5:00 PM

Looks fine now, thanks :-)