sysctl(9): properly use xor in ENFORCE_FLAGS macro
ClosedPublic
Actions

Authored by kaktus on Feb 14 2020, 12:45 AM.

Tags

None

Referenced Files

	F152017725: D23678.diff
	Sun, Apr 12, 3:08 AM

	F151895498: D23678.id68327.diff
	Sat, Apr 11, 10:17 AM

	Unknown Object (File)
	Fri, Apr 10, 10:01 PM

	Unknown Object (File)
	Mon, Apr 6, 11:23 AM

	Unknown Object (File)
	Wed, Apr 1, 5:06 PM

	Unknown Object (File)
	Wed, Apr 1, 5:03 PM

	Unknown Object (File)
	Sun, Mar 22, 4:54 PM

	Unknown Object (File)
	Mon, Mar 16, 12:10 PM

View All 89 Files

Subscribers

imp

Details

Reviewers

kib
• hselasky
cem

Commits

rS357921: sysctl(9): properly use xor in ENFORCE_FLAGS macro

Summary

Assert on not specifying any of the (soon to be) required flags as well as specifying both of them.

Pointed out by: cem, hselasky

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kaktus created this revision.Feb 14 2020, 12:45 AM

kaktus edited the summary of this revision. (Show Details)

• hselasky accepted this revision.Feb 14 2020, 8:14 AM

This revision is now accepted and ready to land.Feb 14 2020, 8:14 AM

kib accepted this revision.Feb 14 2020, 12:52 PM

Closed by commit rS357921: sysctl(9): properly use xor in ENFORCE_FLAGS macro (authored by kaktus). · Explain WhyFeb 14 2020, 4:57 PM

This revision was automatically updated to reflect the committed changes.

kaktus added a commit: rS357921: sysctl(9): properly use xor in ENFORCE_FLAGS macro.

Herald added a subscriber: imp. · View Herald TranscriptFeb 14 2020, 4:57 PM

kaktus mentioned this in D23110: Introduce CTLFLAG_NEEDGIANT.Feb 16 2020, 5:18 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

sysctl.h

4 lines

Diff 68327

View Options

sysctl(9): properly use xor in ENFORCE_FLAGS macroClosedPublicActions