Page MenuHomeFreeBSD
Differential D23635

Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N)
ClosedPublic
Actions

Authored by kaktus on Feb 11 2020, 9:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 25, 4:02 PM
Unknown Object (File)
Tue, Nov 25, 8:47 AM
Unknown Object (File)
Thu, Nov 20, 1:26 PM
Unknown Object (File)
Thu, Nov 20, 1:24 PM
Unknown Object (File)
Thu, Nov 20, 1:24 PM
Unknown Object (File)
Thu, Nov 20, 1:04 PM
Unknown Object (File)
Thu, Nov 6, 3:07 AM
Unknown Object (File)
Oct 28 2025, 4:05 PM
View All Files
Subscribers
andrew
emaste
imp

Details

Reviewers
kib
manu
Commits
rS358284: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (13 of many)
Summary

r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that are still not MPSAFE (or already are but aren’t properly marked). Use it in preparation for a general review of all nodes.
This is non-functional change that adds annotations to SYSCTL_NODE and SYSCTL_PROC nodes using one of the soon-to-be-required flags.

You’re asked for a review based on src/MAINTAINERS entry.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kaktus created this revision.Feb 11 2020, 9:12 PM
Herald added subscribers: emaste, andrew. · View Herald TranscriptFeb 11 2020, 9:12 PM
kaktus added inline comments.Feb 16 2020, 11:30 AM
sys/arm/allwinner/aw_sid.c
281 ↗(On Diff #68147)

MPSAFE?

sys/arm/allwinner/aw_thermal.c
679 ↗(On Diff #68147)

MPSAFE?

sys/arm/allwinner/aw_ts.c
208 ↗(On Diff #68147)

MPSAFE?

sys/arm/allwinner/axp209.c
1271 ↗(On Diff #68147)

MPSAFE?

sys/arm/allwinner/axp81x.c
1541 ↗(On Diff #68147)

MPSAFE?

1549 ↗(On Diff #68147)

Require some locking to protect against concurrent modifications?

sys/arm/allwinner/if_emac.c
927 ↗(On Diff #68147)

Require some locking to protect against concurrent modifications?

sys/arm64/rockchip/rk_tsadc.c
569 ↗(On Diff #68147)

MPSAFE?

kaktus mentioned this in D23110: Introduce CTLFLAG_NEEDGIANT.Feb 16 2020, 5:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 24 2020, 10:45 AM
Closed by commit rS358284: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (13 of many) (authored by kaktus). · Explain Why
This revision was automatically updated to reflect the committed changes.
kaktus added a commit: rS358284: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (13 of many).
Herald added a subscriber: imp. · View Herald TranscriptFeb 24 2020, 10:45 AM

Revision Contents
Changeset List

PathSize
head/
sys/
arm/
allwinner/
2 lines
2 lines
3 lines
2 lines
4 lines
3 lines
arm64/
rockchip/
4 lines

Diff 68744

View Options

head/sys/arm/allwinner/aw_sid.c

Loading...
View Options

head/sys/arm/allwinner/aw_thermal.c

Loading...
View Options

head/sys/arm/allwinner/aw_ts.c

Loading...
View Options

head/sys/arm/allwinner/axp209.c

Loading...
View Options

head/sys/arm/allwinner/axp81x.c

Loading...
View Options

head/sys/arm/allwinner/if_emac.c

Loading...
View Options

head/sys/arm64/rockchip/rk_tsadc.c

Loading...