Page MenuHomeFreeBSD

Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N)
Needs ReviewPublic

Authored by kaktus on Tue, Feb 11, 9:12 PM.

Details

Reviewers
kib
manu
Summary

r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that are still not MPSAFE (or already are but aren’t properly marked). Use it in preparation for a general review of all nodes.
This is non-functional change that adds annotations to SYSCTL_NODE and SYSCTL_PROC nodes using one of the soon-to-be-required flags.

You’re asked for a review based on src/MAINTAINERS entry.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

kaktus created this revision.Tue, Feb 11, 9:12 PM
kaktus added inline comments.Sun, Feb 16, 11:30 AM
sys/arm/allwinner/aw_sid.c
281

MPSAFE?

sys/arm/allwinner/aw_thermal.c
679

MPSAFE?

sys/arm/allwinner/aw_ts.c
208

MPSAFE?

sys/arm/allwinner/axp209.c
1271

MPSAFE?

sys/arm/allwinner/axp81x.c
1541

MPSAFE?

1549

Require some locking to protect against concurrent modifications?

sys/arm/allwinner/if_emac.c
927

Require some locking to protect against concurrent modifications?

sys/arm64/rockchip/rk_tsadc.c
569

MPSAFE?