Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N)
ClosedPublic
Actions

Authored by kaktus on Feb 11 2020, 9:12 PM.

Details

Reviewers

kib
manu

Commits

rS358284: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (13 of many)

Summary

r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that are still not MPSAFE (or already are but aren’t properly marked). Use it in preparation for a general review of all nodes.
This is non-functional change that adds annotations to SYSCTL_NODE and SYSCTL_PROC nodes using one of the soon-to-be-required flags.

You’re asked for a review based on src/MAINTAINERS entry.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kaktus created this revision.Feb 11 2020, 9:12 PM

Herald added subscribers: emaste, andrew. · View Herald TranscriptFeb 11 2020, 9:12 PM

kaktus added inline comments.Feb 16 2020, 11:30 AM

sys/arm/allwinner/aw_sid.c
281 ↗	(On Diff #68147)	MPSAFE?
sys/arm/allwinner/aw_thermal.c
679 ↗	(On Diff #68147)	MPSAFE?
sys/arm/allwinner/aw_ts.c
208 ↗	(On Diff #68147)	MPSAFE?
sys/arm/allwinner/axp209.c
1271 ↗	(On Diff #68147)	MPSAFE?
sys/arm/allwinner/axp81x.c
1541 ↗	(On Diff #68147)	MPSAFE?
1549 ↗	(On Diff #68147)	Require some locking to protect against concurrent modifications?
sys/arm/allwinner/if_emac.c
927 ↗	(On Diff #68147)	Require some locking to protect against concurrent modifications?
sys/arm64/rockchip/rk_tsadc.c
569 ↗	(On Diff #68147)	MPSAFE?