Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N)
ClosedPublic
Actions

Authored by kaktus on Feb 11 2020, 9:08 PM.

Details

Reviewers

kib
• hselasky
zeising
johalun

Group Reviewers

x11

Commits

rS357973: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (2 of many)

Summary

r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that are still not MPSAFE (or already are but aren’t properly marked). Use it in preparation for a general review of all nodes.
This is non-functional change that adds annotations to SYSCTL_NODE and SYSCTL_PROC nodes using one of the soon-to-be-required flags.

You’re asked for a review based on src/MAINTAINERS entry.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kaktus created this revision.Feb 11 2020, 9:08 PM

Herald added a subscriber: emaste. · View Herald TranscriptFeb 11 2020, 9:08 PM

I have no problems with this change from an x11 perspective. However, please give @hselasky the chance to chime in, since he knows much more about the lkpi than I do.

This revision is now accepted and ready to land.Feb 12 2020, 10:46 AM

The LinuxKPI does not depend on Giant. All instances of SYSCTL's in the LinuxKPI can be made MPSAFE.

• hselasky accepted this revision.Feb 12 2020, 11:03 AM

kib accepted this revision.Feb 15 2020, 4:53 PM

Closed by commit rS357973: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (2 of many) (authored by kaktus). · Explain WhyFeb 15 2020, 6:55 PM

This revision was automatically updated to reflect the committed changes.

kaktus added a commit: rS357973: Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (2 of many).

Herald added a subscriber: imp. · View Herald TranscriptFeb 15 2020, 6:55 PM

kaktus mentioned this in D23110: Introduce CTLFLAG_NEEDGIANT.Feb 16 2020, 5:18 PM