Page MenuHomeFreeBSD

Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N)
ClosedPublic

Authored by kaktus on Tue, Feb 11, 9:08 PM.

Details

Summary

r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that are still not MPSAFE (or already are but aren’t properly marked). Use it in preparation for a general review of all nodes.
This is non-functional change that adds annotations to SYSCTL_NODE and SYSCTL_PROC nodes using one of the soon-to-be-required flags.

You’re asked for a review based on src/MAINTAINERS entry.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kaktus created this revision.Tue, Feb 11, 9:08 PM
zeising accepted this revision.Wed, Feb 12, 10:46 AM

I have no problems with this change from an x11 perspective. However, please give @hselasky the chance to chime in, since he knows much more about the lkpi than I do.

This revision is now accepted and ready to land.Wed, Feb 12, 10:46 AM

The LinuxKPI does not depend on Giant. All instances of SYSCTL's in the LinuxKPI can be made MPSAFE.

hselasky accepted this revision.Wed, Feb 12, 11:03 AM
kib accepted this revision.Sat, Feb 15, 4:53 PM