Page MenuHomeFreeBSD

Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N)
Needs ReviewPublic

Authored by kaktus on Tue, Feb 11, 9:06 PM.

Details

Reviewers
kib
erj
Summary

r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that are still not MPSAFE (or already are but aren’t properly marked). Use it in preparation for a general review of all nodes.
This is non-functional change that adds annotations to SYSCTL_NODE and SYSCTL_PROC nodes using one of the soon-to-be-required flags.

You’re asked for a review based on src/MAINTAINERS entry.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

kaktus created this revision.Tue, Feb 11, 9:06 PM
erj added a comment.Wed, Feb 12, 2:18 AM

Is there a reason that these syctls would need "CTLFLAG_NEEDSGIANT", or does this patch default to that flag because it's a safe default if the contents of the sysctl are unknown? I'm aware of the previous review that added these flags, but I didn't get to look at it too closely.

That is exactly the reason: sysctl's that weren't before marked as MPSAFE are marked as NEEDGIANT, but if you're happy with current locking (or lack of it if unneeded) I can mark them as MPSAFE.