Page MenuHomeFreeBSD

Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (M of N)
ClosedPublic

Authored by kaktus on Feb 11 2020, 9:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 3, 5:03 AM
Unknown Object (File)
Thu, Nov 20, 11:01 PM
Unknown Object (File)
Thu, Nov 20, 1:14 PM
Unknown Object (File)
Thu, Nov 20, 1:13 PM
Unknown Object (File)
Thu, Nov 20, 1:05 PM
Unknown Object (File)
Oct 28 2025, 8:04 AM
Unknown Object (File)
Oct 26 2025, 12:42 AM
Unknown Object (File)
Oct 25 2025, 8:16 PM
Subscribers

Details

Reviewers
kib
erj
kaktus
Summary

r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that are still not MPSAFE (or already are but aren’t properly marked). Use it in preparation for a general review of all nodes.
This is non-functional change that adds annotations to SYSCTL_NODE and SYSCTL_PROC nodes using one of the soon-to-be-required flags.

You’re asked for a review based on src/MAINTAINERS entry.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Is there a reason that these syctls would need "CTLFLAG_NEEDSGIANT", or does this patch default to that flag because it's a safe default if the contents of the sysctl are unknown? I'm aware of the previous review that added these flags, but I didn't get to look at it too closely.

That is exactly the reason: sysctl's that weren't before marked as MPSAFE are marked as NEEDGIANT, but if you're happy with current locking (or lack of it if unneeded) I can mark them as MPSAFE.

This revision is now accepted and ready to land.Feb 24 2020, 10:56 AM