Add a new virtio backend to support SCMI VirtIO devices (type 32) as
defined by the VirtIO specification since version v1.2.
https://docs.oasis-open.org/virtio/virtio/v1.2/cs01/virtio-v1.2-cs01.pdf
Sponsored by: Arm Ltd
Paths
| Differential D43047 Authored by cristian.marussi_arm.com on Dec 13 2023, 6:38 PM.
Details
Summary Add a new virtio backend to support SCMI VirtIO devices (type 32) as https://docs.oasis-open.org/virtio/virtio/v1.2/cs01/virtio-v1.2-cs01.pdf Sponsored by: Arm Ltd
Diff Detail
Event TimelineHerald added a reviewer: andrew. · View Herald TranscriptDec 13 2023, 6:38 PM2023-12-13 18:38:08 (UTC+0) cristian.marussi_arm.com requested review of this revision.Dec 13 2023, 6:38 PM2023-12-13 18:38:08 (UTC+0) cristian.marussi_arm.com added a parent revision: D43046: scmi: Introduce a new SCMI API and port CLK SCMI driver to it. Harbormaster completed remote builds in B54929: Diff 131353.Dec 13 2023, 6:38 PM2023-12-13 18:38:13 (UTC+0) Comment Actions Just a few minor comments. Note though that I only have time to do a brief review of this and haven't read the relevant section of the spec.
This revision is now accepted and ready to land.Jan 31 2024, 4:13 AM2024-01-31 04:13:39 (UTC+0) Comment Actions Thanks for the review @bryanv.
I was thinking exactly the same while doing this, but being a first time contributor to freeBSD, I was not sure how easily acceptable would have been to post a change related to some core system (like virtio) inside this series, Comment Actions
Sure, a separate follow on commit is fine. cristian.marussi_arm.com updated this revision to Diff 135288.Mar 1 2024, 7:12 PM2024-03-01 19:12:52 (UTC+0) Comment ActionsRemoved needless checks on malloc, using mallocarray Using mallocarray() and dropping the retval check since invoked as M_WAITOK This revision now requires review to proceed.Mar 1 2024, 7:12 PM2024-03-01 19:12:52 (UTC+0) Harbormaster completed remote builds in B56386: Diff 135288.Mar 1 2024, 7:12 PM2024-03-01 19:12:57 (UTC+0) This revision is now accepted and ready to land.Mar 5 2024, 2:36 PM2024-03-05 14:36:40 (UTC+0) Closed by commit rGe1c4c8dd8d2d: vtscmi: Add a virtio-scmi driver (authored by cristian.marussi_arm.com, committed by andrew). · Explain WhyApr 11 2024, 10:00 AM2024-04-11 10:00:38 (UTC+0) This revision was automatically updated to reflect the committed changes. freebsd_igalic.co added a subscriber: freebsd_igalic.co.Apr 18 2024, 11:05 AM2024-04-18 11:05:08 (UTC+0) Comment ActionsI'm a bit late to the party, but is there a reason why this module wasn't hooked into the build system? see https://cgit.freebsd.org/src/tree/sys/modules/virtio/Makefile Comment Actions It's not very useful as a module as it provides infrastructure other devices need, e.g. their clock, or a reset line. If it was a module these drivers would fail to attach if they were built into the kernel.
Revision Contents
Diff 136886 sys/arm64/conf/NOTES
sys/arm64/conf/std.virt
sys/conf/files
sys/dev/virtio/scmi/virtio_scmi.h
|