ufshci: enable the ufshci module to load at boot time
ClosedPublic
Actions

Authored by jaeyoon on Jun 19 2025, 8:40 AM.

Details

Reviewers

imp
julian

Commits

rG0d5fdcb63c9d: ufshci: enable the ufshci module to load at boot time

Summary

The ufshci driver tried to allocate a single 256KB segment for the UTP
command descriptor during boot, but failed due to memory fragmentation.
I fixed it to allocate the buffer in 8KB segments instead.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jaeyoon created this revision.Jun 19 2025, 8:40 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 19 2025, 8:41 AM

jaeyoon requested review of this revision.Jun 19 2025, 8:41 AM

Harbormaster completed remote builds in B64975: Diff 157301.Jun 19 2025, 8:41 AM

jaeyoon added a reviewer: imp.Jun 19 2025, 8:45 AM

Use full name of driver

Harbormaster completed remote builds in B65037: Diff 157495.Jun 24 2025, 3:12 AM

jaeyoon added a reviewer: julian.Jul 2 2025, 12:33 AM

This looks good to my eye.

This revision is now accepted and ready to land.Jul 9 2025, 3:09 AM

Could you please commit this patch?

Closed by commit rG0d5fdcb63c9d: ufshci: enable the ufshci module to load at boot time (authored by jaeyoon, committed by imp). · Explain WhyJul 16 2025, 11:21 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG0d5fdcb63c9d: ufshci: enable the ufshci module to load at boot time.

committeed

I had hoped the test box I ordered to test the UFS stuff would have arrived by now since I wanted to test boot this first... but it's held up in customs, it seems, so after yet another delay I'll push this an the man page in.

In D50933#1172970, @imp wrote:

committeed

I had hoped the test box I ordered to test the UFS stuff would have arrived by now since I wanted to test boot this first... but it's held up in customs, it seems, so after yet another delay I'll push this an the man page in.

Would you mind sharing which test box you ordered?
I think it would be easier to troubleshoot if we have the same device.

In D50933#1172975, @j_yoon.choi_samsung.com wrote:

In D50933#1172970, @imp wrote:

committeed

I had hoped the test box I ordered to test the UFS stuff would have arrived by now since I wanted to test boot this first... but it's held up in customs, it seems, so after yet another delay I'll push this an the man page in.

Would you mind sharing which test box you ordered?
I think it would be easier to troubleshoot if we have the same device.

Minisforum S100-US Intel® N100 / 8GB RAM+256GB SSD / US is what I ordered.
https://store.minisforum.com/products/minisforum-s100?_pos=1&_psq=Minisforum+S100-US&_ss=e&_v=1.0
though it's showing out of stock at the moment... I ordered mine about a month and a half ago now and had to wait until now to get it (now the tracking is telling me it will be here any day... Monday the tracking info made it sound like it was weeks away).

In D50933#1172976, @imp wrote:

In D50933#1172975, @j_yoon.choi_samsung.com wrote:

In D50933#1172970, @imp wrote:

committeed

I had hoped the test box I ordered to test the UFS stuff would have arrived by now since I wanted to test boot this first... but it's held up in customs, it seems, so after yet another delay I'll push this an the man page in.

Would you mind sharing which test box you ordered?
I think it would be easier to troubleshoot if we have the same device.

Minisforum S100-US Intel® N100 / 8GB RAM+256GB SSD / US is what I ordered.
https://store.minisforum.com/products/minisforum-s100?_pos=1&_psq=Minisforum+S100-US&_ss=e&_v=1.0
though it's showing out of stock at the moment... I ordered mine about a month and a half ago now and had to wait until now to get it (now the tracking is telling me it will be here any day... Monday the tracking info made it sound like it was weeks away).