Differential D50685

nvme: Move opcode and status code tables from base CAM to nvme_util.c
ClosedPublic
Actions

Authored by jhb on Jun 4 2025, 4:32 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Oct 9, 6:41 AM

	Unknown Object (File)
	Thu, Oct 9, 2:40 AM

	Unknown Object (File)
	Fri, Sep 26, 2:26 PM

	Unknown Object (File)
	Aug 30 2025, 10:27 PM

	Unknown Object (File)
	Aug 29 2025, 4:25 PM

	Unknown Object (File)
	Aug 25 2025, 3:37 AM

	Unknown Object (File)
	Aug 22 2025, 9:46 PM

	Unknown Object (File)
	Aug 22 2025, 9:44 PM

View All 37 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG60159a98a837: nvme: Move opcode and status code tables from base CAM to nvme_util.c

Summary

This makes it possible to share these tables with the nvme(4) driver
in custom kernels that do not include any CAM support, only nvd(4).

Sponsored by: Chelsio Communications

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jun 4 2025, 4:32 PM

Herald added a reviewer: cam. · View Herald TranscriptJun 4 2025, 4:32 PM

Herald added a subscriber: dab. · View Herald Transcript

jhb requested review of this revision.Jun 4 2025, 4:32 PM

Harbormaster completed remote builds in B64640: Diff 156537.Jun 4 2025, 4:32 PM

jhb added a parent revision: D50652: nvme: Use routines from nvme_util.c to decode opcodes and status codes.Jun 4 2025, 4:32 PM

jhb removed a parent revision: D50652: nvme: Use routines from nvme_util.c to decode opcodes and status codes.

jhb added a child revision: D50652: nvme: Use routines from nvme_util.c to decode opcodes and status codes.

Include nvme_util.c in CAM kernels without nvme

Harbormaster completed remote builds in B64642: Diff 156539.Jun 4 2025, 4:38 PM

imp accepted this revision.Jun 4 2025, 4:39 PM

imp added inline comments.

sys/dev/nvme/nvme_util.c
40	Still a dupe?

This revision is now accepted and ready to land.Jun 4 2025, 4:39 PM

What about cam.ko?

cam.ko already includes nvme_util.c. (Which means that today it is present in both cam.ko and nvme.ko. Not sure how that works out if you try to kldload both of them in a MINIMAL kernel. I would probably vote for taking it out of nvme.ko since nvme.ko already depends on cam.ko unconditionally.)

sys/dev/nvme/nvme_util.c
40	I trim this comment in the followup change that removes the tables from nvme_qpair.c.

Closed by commit rG60159a98a837: nvme: Move opcode and status code tables from base CAM to nvme_util.c (authored by jhb). · Explain WhyJun 5 2025, 9:07 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG60159a98a837: nvme: Move opcode and status code tables from base CAM to nvme_util.c.

Revision Contents
Changeset List

Path

Size

sys/

cam/

nvme/

2 lines

224 lines

conf/

2 lines

dev/

nvme/

4 lines

231 lines

Diff 156591

sys/cam/nvme/nvme_all.h

Loading...

sys/cam/nvme/nvme_all.c

Loading...

sys/conf/files

Loading...

sys/dev/nvme/nvme.h

Loading...

sys/dev/nvme/nvme_util.c

Loading...