Paths

Table of Contentst

Differential D33935

crypto: Add an API supporting curve25519.
ClosedPublic
Actions

Authored by jhb on Jan 18 2022, 10:51 PM.

Tags

None

Referenced Files

	F161891659: D33935.diff
	Tue, Jul 7, 6:49 PM

	Unknown Object (File)
	Sun, Jul 5, 1:08 PM

	Unknown Object (File)
	Sat, Jul 4, 2:10 PM

	Unknown Object (File)
	Sat, Jul 4, 4:34 AM

	Unknown Object (File)
	Fri, Jul 3, 7:40 PM

	Unknown Object (File)
	Fri, Jul 3, 5:27 PM

	Unknown Object (File)
	Fri, Jul 3, 7:53 AM

	Unknown Object (File)
	Thu, Jul 2, 12:56 AM

Subscribers

Details

Reviewers

Commits

rGb29bd06e67d2: crypto: Add an API supporting curve25519.
rG0c6274a819ff: crypto: Add an API supporting curve25519.

Summary

This adds a wrapper around libsodium's curve25519 support matching
Linux's curve25519 API. The intended use case for this is WireGuard.

Note that this is not integrated with OCF as it is not related to
symmetric operations on data.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 18 2022, 10:51 PM

Herald added subscribers: jmg, imp. · View Herald TranscriptJan 18 2022, 10:51 PM

jhb requested review of this revision.Jan 18 2022, 10:51 PM

Harbormaster completed remote builds in B43976: Diff 101615.Jan 18 2022, 10:51 PM

emaste added inline comments.Jan 19 2022, 2:04 AM

sys/crypto/curve25519.h
19	"REGENTS"?
sys/crypto/libsodium/utils.c
1–20	I wonder if we shouldn't use just the ISC license, with perhaps a special comment on `sodium_memzero` - I imagine that if we needed to extend what we support over time we'd just bring in more of libsodium's utils.c?

markj accepted this revision.Jan 19 2022, 5:05 PM

markj added inline comments.

sys/crypto/curve25519.c
46	I noticed that the Linux implementations check for an all-zeros secret, presumably as a seatbelt against programming errors? A clamped secret can't be all-zeros...
sys/crypto/curve25519.h
49	libsodium handles clamping for you, but I guess it doesn't hurt to be sure.

This revision is now accepted and ready to land.Jan 19 2022, 5:05 PM

jhb added inline comments.Jan 20 2022, 8:54 PM

sys/crypto/curve25519.c
19	Similarly.
sys/crypto/curve25519.h
19	Sigh, I must have copied this from the wrong file, I will fix.
49	WireGuard expects to use this function directly, but yes, I noticed libsodium already does this.
sys/crypto/libsodium/utils.c
1–20	Mmm, yeah.

jhb marked 3 inline comments as done.Jan 20 2022, 10:33 PM

jhb added inline comments.Jan 20 2022, 10:44 PM

sys/crypto/curve25519.c
46	It also checks the computed value, perhaps as a seatbelt against broken backends (since they support MD backends)? I could add the check against all zeroes if you think it's warranted.

markj added inline comments.Jan 21 2022, 12:57 AM

sys/crypto/curve25519.c
46	I think the change is fine as-is.

License fixes.

This revision now requires review to proceed.Jan 21 2022, 1:01 AM

Harbormaster completed remote builds in B44024: Diff 101713.Jan 21 2022, 1:01 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 24 2022, 11:29 PM

Closed by commit rG0c6274a819ff: crypto: Add an API supporting curve25519. (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG0c6274a819ff: crypto: Add an API supporting curve25519..

jhb added a commit: rGb29bd06e67d2: crypto: Add an API supporting curve25519..Jul 13 2022, 7:44 PM

Revision Contents
Changeset List

Path

Size

sys/

conf/

11 lines

crypto/

58 lines

46 lines

libsodium/

3 lines

31 lines

modules/

crypto/

12 lines

Diff 101857

sys/conf/files

Loading...

sys/crypto/curve25519.h

Loading...

sys/crypto/curve25519.c

Loading...

sys/crypto/libsodium/stdlib.h

Loading...

sys/crypto/libsodium/utils.c

Loading...

sys/modules/crypto/Makefile

Loading...