Page MenuHomeFreeBSD
Differential D50708

MK_FORTH: Allow removing loader.4th w/ delete-old
ClosedPublic
Actions

Authored by ziaee on Jun 5 2025, 11:20 PM.
Tags
None
Referenced Files
F176429025: D50708.diff
Sun, Oct 18, 8:34 PM
Unknown Object (File)
Wed, Oct 7, 1:06 AM
Unknown Object (File)
Tue, Oct 6, 1:29 PM
Unknown Object (File)
Mon, Oct 5, 10:47 AM
Unknown Object (File)
Sun, Oct 4, 5:02 PM
Unknown Object (File)
Thu, Oct 1, 11:17 AM
Unknown Object (File)
Sun, Sep 20, 2:31 PM
Unknown Object (File)
Sun, Sep 20, 2:31 PM
View All Files
Subscribers
tsoome

Details

Reviewers
kevans
imp
carlavilla
mhorne
manu
ivy
Group Reviewers
Loader
Commits
rGdaf2a1380291: MK_FORTH: Allow removing loader.4th w/ delete-old
Summary

The lua loader is quite mature, and /boot is getting a bit cluttered.
Allow removing the forth loader with make delete-old if WITHOUT_FORTH
is set, instead of the previous behavior of only removing the doc.

As usual, please be suspicious; I have no idea what I'm doing. I have
been deleting these files for a while, and have tested this as well.
It makes /boot a lot more managable by being viewable with ls in one
window of 80x25. Particularly, I suspect .so is a library so I put that
under make delete-old-libs.

MFC: no, i dont think so since this is a breaking change of behavior

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64670
Build 61554: arc lint + arc unit

Event Timeline

ziaee requested review of this revision.Jun 5 2025, 11:20 PM
ziaee created this revision.
Harbormaster completed remote builds in B64667: Diff 156599.Jun 5 2025, 11:20 PM
ziaee updated this revision to Diff 156622.Jun 6 2025, 12:55 PM

missed a spot

Harbormaster completed remote builds in B64670: Diff 156622.Jun 6 2025, 12:55 PM
imp added inline comments.Jun 6 2025, 2:28 PM
tools/build/mk/OptionalObsoleteFiles.inc
2005

This one feels wrong

ziaee added inline comments.Jun 6 2025, 2:42 PM
tools/build/mk/OptionalObsoleteFiles.inc
2005

Thanks for looking this over so soon! Why? I figured, if the administrator wants to removing the 4th loader, we should remove the all of it's stuff.

The administrator will still have loader_simp.old and loader_efi.old.

tsoome added a subscriber: tsoome.Jun 6 2025, 4:57 PM
tsoome added inline comments.
tools/build/mk/OptionalObsoleteFiles.inc
2005

might there appear loader_4th.efi.old ?

ziaee added inline comments.Jun 6 2025, 5:51 PM
tools/build/mk/OptionalObsoleteFiles.inc
2005

I do not know. Back before the Lua loader I did not take any interest in the internals.

kevans added inline comments.Jun 11 2025, 11:23 PM
UPDATING
31–32

Typo repeated in the commit message as well.

tools/build/mk/OptionalObsoleteFiles.inc
2005

We chatted a bit and it's probably fine to remove; it's created as a backup, might as well clean it up if we're nuking the rest of the scripts.

ziaee updated this revision to Diff 156853.Jun 11 2025, 11:27 PM

Fix typo, add loader_4th.efi.old. Thanks @kevans and @tsoome!

Harbormaster completed remote builds in B64776: Diff 156853.Jun 11 2025, 11:27 PM
ziaee edited the summary of this revision. (Show Details)Jun 11 2025, 11:27 PM
kevans accepted this revision as: kevans.Jun 12 2025, 12:21 AM
This revision is now accepted and ready to land.Jun 12 2025, 12:21 AM
Closed by commit rGdaf2a1380291: MK_FORTH: Allow removing loader.4th w/ delete-old (authored by ziaee). · Explain WhyJun 25 2025, 11:22 PM
This revision was automatically updated to reflect the committed changes.
ziaee added a commit: rGdaf2a1380291: MK_FORTH: Allow removing loader.4th w/ delete-old.

Revision Contents
Changeset List

PathSize
4 lines
tools/
build/
mk/
25 lines

Diff 156622

View Options

UPDATING

Loading...
View Options

tools/build/mk/OptionalObsoleteFiles.inc

Loading...